From: Masahiro Yamada <masahiroy@kernel.org>
To: Wolfram Sang <wsa@kernel.org>
Cc: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>,
linux-i2c@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: uniphier: Remove superfluous error message in uniphier_i2c_probe()
Date: Mon, 4 May 2020 09:15:14 +0900 [thread overview]
Message-ID: <CAK7LNASXgD7Y2SToycCLYX2zVN-L5uWRoCzQ3N7MjoT+j0KfkQ@mail.gmail.com> (raw)
In-Reply-To: <20200503132906.GA32207@ninjato>
On Sun, May 3, 2020 at 10:29 PM Wolfram Sang <wsa@kernel.org> wrote:
>
> On Sun, May 03, 2020 at 05:38:47PM +0530, Aishwarya Ramakrishnan wrote:
> > The function platform_get_irq can log an error by itself.
> > This omit a redundant message for exception handling in the
> > calling function.
> >
> > Suggested by Coccinelle.
> >
> > Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
>
> Please send only one patch for the whole I2C subsystem.
>
Yeah, and then please add my ack to v2.
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2020-05-04 0:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 12:08 [PATCH] i2c: uniphier: Remove superfluous error message in uniphier_i2c_probe() Aishwarya Ramakrishnan
2020-05-03 13:29 ` Wolfram Sang
2020-05-04 0:15 ` Masahiro Yamada [this message]
2020-05-04 11:44 ` [PATCH] i2c: drivers: Remove superfluous error message Aishwarya Ramakrishnan
2020-05-04 12:42 ` Andy Shevchenko
2020-05-04 12:44 ` Andy Shevchenko
2020-05-04 14:30 ` Masahiro Yamada
2020-05-05 14:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASXgD7Y2SToycCLYX2zVN-L5uWRoCzQ3N7MjoT+j0KfkQ@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=aishwaryarj100@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).