From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B2CC4320A for ; Mon, 26 Jul 2021 08:11:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 739A460F4A for ; Mon, 26 Jul 2021 08:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbhGZHbW (ORCPT ); Mon, 26 Jul 2021 03:31:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:41124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232346AbhGZHbV (ORCPT ); Mon, 26 Jul 2021 03:31:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5EEF160F4A; Mon, 26 Jul 2021 08:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627287110; bh=x9BfLt21eI+bS8doUSvOI3N0Cb/8WZxlnko7Fk5mChY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Mmwv1I9HuLDrkWE1iwdzYaxKnNykSm6bPuX1vgCqsY6tQOYrVjLG20i2W5jEBxrdd egZ6Uh68mDM58KhM5sgD+h13jcsJvwdJKZGkC4iJ4WR6L26Bi8QANFAGH4rBqPHoxS Hk5udWcuIfvJDvtxIe537hr1IMasPms5s/l27DGX7fPj66roOzYs2Asx5ueGtPmKQq Ip3RX63svpfmm4OrSOdWXkS/7IlREwACWuvwSA5zGlGTC2gPLhQKVP36oLNqjZ9l5n Yy+Cs27DRckXLgJIpLKBWUjouZrLNCqmxl3J7mG1Y4+r4b08VyCItlwhZh4QMoh/rk jla3snJ8Pm3+A== Received: by mail-wr1-f42.google.com with SMTP id n12so6422186wrr.2; Mon, 26 Jul 2021 01:11:50 -0700 (PDT) X-Gm-Message-State: AOAM533ZCVQfgBTRJ2ge682HyjzJldgN5n3VHBO0uFe3fVMzr2AtJl2L 3EjiWhpp+aEMDkVu78od/q8Bgi3O151rA2YdUd0= X-Google-Smtp-Source: ABdhPJxG7BvoCYsqUtkwdHizGdjcpK4OiCLglI/wh62vI4zXHtiEnOj0MvxoAE1MXYgl87VRCwNn5nPTCFq2f6cG5bo= X-Received: by 2002:adf:e107:: with SMTP id t7mr17820045wrz.165.1627287108986; Mon, 26 Jul 2021 01:11:48 -0700 (PDT) MIME-Version: 1.0 References: <4182aff2d1437b30025f3d17d11e5fdc21845239.1627273794.git.viresh.kumar@linaro.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 26 Jul 2021 10:11:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio To: Viresh Kumar Cc: Jason Wang , "Michael S. Tsirkin" , Rob Herring , Jean-Philippe Brucker , Vincent Guittot , Bill Mills , =?UTF-8?B?QWxleCBCZW5uw6ll?= , "Enrico Weigelt, metux IT consult" , Jie Deng , DTML , Linux Kernel Mailing List , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" , Wolfram Sang , Linux I2C Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann wrote: > > On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar wrote: > > > > This patch adds binding for virtio I2C device, it is based on > > virtio-device bindings. > > > > Acked-by: Wolfram Sang > > Signed-off-by: Viresh Kumar > > Reviewed-by: Arnd Bergmann Too quick, after seeing the same issue in the gpio binding I saw it here too: > + i2c-virtio { > + compatible = "virtio,22"; The node name "i2c-virtio" looks wrong. According to https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml, this needs to be plain "i2c". Arnd