Linux-i2c Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 00/28] DT: Improve validation for Marvell SoCs
@ 2020-03-17  9:38 Lubomir Rintel
  2020-03-17  9:38 ` [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name Lubomir Rintel
                   ` (19 more replies)
  0 siblings, 20 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:38 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

Hello World,

chained to this message is a set of patches that improve coverage of Device
Tree validation for devices typically found on Marvell SoCs. It converts most
of the peripheral binding documentation to YAML and fixes up validation issues
in the SoC device trees.

It starts with fixing the issues:

  [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name
  [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name
  [PATCH 03/28] ARM: dts: pxa168: Add missing address/size cells to i2c
  [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number
  [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio
  [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number
  [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts
  [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts
  [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name
  [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names
  [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI node names

Then the binding fixes follow.

When converting .txt binding files that were not written by myself,
I didn't include the SPDX license tag and set the maintaners: to the
devicetree@ list. The reason is that the original binding files don't
contain the information and I didn't want to speak for anyone else and
make it up.

If this is not the correct thing to do, or the respective binding
contributors want to clarify the licensing or be listed as maintainers,
please respond and I'll send an updated patch set. I'm also happy to
maintain any of these bindings.

  [PATCH 12/28] spi: dt-bindings: spi-controller: Slaves have no
  [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to
  [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible
  [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings
  [PATCH 16/28] dt-bindings: Add "mrvl", a legacy vendor prefix for
  [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example
  [PATCH 18/28] dt-bindings: mmc: Fix node name in an example
  [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema
  [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema
  [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema
  [PATCH 22/28] dt-bindings: i2c: Convert i2c-pxa to json-schema
  [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc to
  [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic to
  [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc to json-schema
  [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema
  [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer to
  [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema

None of the patches depends on any other and they can be applied in any
order.

Love,
Lubo

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
@ 2020-03-17  9:38 ` Lubomir Rintel
       [not found]   ` <20200317093922.20785-2-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:39 ` [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
                   ` (18 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:38 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

The current ones makes validation unhappy:

  kirkwood-lsxhl.dt.yaml: main-interrupt-ctrl@20200: $nodename:0:
    'main-interrupt-ctrl@20200' does not match
    '^interrupt-controller(@[0-9a-f,]+)*$'

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/kirkwood.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/kirkwood.dtsi b/arch/arm/boot/dts/kirkwood.dtsi
index 2161e23bd98ef..6c8d94beae78f 100644
--- a/arch/arm/boot/dts/kirkwood.dtsi
+++ b/arch/arm/boot/dts/kirkwood.dtsi
@@ -228,7 +228,7 @@ l2: l2-cache@20128 {
 			reg = <0x20128 0x4>;
 		};
 
-		intc: main-interrupt-ctrl@20200 {
+		intc: interrupt-controller@20200 {
 			compatible = "marvell,orion-intc";
 			interrupt-controller;
 			#interrupt-cells = <1>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-17  9:38   ` Lubomir Rintel
  2020-03-17 13:20     ` Andrew Lunn
  2020-03-17  9:38   ` [PATCH 03/28] ARM: dts: pxa168: Add missing address/size cells to i2c nodes Lubomir Rintel
                     ` (9 subsequent siblings)
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:38 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

The current ones makes validation unhappy:

  dove-d3plug.dt.yaml: main-interrupt-ctrl@20200: $nodename:0:
      'main-interrupt-ctrl@20200' does not match
      '^interrupt-controller(@[0-9a-f,]+)*$'

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/dove.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi
index 3081b04e8c08f..ddd4653f52811 100644
--- a/arch/arm/boot/dts/dove.dtsi
+++ b/arch/arm/boot/dts/dove.dtsi
@@ -248,7 +248,7 @@ bridge_intc: bridge-interrupt-ctrl@20110 {
 				marvell,#interrupts = <5>;
 			};
 
-			intc: main-interrupt-ctrl@20200 {
+			intc: interrupt-controller@20200 {
 				compatible = "marvell,orion-intc";
 				interrupt-controller;
 				#interrupt-cells = <1>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 03/28] ARM: dts: pxa168: Add missing address/size cells to i2c nodes
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:38   ` [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name Lubomir Rintel
@ 2020-03-17  9:38   ` Lubomir Rintel
       [not found]     ` <20200317093922.20785-4-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:38   ` [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number Lubomir Rintel
                     ` (8 subsequent siblings)
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:38 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

This makes the nodes compatible with the generic i2c binding without the
board DTS files having to supply the necessary properties themselves.

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/pxa168.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/pxa168.dtsi b/arch/arm/boot/dts/pxa168.dtsi
index 72f8cb60cb531..c39d00fe07982 100644
--- a/arch/arm/boot/dts/pxa168.dtsi
+++ b/arch/arm/boot/dts/pxa168.dtsi
@@ -116,6 +116,8 @@ gcb3: gpio@d4019100 {
 
 			twsi1: i2c@d4011000 {
 				compatible = "mrvl,mmp-twsi";
+				#address-cells = <1>;
+				#size-cells = <0>;
 				reg = <0xd4011000 0x1000>;
 				interrupts = <7>;
 				clocks = <&soc_clocks PXA168_CLK_TWSI0>;
@@ -126,6 +128,8 @@ twsi1: i2c@d4011000 {
 
 			twsi2: i2c@d4025000 {
 				compatible = "mrvl,mmp-twsi";
+				#address-cells = <1>;
+				#size-cells = <0>;
 				reg = <0xd4025000 0x1000>;
 				interrupts = <58>;
 				clocks = <&soc_clocks PXA168_CLK_TWSI1>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:38   ` [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name Lubomir Rintel
  2020-03-17  9:38   ` [PATCH 03/28] ARM: dts: pxa168: Add missing address/size cells to i2c nodes Lubomir Rintel
@ 2020-03-17  9:38   ` Lubomir Rintel
  2020-03-17 13:27     ` Andrew Lunn
  2020-03-17  9:38   ` [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property Lubomir Rintel
                     ` (7 subsequent siblings)
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:38 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

gpio-pxa uses two cell to encode the interrupt source: the pin number
and the trigger type. Adjust the device node accordingly.

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/pxa168.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/pxa168.dtsi b/arch/arm/boot/dts/pxa168.dtsi
index c39d00fe07982..c6ac85e362d8a 100644
--- a/arch/arm/boot/dts/pxa168.dtsi
+++ b/arch/arm/boot/dts/pxa168.dtsi
@@ -94,7 +94,7 @@ gpio@d4019000 {
 				resets = <&soc_clocks PXA168_CLK_GPIO>;
 				interrupt-names = "gpio_mux";
 				interrupt-controller;
-				#interrupt-cells = <1>;
+				#interrupt-cells = <2>;
 				ranges;
 
 				gcb0: gpio@d4019000 {
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (2 preceding siblings ...)
  2020-03-17  9:38   ` [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number Lubomir Rintel
@ 2020-03-17  9:38   ` Lubomir Rintel
       [not found]     ` <20200317093922.20785-6-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:39   ` [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number Lubomir Rintel
                     ` (6 subsequent siblings)
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:38 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

This way the device tree validator learns that each cell of the property
constitutes a separate item. Otherwise it gets unnecessairly upset:

  pxa300-raumfeld-speaker-s.dt.yaml: gpio@40e00000: interrupts:
      [[8, 9, 10]] is too short

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/pxa3xx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/pxa3xx.dtsi b/arch/arm/boot/dts/pxa3xx.dtsi
index c237a0e4b12ae..d19674812cd2d 100644
--- a/arch/arm/boot/dts/pxa3xx.dtsi
+++ b/arch/arm/boot/dts/pxa3xx.dtsi
@@ -170,7 +170,7 @@ gpio: gpio@40e00000 {
 			clocks = <&clks CLK_GPIO>;
 			gpio-ranges = <&pinctrl 0 0 128>;
 			interrupt-names = "gpio0", "gpio1", "gpio_mux";
-			interrupts = <8 9 10>;
+			interrupts = <8>, <9>, <10>;
 			gpio-controller;
 			#gpio-cells = <0x2>;
 			interrupt-controller;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (3 preceding siblings ...)
  2020-03-17  9:38   ` [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property Lubomir Rintel
@ 2020-03-17  9:39   ` Lubomir Rintel
  2020-03-17 13:29     ` Andrew Lunn
  2020-03-17  9:39   ` [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
                     ` (5 subsequent siblings)
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

gpio-pxa uses two cell to encode the interrupt source: the pin number
and the trigger type. Adjust the device node accordingly.

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/pxa910.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/pxa910.dtsi b/arch/arm/boot/dts/pxa910.dtsi
index b3d6182d4de4a..5f8e208916b31 100644
--- a/arch/arm/boot/dts/pxa910.dtsi
+++ b/arch/arm/boot/dts/pxa910.dtsi
@@ -106,7 +106,7 @@ gpio@d4019000 {
 				clocks = <&soc_clocks PXA910_CLK_GPIO>;
 				resets = <&soc_clocks PXA910_CLK_GPIO>;
 				interrupt-controller;
-				#interrupt-cells = <1>;
+				#interrupt-cells = <2>;
 				ranges;
 
 				gcb0: gpio@d4019000 {
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (4 preceding siblings ...)
  2020-03-17  9:39   ` [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number Lubomir Rintel
@ 2020-03-17  9:39   ` Lubomir Rintel
  2020-03-17 13:29     ` Andrew Lunn
  2020-03-17  9:39   ` [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name Lubomir Rintel
                     ` (4 subsequent siblings)
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

This way the device tree validator learns that each cell of the property
constitutes a separate item. Otherwise it gets unnecessairly upset:

  pxa168-aspenite.dt.yaml: rtc@d4010000: interrupts: [[5, 6]] is too short
  pxa910-dkb.dt.yaml: rtc@d4010000: interrupts: [[5, 6]] is too short

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/pxa168.dtsi | 2 +-
 arch/arm/boot/dts/pxa910.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/pxa168.dtsi b/arch/arm/boot/dts/pxa168.dtsi
index c6ac85e362d8a..ae2221a3f825f 100644
--- a/arch/arm/boot/dts/pxa168.dtsi
+++ b/arch/arm/boot/dts/pxa168.dtsi
@@ -140,7 +140,7 @@ twsi2: i2c@d4025000 {
 			rtc: rtc@d4010000 {
 				compatible = "mrvl,mmp-rtc";
 				reg = <0xd4010000 0x1000>;
-				interrupts = <5 6>;
+				interrupts = <5>, <6>;
 				interrupt-names = "rtc 1Hz", "rtc alarm";
 				clocks = <&soc_clocks PXA168_CLK_RTC>;
 				resets = <&soc_clocks PXA168_CLK_RTC>;
diff --git a/arch/arm/boot/dts/pxa910.dtsi b/arch/arm/boot/dts/pxa910.dtsi
index 5f8e208916b31..774e8e9730924 100644
--- a/arch/arm/boot/dts/pxa910.dtsi
+++ b/arch/arm/boot/dts/pxa910.dtsi
@@ -152,7 +152,7 @@ twsi2: i2c@d4037000 {
 			rtc: rtc@d4010000 {
 				compatible = "mrvl,mmp-rtc";
 				reg = <0xd4010000 0x1000>;
-				interrupts = <5 6>;
+				interrupts = <5>, <6>;
 				interrupt-names = "rtc 1Hz", "rtc alarm";
 				clocks = <&soc_clocks PXA910_CLK_RTC>;
 				resets = <&soc_clocks PXA910_CLK_RTC>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts property
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
  2020-03-17  9:38 ` [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
       [not found]   ` <20200317093922.20785-9-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:39 ` [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names Lubomir Rintel
                   ` (17 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

This way the device tree validator learns that each cell of the property
constitutes a separate item. Otherwise it gets unnecessairly upset:

  mmp3-dell-ariel.dt.yaml: rtc@d4010000: interrupts: [[1, 0]] is too short

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/mmp2.dtsi | 2 +-
 arch/arm/boot/dts/mmp3.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
index 6a2f072c1d0a8..173ee68e877fd 100644
--- a/arch/arm/boot/dts/mmp2.dtsi
+++ b/arch/arm/boot/dts/mmp2.dtsi
@@ -364,7 +364,7 @@ twsi6: i2c@d4034000 {
 			rtc: rtc@d4010000 {
 				compatible = "mrvl,mmp-rtc";
 				reg = <0xd4010000 0x1000>;
-				interrupts = <1 0>;
+				interrupts = <1>, <0>;
 				interrupt-names = "rtc 1Hz", "rtc alarm";
 				interrupt-parent = <&intcmux5>;
 				clocks = <&soc_clocks MMP2_CLK_RTC>;
diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
index 59a108e49b41e..649aa74851257 100644
--- a/arch/arm/boot/dts/mmp3.dtsi
+++ b/arch/arm/boot/dts/mmp3.dtsi
@@ -474,7 +474,7 @@ twsi6: i2c@d4034000 {
 			rtc: rtc@d4010000 {
 				compatible = "mrvl,mmp-rtc";
 				reg = <0xd4010000 0x1000>;
-				interrupts = <1 0>;
+				interrupts = <1>, <0>;
 				interrupt-names = "rtc 1Hz", "rtc alarm";
 				interrupt-parent = <&rtc_mux>;
 				clocks = <&soc_clocks MMP2_CLK_RTC>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (5 preceding siblings ...)
  2020-03-17  9:39   ` [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
@ 2020-03-17  9:39   ` Lubomir Rintel
  2020-03-17 13:31     ` Andrew Lunn
  2020-03-17  9:39   ` [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example Lubomir Rintel
                     ` (3 subsequent siblings)
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

The current one makes validation unhappy:

  mmp3-dell-ariel.dt.yaml: l2-cache-controller@d0020000: $nodename:0:
      'l2-cache-controller@d0020000' does not match
      '^(cache-controller|cpu)(@[0-9a-f,]+)*$'

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 arch/arm/boot/dts/mmp3.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
index 649aa74851257..eaff9b1bc1d9f 100644
--- a/arch/arm/boot/dts/mmp3.dtsi
+++ b/arch/arm/boot/dts/mmp3.dtsi
@@ -523,7 +523,7 @@ ssp4: spi@d4039000 {
 			};
 		};
 
-		l2: l2-cache-controller@d0020000 {
+		l2: cache-controller@d0020000 {
 			compatible = "marvell,tauros3-cache", "arm,pl310-cache";
 			reg = <0xd0020000 0x1000>;
 			cache-unified;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
  2020-03-17  9:38 ` [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name Lubomir Rintel
  2020-03-17  9:39 ` [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-17 13:32   ` Andrew Lunn
  2020-03-17  9:39 ` [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI " Lubomir Rintel
                   ` (16 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

There are better generic ones and the validation is going to complain:

  mmp3-dell-ariel.dt.yaml: hsic@f0001000: $nodename:0: 'hsic@f0001000'
      does not match '^usb(@.*)?'
  mmp3-dell-ariel.dt.yaml: hsic@f0002000: $nodename:0: 'hsic@f0002000'
      does not match '^usb(@.*)?'
  ...

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/mmp3.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
index eaff9b1bc1d9f..fc75f96106351 100644
--- a/arch/arm/boot/dts/mmp3.dtsi
+++ b/arch/arm/boot/dts/mmp3.dtsi
@@ -183,14 +183,14 @@ hsi0_mux: interrupt-controller@d42821d0 {
 				mrvl,intc-nr-irqs = <5>;
 			};
 
-			usb_otg_phy0: usb-otg-phy@d4207000 {
+			usb_otg_phy0: usb-phy@d4207000 {
 				compatible = "marvell,mmp3-usb-phy";
 				reg = <0xd4207000 0x40>;
 				#phy-cells = <0>;
 				status = "disabled";
 			};
 
-			usb_otg0: usb-otg@d4208000 {
+			usb_otg0: usb@d4208000 {
 				compatible = "marvell,pxau2o-ehci";
 				reg = <0xd4208000 0x200>;
 				interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
@@ -201,7 +201,7 @@ usb_otg0: usb-otg@d4208000 {
 				status = "disabled";
 			};
 
-			hsic_phy0: hsic-phy@f0001800 {
+			hsic_phy0: usb-phy@f0001800 {
 				compatible = "marvell,mmp3-hsic-phy",
 					     "usb-nop-xceiv";
 				reg = <0xf0001800 0x40>;
@@ -209,7 +209,7 @@ hsic_phy0: hsic-phy@f0001800 {
 				status = "disabled";
 			};
 
-			hsic0: hsic@f0001000 {
+			hsic0: usb@f0001000 {
 				compatible = "marvell,pxau2o-ehci";
 				reg = <0xf0001000 0x200>;
 				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
@@ -223,7 +223,7 @@ hsic0: hsic@f0001000 {
 				status = "disabled";
 			};
 
-			hsic_phy1: hsic-phy@f0002800 {
+			hsic_phy1: usb-phy@f0002800 {
 				compatible = "marvell,mmp3-hsic-phy",
 					     "usb-nop-xceiv";
 				reg = <0xf0002800 0x40>;
@@ -231,7 +231,7 @@ hsic_phy1: hsic-phy@f0002800 {
 				status = "disabled";
 			};
 
-			hsic1: hsic@f0002000 {
+			hsic1: usb@f0002000 {
 				compatible = "marvell,pxau2o-ehci";
 				reg = <0xf0002000 0x200>;
 				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI node names
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (2 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-17 13:34   ` Andrew Lunn
  2020-03-17  9:39 ` [PATCH 12/28] spi: dt-bindings: spi-controller: Slaves have no address cells Lubomir Rintel
                   ` (15 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

The node name preferred by mmc-controller.yaml binding spec is "mmc":

  berlin2-sony-nsz-gs7.dt.yaml: sdhci@ab0000: $nodename:0:
      'sdhci@ab0000' does not match '^mmc(@.*)?$'
  berlin2-sony-nsz-gs7.dt.yaml: sdhci@ab0800: $nodename:0:
      'sdhci@ab0800' does not match '^mmc(@.*)?$'
  berlin2-sony-nsz-gs7.dt.yaml: sdhci@ab1000: $nodename:0:
      'sdhci@ab1000' does not match '^mmc(@.*)?$'
  berlin2cd-google-chromecast.dt.yaml: sdhci@ab0000: $nodename:0:
      'sdhci@ab0000' does not match '^mmc(@.*)?$'
  berlin2cd-valve-steamlink.dt.yaml: sdhci@ab0000: $nodename:0:
      'sdhci@ab0000' does not match '^mmc(@.*)?$'
  berlin2q-marvell-dmp.dt.yaml: sdhci@ab0000: $nodename:0:
      'sdhci@ab0000' does not match '^mmc(@.*)?$'
  berlin2q-marvell-dmp.dt.yaml: sdhci@ab0800: $nodename:0:
      'sdhci@ab0800' does not match '^mmc(@.*)?$'
  berlin2q-marvell-dmp.dt.yaml: sdhci@ab1000: $nodename:0:
      'sdhci@ab1000' does not match '^mmc(@.*)?$'

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/berlin2.dtsi   | 6 +++---
 arch/arm/boot/dts/berlin2cd.dtsi | 2 +-
 arch/arm/boot/dts/berlin2q.dtsi  | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/berlin2.dtsi b/arch/arm/boot/dts/berlin2.dtsi
index d2f7d984bba5c..3ab3cd250da70 100644
--- a/arch/arm/boot/dts/berlin2.dtsi
+++ b/arch/arm/boot/dts/berlin2.dtsi
@@ -77,7 +77,7 @@ soc@f7000000 {
 
 		ranges = <0 0xf7000000 0x1000000>;
 
-		sdhci0: sdhci@ab0000 {
+		sdhci0: mmc@ab0000 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0000 0x200>;
 			clocks = <&chip_clk CLKID_SDIO0XIN>, <&chip_clk CLKID_SDIO0>;
@@ -86,7 +86,7 @@ sdhci0: sdhci@ab0000 {
 			status = "disabled";
 		};
 
-		sdhci1: sdhci@ab0800 {
+		sdhci1: mmc@ab0800 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0800 0x200>;
 			clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO1>;
@@ -95,7 +95,7 @@ sdhci1: sdhci@ab0800 {
 			status = "disabled";
 		};
 
-		sdhci2: sdhci@ab1000 {
+		sdhci2: mmc@ab1000 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab1000 0x200>;
 			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi
index e5c1f4213ff90..7cf3e6302d75c 100644
--- a/arch/arm/boot/dts/berlin2cd.dtsi
+++ b/arch/arm/boot/dts/berlin2cd.dtsi
@@ -62,7 +62,7 @@ soc@f7000000 {
 
 		ranges = <0 0xf7000000 0x1000000>;
 
-		sdhci0: sdhci@ab0000 {
+		sdhci0: mmc@ab0000 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0000 0x200>;
 			clocks = <&chip_clk CLKID_SDIO0XIN>, <&chip_clk CLKID_SDIO0>;
diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 99d6872a6dfcc..c44a32e873f44 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -122,7 +122,7 @@ soc@f7000000 {
 		ranges = <0 0xf7000000 0x1000000>;
 		interrupt-parent = <&gic>;
 
-		sdhci0: sdhci@ab0000 {
+		sdhci0: mmc@ab0000 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0000 0x200>;
 			clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
@@ -131,7 +131,7 @@ sdhci0: sdhci@ab0000 {
 			status = "disabled";
 		};
 
-		sdhci1: sdhci@ab0800 {
+		sdhci1: mmc@ab0800 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab0800 0x200>;
 			clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
@@ -140,7 +140,7 @@ sdhci1: sdhci@ab0800 {
 			status = "disabled";
 		};
 
-		sdhci2: sdhci@ab1000 {
+		sdhci2: mmc@ab1000 {
 			compatible = "mrvl,pxav3-mmc";
 			reg = <0xab1000 0x200>;
 			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 12/28] spi: dt-bindings: spi-controller: Slaves have no address cells
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (3 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI " Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
       [not found]   ` <20200317093922.20785-13-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:39 ` [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc Lubomir Rintel
                   ` (14 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

SPI controllers in slave mode have a single child node that has no
address. Enforce #address-cells of zero instead of one.

Fixes: 0a1b929356830 ("spi: Add YAML schemas for the generic SPI options")
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../bindings/spi/spi-controller.yaml          | 23 ++++++++++++++-----
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
index d8e5509a70816..30d774cf6cc95 100644
--- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
@@ -15,16 +15,27 @@ description: |
   controller may be described for use in SPI master mode or in SPI slave mode,
   but not for both at the same time.
 
+allOf:
+  - if:
+      required:
+        - spi-slave
+    then:
+      properties:
+        "#address-cells":
+          const: 0
+        "#size-cells":
+          const: 0
+    else:
+      properties:
+        "#address-cells":
+          const: 1
+        "#size-cells":
+          const: 0
+
 properties:
   $nodename:
     pattern: "^spi(@.*|-[0-9a-f])*$"
 
-  "#address-cells":
-    const: 1
-
-  "#size-cells":
-    const: 0
-
   cs-gpios:
     description: |
       GPIOs used as chip selects.
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (4 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 12/28] spi: dt-bindings: spi-controller: Slaves have no address cells Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-17 13:48   ` Andrew Lunn
       [not found]   ` <20200317093922.20785-14-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:39 ` [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible Lubomir Rintel
                   ` (13 subsequent siblings)
  19 siblings, 2 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

These ports are compatible with NS8250 and handled by the same driver.
Get rid of the extra document that fails to document the properties that
are actually supported.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 Documentation/devicetree/bindings/serial/8250.txt        | 2 ++
 Documentation/devicetree/bindings/serial/mrvl-serial.txt | 4 ----
 2 files changed, 2 insertions(+), 4 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/serial/mrvl-serial.txt

diff --git a/Documentation/devicetree/bindings/serial/8250.txt b/Documentation/devicetree/bindings/serial/8250.txt
index 55700f20f6ee8..a543702859e2f 100644
--- a/Documentation/devicetree/bindings/serial/8250.txt
+++ b/Documentation/devicetree/bindings/serial/8250.txt
@@ -26,6 +26,8 @@ Required properties:
 	- "aspeed,ast2400-vuart"
 	- "aspeed,ast2500-vuart"
 	- "nuvoton,npcm750-uart"
+	- "mrvl,mmp-uart"
+	- "mrvl,pxa-uart"
 	- "serial" if the port type is unknown.
 - reg : offset and length of the register set for the device.
 - interrupts : should contain uart interrupt.
diff --git a/Documentation/devicetree/bindings/serial/mrvl-serial.txt b/Documentation/devicetree/bindings/serial/mrvl-serial.txt
deleted file mode 100644
index d744340de887c..0000000000000
--- a/Documentation/devicetree/bindings/serial/mrvl-serial.txt
+++ /dev/null
@@ -1,4 +0,0 @@
-PXA UART controller
-
-Required properties:
-- compatible : should be "mrvl,mmp-uart" or "mrvl,pxa-uart".
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (5 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:03   ` Rob Herring
  2020-03-27 19:04   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings Lubomir Rintel
                   ` (12 subsequent siblings)
  19 siblings, 2 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

The validation is unhappy about mmp3-dell-ariel declaring its
marvell,tauros3-cache node to be compatible with arm,pl310-cache:

  mmp3-dell-ariel.dt.yaml: cache-controller@d0020000: compatible:
       Additional items are not allowed ('arm,pl310-cache' was unexpected)
  mmp3-dell-ariel.dt.yaml: cache-controller@d0020000: compatible:
       ['marvell,tauros3-cache', 'arm,pl310-cache'] is too long

Let's allow this -- Tauros 3 is designed to be compatible with PL310.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../devicetree/bindings/arm/l2c2x0.yaml       | 45 ++++++++++---------
 1 file changed, 24 insertions(+), 21 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/l2c2x0.yaml b/Documentation/devicetree/bindings/arm/l2c2x0.yaml
index 913a8cd8b2c00..7e39088a9bed2 100644
--- a/Documentation/devicetree/bindings/arm/l2c2x0.yaml
+++ b/Documentation/devicetree/bindings/arm/l2c2x0.yaml
@@ -29,27 +29,30 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - arm,pl310-cache
-      - arm,l220-cache
-      - arm,l210-cache
-        # DEPRECATED by "brcm,bcm11351-a2-pl310-cache"
-      - bcm,bcm11351-a2-pl310-cache
-        # For Broadcom bcm11351 chipset where an
-        # offset needs to be added to the address before passing down to the L2
-        # cache controller
-      - brcm,bcm11351-a2-pl310-cache
-        # Marvell Controller designed to be
-        # compatible with the ARM one, with system cache mode (meaning
-        # maintenance operations on L1 are broadcasted to the L2 and L2
-        # performs the same operation).
-      - marvell,aurora-system-cache
-        # Marvell Controller designed to be
-        # compatible with the ARM one with outer cache mode.
-      - marvell,aurora-outer-cache
-        # Marvell Tauros3 cache controller, compatible
-        # with arm,pl310-cache controller.
-      - marvell,tauros3-cache
+    oneOf:
+      - enum:
+        - arm,pl310-cache
+        - arm,l220-cache
+        - arm,l210-cache
+          # DEPRECATED by "brcm,bcm11351-a2-pl310-cache"
+        - bcm,bcm11351-a2-pl310-cache
+          # For Broadcom bcm11351 chipset where an
+          # offset needs to be added to the address before passing down to the L2
+          # cache controller
+        - brcm,bcm11351-a2-pl310-cache
+          # Marvell Controller designed to be
+          # compatible with the ARM one, with system cache mode (meaning
+          # maintenance operations on L1 are broadcasted to the L2 and L2
+          # performs the same operation).
+        - marvell,aurora-system-cache
+          # Marvell Controller designed to be
+          # compatible with the ARM one with outer cache mode.
+        - marvell,aurora-outer-cache
+      - items:
+         # Marvell Tauros3 cache controller, compatible
+         # with arm,pl310-cache controller.
+        - const: marvell,tauros3-cache
+        - const: arm,pl310-cache
 
   cache-level:
     const: 2
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (6 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-17 13:54   ` Andrew Lunn
  2020-03-27 19:06   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 16/28] dt-bindings: Add "mrvl", a legacy vendor prefix for Marvell Lubomir Rintel
                   ` (11 subsequent siblings)
  19 siblings, 2 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

Add compatible strings for the boards we have in tree. At the same time,
fix the MMP3 compatible string: the preferred vendor name for Marvell is
"marvell", not "mrvl", and indeed "marvell,mmp3" has been actively used,
not "mrvl,mmp3".

Fixes: 95aecb71b84e ("dt-bindings: arm: mrvl: Document MMP3 compatible string")
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 Documentation/devicetree/bindings/arm/mrvl/mrvl.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/mrvl/mrvl.yaml b/Documentation/devicetree/bindings/arm/mrvl/mrvl.yaml
index 818dfe6de5120..3235ec9e9bad1 100644
--- a/Documentation/devicetree/bindings/arm/mrvl/mrvl.yaml
+++ b/Documentation/devicetree/bindings/arm/mrvl/mrvl.yaml
@@ -28,8 +28,11 @@ properties:
         items:
           - enum:
               - mrvl,mmp2-brownstone
+              - olpc,xo-1.75
           - const: mrvl,mmp2
       - description: MMP3 based boards
         items:
-          - const: mrvl,mmp3
+          - enum:
+              - dell,wyse-ariel
+          - const: marvell,mmp3
 ...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 16/28] dt-bindings: Add "mrvl", a legacy vendor prefix for Marvell
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (7 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:06   ` Rob Herring
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                   ` (10 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

While the preferred vendor prefix is "marvell", "mrvl" is used by many
older bindings already. Add it, while also marking it deprecated.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 23ca95bee2985..1653de506db1a 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -645,6 +645,9 @@ patternProperties:
     description: Monolithic Power Systems Inc.
   "^mqmaker,.*":
     description: mqmaker Inc.
+  "^mrvl,.*":
+    description: Marvell Technology Group Ltd.
+    deprecated: true
   "^mscc,.*":
     description: Microsemi Corporation
   "^msi,.*":
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (6 preceding siblings ...)
  2020-03-17  9:39   ` [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name Lubomir Rintel
@ 2020-03-17  9:39   ` Lubomir Rintel
  2020-03-17 10:04     ` Sergei Shtylyov
       [not found]     ` <20200317093922.20785-18-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17  9:39   ` [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema Lubomir Rintel
                     ` (2 subsequent siblings)
  10 siblings, 2 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

This way the validator can know that the two cells constitute a singlej
pair of clock phase degrees value, not separate items Otherwise it is
unhappy:

  mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:0:
      [63] is too short
  mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:1:
      [72] is too short

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 8fded83c519ad..c9384ed685b8f 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -363,7 +363,7 @@ examples:
         keep-power-in-suspend;
         wakeup-source;
         mmc-pwrseq = <&sdhci0_pwrseq>;
-        clk-phase-sd-hs = <63>, <72>;
+        clk-phase-sd-hs = <63 72>;
     };
 
   - |
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 18/28] dt-bindings: mmc: Fix node name in an example
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (9 preceding siblings ...)
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-26 14:28   ` Ulf Hansson
  2020-03-17  9:39 ` [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema Lubomir Rintel
                   ` (8 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

The $nodename allows only "mmc@*" whereas the example node is named
"sdhci".

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index c9384ed685b8f..c03fe268c29a0 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -351,7 +351,7 @@ dependencies:
 
 examples:
   - |
-    sdhci@ab000000 {
+    mmc@ab000000 {
         compatible = "sdhci";
         reg = <0xab000000 0x200>;
         interrupts = <23>;
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (10 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 18/28] dt-bindings: mmc: Fix node name in an example Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-18 22:14   ` Rob Herring
  2020-03-18 22:37   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio " Lubomir Rintel
                   ` (7 subsequent siblings)
  19 siblings, 2 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

Convert the sdhci-pxa binding to DT schema format using json-schema.

At the same time, fix a couple of issues with the examples discovered by
the validation tool -- a semicolon instead of a comma and wrong node names.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../devicetree/bindings/mmc/sdhci-pxa.txt     |  50 ---------
 .../devicetree/bindings/mmc/sdhci-pxa.yaml    | 101 ++++++++++++++++++
 2 files changed, 101 insertions(+), 50 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
deleted file mode 100644
index 3d1b449d6097d..0000000000000
--- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
+++ /dev/null
@@ -1,50 +0,0 @@
-* Marvell sdhci-pxa v2/v3 controller
-
-This file documents differences between the core properties in mmc.txt
-and the properties used by the sdhci-pxav2 and sdhci-pxav3 drivers.
-
-Required properties:
-- compatible: Should be "mrvl,pxav2-mmc", "mrvl,pxav3-mmc" or
-  "marvell,armada-380-sdhci".
-- reg:
-  * for "mrvl,pxav2-mmc" and "mrvl,pxav3-mmc", one register area for
-    the SDHCI registers.
-
-  * for "marvell,armada-380-sdhci", three register areas. The first
-    one for the SDHCI registers themselves, the second one for the
-    AXI/Mbus bridge registers of the SDHCI unit, the third one for the
-    SDIO3 Configuration register
-- reg names: should be "sdhci", "mbus", "conf-sdio3". only mandatory
-  for "marvell,armada-380-sdhci"
-- clocks: Array of clocks required for SDHCI; requires at least one for
-    I/O clock.
-- clock-names: Array of names corresponding to clocks property; shall be
-    "io" for I/O clock and "core" for optional core clock.
-
-Optional properties:
-- mrvl,clk-delay-cycles: Specify a number of cycles to delay for tuning.
-
-Example:
-
-sdhci@d4280800 {
-	compatible = "mrvl,pxav3-mmc";
-	reg = <0xd4280800 0x800>;
-	bus-width = <8>;
-	interrupts = <27>;
-	clocks = <&chip CLKID_SDIO1XIN>, <&chip CLKID_SDIO1>;
-	clock-names = "io", "core";
-	non-removable;
-	mrvl,clk-delay-cycles = <31>;
-};
-
-sdhci@d8000 {
-	compatible = "marvell,armada-380-sdhci";
-	reg-names = "sdhci", "mbus", "conf-sdio3";
-	reg = <0xd8000 0x1000>,
-		<0xdc000 0x100>;
-		<0x18454 0x4>;
-	interrupts = <0 25 0x4>;
-	clocks = <&gateclk 17>;
-	clock-names = "io";
-	mrvl,clk-delay-cycles = <0x1F>;
-};
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
new file mode 100644
index 0000000000000..4ae0926ac294f
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
@@ -0,0 +1,101 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell PXA SDHCI v2/v3 bindings
+
+maintainers:
+  - devicetree@vger.kernel.org
+
+allOf:
+  - $ref: mmc-controller.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: marvell,armada-380-sdhci
+    then:
+      properties:
+        regs:
+          minItems: 3
+          maxItems: 3
+        reg-names:
+          items:
+            - const: sdhci
+            - const: mbus
+            - const: conf-sdio3
+      required:
+        - reg-names
+    else:
+      properties:
+        regs:
+          minItems: 1
+          maxItems: 1
+        reg-names:
+          minItems: 1
+          maxItems: 1
+
+properties:
+  compatible:
+    enum:
+      - mrvl,pxav2-mmc
+      - mrvl,pxav3-mmc
+      - marvell,armada-380-sdhci
+
+  reg: true
+
+  reg-names: true
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 1
+    maxItems: 2
+
+  clock-names:
+    minItems: 1
+    maxItems: 2
+    items:
+      - const: io
+      - const: core
+
+  mrvl,clk-delay-cycles:
+    description: Specify a number of cycles to delay for tuning.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+examples:
+  - |
+    #include <dt-bindings/clock/berlin2.h>
+    mmc@d4280800 {
+        compatible = "mrvl,pxav3-mmc";
+        reg = <0xd4280800 0x800>;
+        bus-width = <8>;
+        interrupts = <27>;
+        clocks = <&chip CLKID_SDIO1XIN>, <&chip CLKID_SDIO1>;
+        clock-names = "io", "core";
+        non-removable;
+        mrvl,clk-delay-cycles = <31>;
+    };
+  - |
+    mmc@d8000 {
+        compatible = "marvell,armada-380-sdhci";
+        reg-names = "sdhci", "mbus", "conf-sdio3";
+        reg = <0xd8000 0x1000>,
+              <0xdc000 0x100>,
+              <0x18454 0x4>;
+        interrupts = <0 25 0x4>;
+        clocks = <&gateclk 17>;
+        clock-names = "io";
+        mrvl,clk-delay-cycles = <0x1F>;
+    };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (7 preceding siblings ...)
  2020-03-17  9:39   ` [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example Lubomir Rintel
@ 2020-03-17  9:39   ` Lubomir Rintel
  2020-03-27 19:09     ` Rob Herring
  2020-03-17  9:39   ` [PATCH 22/28] dt-bindings: i2c: Convert i2c-pxa " Lubomir Rintel
  2020-03-17 13:19   ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Mark Brown
  10 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

A rather straightforward conversion of the phy-mmp3-usb binding to DT
schema format using json-schema.

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 .../bindings/phy/marvell,mmp3-usb-phy.yaml    | 40 +++++++++++++++++++
 .../devicetree/bindings/phy/phy-mmp3-usb.txt  | 13 ------
 2 files changed, 40 insertions(+), 13 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-usb-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/phy/phy-mmp3-usb.txt

diff --git a/Documentation/devicetree/bindings/phy/marvell,mmp3-usb-phy.yaml b/Documentation/devicetree/bindings/phy/marvell,mmp3-usb-phy.yaml
new file mode 100644
index 0000000000000..1307703d9b627
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/marvell,mmp3-usb-phy.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
+# Copyright 2019,2020 Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/marvell,mmp3-usb-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell MMP3 USB PHY bindings
+
+maintainers:
+  - Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
+
+properties:
+  $nodename:
+    pattern: '^usb-phy@[a-f0-9]+$'
+
+  compatible:
+    const: marvell,mmp3-usb-phy
+
+  reg:
+    maxItems: 1
+    description: base address of the device
+
+  '#phy-cells':
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - '#phy-cells'
+
+examples:
+  - |
+    usb-phy@d4207000 {
+      compatible = "marvell,mmp3-usb-phy";
+      reg = <0xd4207000 0x40>;
+      #phy-cells = <0>;
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/phy/phy-mmp3-usb.txt b/Documentation/devicetree/bindings/phy/phy-mmp3-usb.txt
deleted file mode 100644
index 7183b9102f917..0000000000000
--- a/Documentation/devicetree/bindings/phy/phy-mmp3-usb.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-Marvell MMP3 USB PHY
---------------------
-
-Required properties:
-- compatible: must be "marvell,mmp3-usb-phy"
-- #phy-cells: must be 0
-
-Example:
-	usb-phy: usb-phy@d4207000 {
-		compatible = "marvell,mmp3-usb-phy";
-		reg = <0xd4207000 0x40>;
-		#phy-cells = <0>;
-	};
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (11 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 10:04   ` Linus Walleij
  2020-03-27 19:28   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc " Lubomir Rintel
                   ` (6 subsequent siblings)
  19 siblings, 2 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

This converts the mrvl-gpio binding to DT schema format using json-schema.

Various fixes were done during the conversion, such as adding more
properties that are in fact mandatory or extending the examples to
include child nodes with extra GPIO blocks.

The compatible strings are a mess. It is not clear why so many of them
are needed; the driver doesn't really seem to differentiate between the
models. Some of them, like marvell,pxa93x-gpio and marvell,pxa1928-gpio
are not used at all, so it's not known how many interrupts they utilize.
On the other hand, mrvl,pxa-gpio has been seen in the tree, but it
doesn't end up in any actual DTB file.

In any case -- the schema merely copies whatever was in the original
binding document, so it's hopefully no more wrong that the original.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../devicetree/bindings/gpio/mrvl-gpio.txt    |  48 -----
 .../devicetree/bindings/gpio/mrvl-gpio.yaml   | 173 ++++++++++++++++++
 2 files changed, 173 insertions(+), 48 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
 create mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml

diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt b/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
deleted file mode 100644
index 30fd2201b3d4c..0000000000000
--- a/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
+++ /dev/null
@@ -1,48 +0,0 @@
-* Marvell PXA GPIO controller
-
-Required properties:
-- compatible : Should be "intel,pxa25x-gpio", "intel,pxa26x-gpio",
-		"intel,pxa27x-gpio", "intel,pxa3xx-gpio",
-		"marvell,pxa93x-gpio", "marvell,mmp-gpio",
-		"marvell,mmp2-gpio" or marvell,pxa1928-gpio.
-- reg : Address and length of the register set for the device
-- interrupts : Should be the port interrupt shared by all gpio pins.
-  There're three gpio interrupts in arch-pxa, and they're gpio0,
-  gpio1 and gpio_mux. There're only one gpio interrupt in arch-mmp,
-  gpio_mux.
-- interrupt-names : Should be the names of irq resources. Each interrupt
-  uses its own interrupt name, so there should be as many interrupt names
-  as referenced interrupts.
-- interrupt-controller : Identifies the node as an interrupt controller.
-- #interrupt-cells: Specifies the number of cells needed to encode an
-  interrupt source.
-- gpio-controller : Marks the device node as a gpio controller.
-- #gpio-cells : Should be two.  The first cell is the pin number and
-  the second cell is used to specify flags. See gpio.txt for possible
-  values.
-
-Example for a MMP platform:
-
-	gpio: gpio@d4019000 {
-		compatible = "marvell,mmp-gpio";
-		reg = <0xd4019000 0x1000>;
-		interrupts = <49>;
-		interrupt-names = "gpio_mux";
-		gpio-controller;
-		#gpio-cells = <2>;
-		interrupt-controller;
-		#interrupt-cells = <1>;
-      };
-
-Example for a PXA3xx platform:
-
-	gpio: gpio@40e00000 {
-		compatible = "intel,pxa3xx-gpio";
-		reg = <0x40e00000 0x10000>;
-		interrupt-names = "gpio0", "gpio1", "gpio_mux";
-		interrupts = <8 9 10>;
-		gpio-controller;
-		#gpio-cells = <0x2>;
-		interrupt-controller;
-		#interrupt-cells = <0x2>;
-	};
diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
new file mode 100644
index 0000000000000..5c713bf59b06d
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
@@ -0,0 +1,173 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/mrvl-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell PXA GPIO controller
+
+maintainers:
+  - devicetree@vger.kernel.org
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - intel,pxa25x-gpio
+              - intel,pxa26x-gpio
+              - intel,pxa27x-gpio
+              - intel,pxa3xx-gpio
+    then:
+      properties:
+        interrupts:
+          minItems: 3
+          maxItems: 3
+        interrupt-names:
+          items:
+            - const: gpio0
+            - const: gpio1
+            - const: gpio_mux
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - marvell,mmp-gpio
+              - marvell,mmp2-gpio
+    then:
+      properties:
+        interrupts:
+          maxItems: 1
+        interrupt-names:
+          items:
+            - const: gpio_mux
+
+properties:
+  $nodename:
+    pattern: '^gpio@[0-9a-f]+$'
+
+  compatible:
+    enum:
+      - intel,pxa25x-gpio
+      - intel,pxa26x-gpio
+      - intel,pxa27x-gpio
+      - intel,pxa3xx-gpio
+      - marvell,mmp-gpio
+      - marvell,mmp2-gpio
+      - marvell,pxa93x-gpio
+      - marvell,pxa1928-gpio
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  ranges: true
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    const: 2
+
+  gpio-ranges:
+    maxItems: 1
+
+  interrupts: true
+
+  interrupt-names: true
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    const: 2
+
+patternProperties:
+  '^gpio@[0-9a-f]*$':
+    type: object
+    properties:
+      reg:
+        maxItems: 1
+
+    required:
+      - reg
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - '#address-cells'
+  - '#size-cells'
+  - reg
+  - gpio-controller
+  - '#gpio-cells'
+  - interrupts
+  - interrupt-names
+  - interrupt-controller
+  - '#interrupt-cells'
+  - ranges
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/pxa-clock.h>
+    gpio@40e00000 {
+        compatible = "intel,pxa3xx-gpio";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0x40e00000 0x10000>;
+        gpio-controller;
+        #gpio-cells = <2>;
+        interrupts = <8>, <9>, <10>;
+        interrupt-names = "gpio0", "gpio1", "gpio_mux";
+        clocks = <&clks CLK_GPIO>;
+        interrupt-controller;
+        #interrupt-cells = <2>;
+        ranges;
+    };
+  - |
+    #include <dt-bindings/clock/marvell,pxa910.h>
+    gpio@d4019000 {
+        compatible = "marvell,mmp-gpio";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0xd4019000 0x1000>;
+        gpio-controller;
+        #gpio-cells = <2>;
+        interrupts = <49>;
+        interrupt-names = "gpio_mux";
+        clocks = <&soc_clocks PXA910_CLK_GPIO>;
+        resets = <&soc_clocks PXA910_CLK_GPIO>;
+        interrupt-controller;
+        #interrupt-cells = <2>;
+        ranges;
+
+        gpio@d4019000 {
+            reg = <0xd4019000 0x4>;
+        };
+
+        gpio@d4019004 {
+            reg = <0xd4019004 0x4>;
+        };
+
+        gpio@d4019008 {
+            reg = <0xd4019008 0x4>;
+        };
+
+        gpio@d4019100 {
+            reg = <0xd4019100 0x4>;
+        };
+     };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 22/28] dt-bindings: i2c: Convert i2c-pxa to json-schema
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (8 preceding siblings ...)
  2020-03-17  9:39   ` [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema Lubomir Rintel
@ 2020-03-17  9:39   ` Lubomir Rintel
  2020-03-17 13:19   ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Mark Brown
  10 siblings, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

A conversion of the i2c-pxa binding to DT schema format using json-schema.

This also cleans ups some errors in the binding: The compatible string
description suggested that "mmp" in "mrvl,mmp-twsi" is to be substituted
with a processor model, which wouldn't be a right thing to do and indeed
nobody seems to have been doing that. There also was "Recommended
properties" section that included optional as well as mandatory
properties. Missing mandatory properties were added to the example.

Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
---
 .../devicetree/bindings/i2c/i2c-pxa.txt       | 31 --------
 .../devicetree/bindings/i2c/i2c-pxa.yaml      | 71 +++++++++++++++++++
 2 files changed, 71 insertions(+), 31 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-pxa.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-pxa.yaml

diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b/Documentation/devicetree/bindings/i2c/i2c-pxa.txt
deleted file mode 100644
index c30783c0eca03..0000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt
+++ /dev/null
@@ -1,31 +0,0 @@
-* Marvell MMP I2C controller
-
-Required properties :
-
- - reg : Offset and length of the register set for the device
- - compatible : should be "mrvl,mmp-twsi" where mmp is the name of a
-   compatible processor, e.g. pxa168, pxa910, mmp2, mmp3.
-   For the pxa2xx/pxa3xx, an additional node "mrvl,pxa-i2c" is required
-   as shown in the example below.
-   For the Armada 3700, the compatible should be "marvell,armada-3700-i2c".
-
-Recommended properties :
-
- - interrupts : the interrupt number
- - mrvl,i2c-polling : Disable interrupt of i2c controller. Polling
-   status register of i2c controller instead.
- - mrvl,i2c-fast-mode : Enable fast mode of i2c controller.
-
-Examples:
-	twsi1: i2c@d4011000 {
-		compatible = "mrvl,mmp-twsi";
-		reg = <0xd4011000 0x1000>;
-		interrupts = <7>;
-		mrvl,i2c-fast-mode;
-	};
-	
-	twsi2: i2c@d4025000 {
-		compatible = "mrvl,mmp-twsi";
-		reg = <0xd4025000 0x1000>;
-		interrupts = <58>;
-	};
diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.yaml b/Documentation/devicetree/bindings/i2c/i2c-pxa.yaml
new file mode 100644
index 0000000000000..c04fb81927208
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-pxa.yaml
@@ -0,0 +1,71 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-pxa.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell MMP I2C controller bindings
+
+maintainers:
+  - devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
+
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+  - if:
+      not:
+        required:
+          - mrvl,i2c-polling
+    then:
+        required:
+          - interrupts
+
+properties:
+  compatible:
+    enum:
+      - mrvl,mmp-twsi
+      - mrvl,pxa-i2c
+      - marvell,armada-3700-i2c
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 1
+
+  resets:
+    minItems: 1
+
+  mrvl,i2c-polling:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description: |
+      Disable interrupt of i2c controller. Polling status register of i2c
+      controller instead.
+
+  mrvl,i2c-fast-mode:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description: Enable fast mode of i2c controller.
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - '#address-cells'
+  - '#size-cells'
+
+examples:
+  - |
+    #include <dt-bindings/clock/marvell,mmp2.h>
+    i2c@d4011000 {
+        compatible = "mrvl,mmp-twsi";
+        reg = <0xd4011000 0x1000>;
+        interrupts = <7>;
+        clocks = <&soc_clocks MMP2_CLK_TWSI1>;
+        mrvl,i2c-fast-mode;
+        #address-cells = <1>;
+        #size-cells = <0>;
+    };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (12 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio " Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:42   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic " Lubomir Rintel
                   ` (5 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

Convert the mrvl,intc binding to DT schema format using json-schema.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../interrupt-controller/mrvl,intc.txt        |  64 --------
 .../interrupt-controller/mrvl,intc.yaml       | 144 ++++++++++++++++++
 2 files changed, 144 insertions(+), 64 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
 create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml

diff --git a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
deleted file mode 100644
index a0ed02725a9d7..0000000000000
--- a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
+++ /dev/null
@@ -1,64 +0,0 @@
-* Marvell MMP Interrupt controller
-
-Required properties:
-- compatible : Should be
-               "mrvl,mmp-intc" on Marvel MMP,
-               "mrvl,mmp2-intc" along with "mrvl,mmp2-mux-intc" on MMP2 or
-               "marvell,mmp3-intc" with "mrvl,mmp2-mux-intc" on MMP3
-- reg : Address and length of the register set of the interrupt controller.
-  If the interrupt controller is intc, address and length means the range
-  of the whole interrupt controller. The "marvell,mmp3-intc" controller
-  also has a secondary range for the second CPU core.  If the interrupt
-  controller is mux-intc, address and length means one register. Since
-  address of mux-intc is in the range of intc. mux-intc is secondary
-  interrupt controller.
-- reg-names : Name of the register set of the interrupt controller. It's
-  only required in mux-intc interrupt controller.
-- interrupts : Should be the port interrupt shared by mux interrupts. It's
-  only required in mux-intc interrupt controller.
-- interrupt-controller : Identifies the node as an interrupt controller.
-- #interrupt-cells : Specifies the number of cells needed to encode an
-  interrupt source.
-- mrvl,intc-nr-irqs : Specifies the number of interrupts in the interrupt
-  controller.
-- mrvl,clr-mfp-irq : Specifies the interrupt that needs to clear MFP edge
-  detection first.
-
-Example:
-	intc: interrupt-controller@d4282000 {
-		compatible = "mrvl,mmp2-intc";
-		interrupt-controller;
-		#interrupt-cells = <1>;
-		reg = <0xd4282000 0x1000>;
-		mrvl,intc-nr-irqs = <64>;
-	};
-
-	intcmux4@d4282150 {
-		compatible = "mrvl,mmp2-mux-intc";
-		interrupts = <4>;
-		interrupt-controller;
-		#interrupt-cells = <1>;
-		reg = <0x150 0x4>, <0x168 0x4>;
-		reg-names = "mux status", "mux mask";
-		mrvl,intc-nr-irqs = <2>;
-	};
-
-* Marvell Orion Interrupt controller
-
-Required properties
-- compatible :  Should be "marvell,orion-intc".
-- #interrupt-cells: Specifies the number of cells needed to encode an
-  interrupt source. Supported value is <1>.
-- interrupt-controller : Declare this node to be an interrupt controller.
-- reg : Interrupt mask address. A list of 4 byte ranges, one per controller.
-        One entry in the list represents 32 interrupts.
-
-Example:
-
-	intc: interrupt-controller {
-        	compatible = "marvell,orion-intc", "marvell,intc";
-		interrupt-controller;
-		#interrupt-cells = <1>;
-                reg = <0xfed20204 0x04>,
-		      <0xfed20214 0x04>;
-        };
diff --git a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
new file mode 100644
index 0000000000000..f0644f7d7e1d2
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
@@ -0,0 +1,144 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/interrupt-controller/mrvl,intc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell MMP/Orion Interrupt controller bindings
+
+maintainers:
+  - devicetree@vger.kernel.org
+
+allOf:
+  - $ref: /schemas/interrupt-controller.yaml#
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              const: marvell,orion-intc
+    then:
+      required:
+        - mrvl,intc-nr-irqs
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - mrvl,mmp-intc
+              - mrvl,mmp2-intc
+    then:
+      properties:
+        reg:
+          minItems: 1
+          maxItems: 1
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - marvell,mmp3-intc
+              - mrvl,mmp2-mux-intc
+    then:
+      properties:
+        reg:
+          minItems: 2
+          maxItems: 2
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: marvell,orion-intc
+    then:
+      properties:
+        reg:
+          minItems: 1
+          maxItems: 2
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: mrvl,mmp2-mux-intc
+    then:
+      properties:
+        interrupts:
+          minItems: 1
+          maxItems: 1
+        reg-names:
+          minItems: 2
+          maxItems: 2
+          items:
+            - const: 'mux status'
+            - const: 'mux mask'
+      required:
+        - interrupts
+    else:
+      properties:
+        interrupts: false
+
+properties:
+  '#interrupt-cells':
+    const: 1
+
+  compatible:
+    enum:
+      - mrvl,mmp-intc
+      - mrvl,mmp2-intc
+      - marvell,mmp3-intc
+      - marvell,orion-intc
+      - mrvl,mmp2-mux-intc
+
+  reg: true
+
+  reg-names: true
+
+  interrupts: true
+
+  interrupt-controller: true
+
+  mrvl,intc-nr-irqs:
+    description: |
+      Specifies the number of interrupts in the interrupt controller.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  mrvl,clr-mfp-irq:
+    description: |
+      Specifies the interrupt that needs to clear MFP edge detection first.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+  - '#interrupt-cells'
+  - compatible
+  - reg
+  - interrupt-controller
+
+additionalProperties: false
+
+examples:
+  - |
+    interrupt-controller@d4282000 {
+        compatible = "mrvl,mmp2-intc";
+        interrupt-controller;
+        #interrupt-cells = <1>;
+        reg = <0xd4282000 0x1000>;
+        mrvl,intc-nr-irqs = <64>;
+    };
+
+    interrupt-controller@d4282150 {
+        compatible = "mrvl,mmp2-mux-intc";
+        interrupts = <4>;
+        interrupt-controller;
+        #interrupt-cells = <1>;
+        reg = <0x150 0x4>, <0x168 0x4>;
+        reg-names = "mux status", "mux mask";
+        mrvl,intc-nr-irqs = <2>;
+    };
+  - |
+    interrupt-controller@fed20204 {
+        compatible = "marvell,orion-intc";
+        interrupt-controller;
+        #interrupt-cells = <1>;
+        reg = <0xfed20204 0x04>,
+              <0xfed20214 0x04>;
+    };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (13 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc " Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:46   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc " Lubomir Rintel
                   ` (4 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

Convert the marvell,mmp2-ccic binding to DT schema format using
json-schema.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../bindings/media/marvell,mmp2-ccic.txt      |  50 ---------
 .../bindings/media/marvell,mmp2-ccic.yaml     | 102 ++++++++++++++++++
 2 files changed, 102 insertions(+), 50 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
 create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml

diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
deleted file mode 100644
index 7ec2c8c8a3b98..0000000000000
--- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
+++ /dev/null
@@ -1,50 +0,0 @@
-Marvell MMP2 camera host interface
-
-Required properties:
- - compatible: Should be "marvell,mmp2-ccic".
- - reg: Register base and size.
- - interrupts: The interrupt number.
- - #clock-cells: Must be 0.
-
-Optional properties:
- - clocks: Reference to the input clock as specified by
-           Documentation/devicetree/bindings/clock/clock-bindings.txt.
- - clock-names: Names of the clocks used; "axi" for the AXI bus interface,
-                "func" for the peripheral clock and "phy" for the parallel
-                video bus interface.
- - clock-output-names: Optional clock source for sensors. Shall be "mclk".
-
-Required subnodes:
- - port: The parallel bus interface port with a single endpoint linked to
-         the sensor's endpoint as described in
-         Documentation/devicetree/bindings/media/video-interfaces.txt.
-
-Required endpoint properties:
- - bus-type: data bus type, <5> or <6> for Parallel or Bt.656 respectively
- - pclk-sample: pixel clock polarity
- - hsync-active: horizontal synchronization polarity (only required for
-   parallel bus)
- - vsync-active: vertical synchronization polarity (only required for
-   parallel bus)
-
-Example:
-
-	camera0: camera@d420a000 {
-		compatible = "marvell,mmp2-ccic";
-		reg = <0xd420a000 0x800>;
-		interrupts = <42>;
-		clocks = <&soc_clocks MMP2_CLK_CCIC0>;
-		clock-names = "axi";
-		#clock-cells = <0>;
-		clock-output-names = "mclk";
-
-		port {
-			camera0_0: endpoint {
-				remote-endpoint = <&ov7670_0>;
-                                bus-type = <5>;      /* Parallel */
-                                hsync-active = <1>;  /* Active high */
-                                vsync-active = <1>;  /* Active high */
-                                pclk-sample = <0>;   /* Falling */
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
new file mode 100644
index 0000000000000..890a3f9d0302f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
@@ -0,0 +1,102 @@
+# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
+# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/marvell,mmp2-ccic.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell MMP2 camera host interface bindings
+
+maintainers:
+  - Lubomir Rintel <lkundrak@v3.sk>
+
+properties:
+  $nodename:
+    pattern: '^camera@[a-f0-9]+$'
+
+  compatible:
+    const: marvell,mmp2-ccic
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  port:
+    type: object
+    additionalProperties: false
+
+    properties:
+       endpoint:
+         type: object
+         additionalProperties: false
+
+         # Properties described in
+         # Documentation/devicetree/bindings/media/video-interfaces.txt
+         properties:
+           remote-endpoint: true
+           hsync-active: true
+           vsync-active: true
+           pclk-sample: true
+           bus-type: true
+
+         required:
+           - remote-endpoint
+
+    required:
+      - endpoint
+
+  clocks:
+    minItems: 1
+    maxItems: 3
+    items:
+      - description: AXI bus interface clock
+      - description: Peripheral clock
+      - description: Parallel video bus interface clock
+
+  clock-names:
+    minItems: 1
+    maxItems: 3
+    items:
+      - const: axi
+      - const: func
+      - const: phy
+
+  '#clock-cells':
+    const: 0
+
+  clock-output-names:
+    const: mclk
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - port
+
+examples:
+  - |
+    #include <dt-bindings/clock/marvell,mmp2.h>
+
+    camera@d420a000 {
+      compatible = "marvell,mmp2-ccic";
+      reg = <0xd420a000 0x800>;
+      interrupts = <42>;
+      clocks = <&soc_clocks MMP2_CLK_CCIC0>;
+      clock-names = "axi";
+      #clock-cells = <0>;
+      clock-output-names = "mclk";
+
+      port {
+        camera0_0: endpoint {
+          remote-endpoint = <&ov7670_0>;
+          bus-type = <5>;      /* Parallel */
+          hsync-active = <1>;  /* Active high */
+          vsync-active = <1>;  /* Active high */
+          pclk-sample = <0>;   /* Falling */
+        };
+      };
+    };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (14 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic " Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:49   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx " Lubomir Rintel
                   ` (3 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

Convert the sa1100-rtc binding to DT schema format using json-schema.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../devicetree/bindings/rtc/sa1100-rtc.txt    | 17 ------
 .../devicetree/bindings/rtc/sa1100-rtc.yaml   | 55 +++++++++++++++++++
 2 files changed, 55 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml

diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt b/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
deleted file mode 100644
index 968ac820254bb..0000000000000
--- a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-* Marvell Real Time Clock controller
-
-Required properties:
-- compatible: should be "mrvl,sa1100-rtc"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- interrupts: Should be two. The first interrupt number is the rtc alarm
-  interrupt and the second interrupt number is the rtc hz interrupt.
-- interrupt-names: Assign name of irq resource.
-
-Example:
-	rtc: rtc@d4010000 {
-		compatible = "mrvl,mmp-rtc";
-		reg = <0xd4010000 0x1000>;
-		interrupts = <5>, <6>;
-		interrupt-names = "rtc 1Hz", "rtc alarm";
-	};
diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
new file mode 100644
index 0000000000000..53a8b72df9f34
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
@@ -0,0 +1,55 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/sa1100-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell Real Time Clock controller bindings
+
+allOf:
+  - $ref: rtc.yaml#
+
+maintainers:
+  - devicetree@vger.kernel.org
+
+properties:
+  compatible:
+    enum:
+      - mrvl,sa1100-rtc
+      - mrvl,mmp-rtc
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  interrupts:
+    minItems: 2
+    maxItems: 2
+
+  interrupt-names:
+    items:
+      - const: 'rtc 1Hz'
+      - const: 'rtc alarm'
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+
+additionalProperties: false
+
+examples:
+  - |
+    rtc: rtc@d4010000 {
+        compatible = "mrvl,mmp-rtc";
+        reg = <0xd4010000 0x1000>;
+        interrupts = <5>, <6>;
+        interrupt-names = "rtc 1Hz", "rtc alarm";
+    };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (15 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc " Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:52   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer " Lubomir Rintel
                   ` (2 subsequent siblings)
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

A straightforward conversion of the the spi-pxa2xx binding to DT schema
format using json-schema.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../bindings/spi/marvell,mmp2-ssp.yaml        | 58 +++++++++++++++++++
 .../devicetree/bindings/spi/spi-pxa2xx.txt    | 27 ---------
 2 files changed, 58 insertions(+), 27 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
 delete mode 100644 Documentation/devicetree/bindings/spi/spi-pxa2xx.txt

diff --git a/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
new file mode 100644
index 0000000000000..de6b6a53b70d8
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
+# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/marvell,mmp2-ssp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PXA2xx SSP SPI Controller bindings
+
+maintainers:
+  - Lubomir Rintel <lkundrak@v3.sk>
+
+allOf:
+  - $ref: spi-controller.yaml#
+
+properties:
+  compatible:
+    const: marvell,mmp2-ssp
+
+  interrupts:
+    maxItems: 1
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  ready-gpios:
+    description: |
+      GPIO used to signal a SPI master that the FIFO is filled and we're
+      ready to service a transfer. Only useful in slave mode.
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - '#address-cells'
+  - '#size-cells'
+
+dependencies:
+  ready-gpios: [ spi-slave ]
+
+examples:
+  - |
+    #include <dt-bindings/clock/marvell,mmp2.h>
+    spi@d4035000 {
+        compatible = "marvell,mmp2-ssp";
+        #address-cells = <1>;
+        #size-cells = <0>;
+        reg = <0xd4035000 0x1000>;
+        clocks = <&soc_clocks MMP2_CLK_SSP0>;
+        interrupts = <0>;
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
deleted file mode 100644
index e30e0c2a4bce1..0000000000000
--- a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-PXA2xx SSP SPI Controller
-
-Required properties:
-- compatible: Must be "marvell,mmp2-ssp".
-- reg: Offset and length of the device's register set.
-- interrupts: Should be the interrupt number.
-- clocks: Should contain a single entry describing the clock input.
-- #address-cells:  Number of cells required to define a chip select address.
-- #size-cells: Should be zero.
-
-Optional properties:
-- cs-gpios: list of GPIO chip selects. See the SPI bus bindings,
-  Documentation/devicetree/bindings/spi/spi-bus.txt
-- spi-slave: Empty property indicating the SPI controller is used in slave mode.
-- ready-gpios: GPIO used to signal a SPI master that the FIFO is filled
-  and we're ready to service a transfer. Only useful in slave mode.
-
-Child nodes represent devices on the SPI bus
-  See ../spi/spi-bus.txt
-
-Example:
-	ssp1: spi@d4035000 {
-		compatible = "marvell,mmp2-ssp";
-		reg = <0xd4035000 0x1000>;
-		clocks = <&soc_clocks MMP2_CLK_SSP0>;
-		interrupts = <0>;
-	};
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (16 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx " Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:53   ` Rob Herring
  2020-03-17  9:39 ` [PATCH 28/28] dt-bindings: usb: Convert ehci-mv " Lubomir Rintel
  2020-03-17 13:46 ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Andrew Lunn
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

A straightforward conversion of the mrvl,mmp-timer binding to DT schema
format using json-schema.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../bindings/timer/mrvl,mmp-timer.txt         | 17 --------
 .../bindings/timer/mrvl,mmp-timer.yaml        | 43 +++++++++++++++++++
 2 files changed, 43 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
 create mode 100644 Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml

diff --git a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
deleted file mode 100644
index b8f02c6635219..0000000000000
--- a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-* Marvell MMP Timer controller
-
-Required properties:
-- compatible : Should be "mrvl,mmp-timer".
-- reg : Address and length of the register set of timer controller.
-- interrupts : Should be the interrupt number.
-
-Optional properties:
-- clocks : Should contain a single entry describing the clock input.
-
-Example:
-	timer0: timer@d4014000 {
-		compatible = "mrvl,mmp-timer";
-		reg = <0xd4014000 0x100>;
-		interrupts = <13>;
-		clocks = <&coreclk 2>;
-	};
diff --git a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml
new file mode 100644
index 0000000000000..ebee0b862d493
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml
@@ -0,0 +1,43 @@
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/mrvl,mmp-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell MMP Timer bindings
+
+maintainers:
+  - devicetree@vger.kernel.org
+
+properties:
+  $nodename:
+    pattern: '^timer@[a-f0-9]+$'
+
+  compatible:
+    const: mrvl,mmp-timer
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    timer@d4014000 {
+        compatible = "mrvl,mmp-timer";
+        reg = <0xd4014000 0x100>;
+        interrupts = <13>;
+        clocks = <&coreclk 2>;
+    };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (17 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer " Lubomir Rintel
@ 2020-03-17  9:39 ` Lubomir Rintel
  2020-03-27 19:55   ` Rob Herring
  2020-03-17 13:46 ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Andrew Lunn
  19 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17  9:39 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

A straightforward conversion of the ehci-mv binding to DT schema format
using json-schema.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 .../devicetree/bindings/usb/ehci-mv.txt       | 23 -------
 .../bindings/usb/marvell,pxau2o-ehci.yaml     | 60 +++++++++++++++++++
 2 files changed, 60 insertions(+), 23 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/usb/ehci-mv.txt
 create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml

diff --git a/Documentation/devicetree/bindings/usb/ehci-mv.txt b/Documentation/devicetree/bindings/usb/ehci-mv.txt
deleted file mode 100644
index 335589895763e..0000000000000
--- a/Documentation/devicetree/bindings/usb/ehci-mv.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-* Marvell PXA/MMP EHCI controller.
-
-Required properties:
-
-- compatible: must be "marvell,pxau2o-ehci"
-- reg: physical base addresses of the controller and length of memory mapped region
-- interrupts: one EHCI controller interrupt should be described here
-- clocks: phandle list of usb clocks
-- clock-names: should be "USBCLK"
-- phys: phandle for the PHY device
-- phy-names: should be "usb"
-
-Example:
-
-	ehci0: usb-ehci@d4208000 {
-		compatible = "marvell,pxau2o-ehci";
-		reg = <0xd4208000 0x200>;
-		interrupts = <44>;
-		clocks = <&soc_clocks MMP2_CLK_USB>;
-		clock-names = "USBCLK";
-		phys = <&usb_otg_phy>;
-		phy-names = "usb";
-	};
diff --git a/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
new file mode 100644
index 0000000000000..189025ef1e92e
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
+# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/marvell,pxau2o-ehci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Marvell PXA/MMP EHCI bindings
+
+maintainers:
+  - Lubomir Rintel <lkundrak@v3.sk>
+
+allOf:
+  - $ref: usb-hcd.yaml#
+
+properties:
+  compatible:
+    const: marvell,pxau2o-ehci
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: USBCLK
+
+  phys:
+    maxItems: 1
+
+  phy-names:
+    const: usb
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - phys
+  - phy-names
+
+examples:
+  - |
+    #include <dt-bindings/clock/marvell,mmp2.h>
+    usb@d4208000 {
+        compatible = "marvell,pxau2o-ehci";
+        reg = <0xd4208000 0x200>;
+        interrupts = <44>;
+        clocks = <&soc_clocks MMP2_CLK_USB>;
+        clock-names = "USBCLK";
+        phys = <&usb_otg_phy>;
+        phy-names = "usb";
+    };
+
+...
-- 
2.25.1

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example
  2020-03-17  9:39   ` [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example Lubomir Rintel
@ 2020-03-17 10:04     ` Sergei Shtylyov
       [not found]     ` <20200317093922.20785-18-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  1 sibling, 0 replies; 81+ messages in thread
From: Sergei Shtylyov @ 2020-03-17 10:04 UTC (permalink / raw)
  To: Lubomir Rintel, Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

Hello!

On 17.03.2020 12:39, Lubomir Rintel wrote:

> This way the validator can know that the two cells constitute a singlej

    Single?

> pair of clock phase degrees value, not separate items Otherwise it is

    Forgot a period after "items"?

> unhappy:
> 
>    mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:0:
>        [63] is too short
>    mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:1:
>        [72] is too short
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 00/28] DT: Improve validation for Marvell SoCs
       [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
                     ` (9 preceding siblings ...)
  2020-03-17  9:39   ` [PATCH 22/28] dt-bindings: i2c: Convert i2c-pxa " Lubomir Rintel
@ 2020-03-17 13:19   ` Mark Brown
  10 siblings, 0 replies; 81+ messages in thread
From: Mark Brown @ 2020-03-17 13:19 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Daniel Lezcano, Andrew Lunn, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29Tb/PtFMR13I2A


[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

On Tue, Mar 17, 2020 at 10:38:54AM +0100, Lubomir Rintel wrote:

> None of the patches depends on any other and they can be applied in any
> order.

For future reference since this is a large set of mostly unrelated
changes it'd be as well to split it up via subsystem or something so
that the CC lists get reduced.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name
       [not found]   ` <20200317093922.20785-2-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-17 13:20     ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:20 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:38:55AM +0100, Lubomir Rintel wrote:
> The current ones makes validation unhappy:
> 
>   kirkwood-lsxhl.dt.yaml: main-interrupt-ctrl@20200: $nodename:0:
>     'main-interrupt-ctrl@20200' does not match
>     '^interrupt-controller(@[0-9a-f,]+)*$'
> 
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>

Reviewed-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name
  2020-03-17  9:38   ` [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name Lubomir Rintel
@ 2020-03-17 13:20     ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:20 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:38:56AM +0100, Lubomir Rintel wrote:
> The current ones makes validation unhappy:
> 
>   dove-d3plug.dt.yaml: main-interrupt-ctrl@20200: $nodename:0:
>       'main-interrupt-ctrl@20200' does not match
>       '^interrupt-controller(@[0-9a-f,]+)*$'
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 03/28] ARM: dts: pxa168: Add missing address/size cells to i2c nodes
       [not found]     ` <20200317093922.20785-4-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-17 13:21       ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:21 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:38:57AM +0100, Lubomir Rintel wrote:
> This makes the nodes compatible with the generic i2c binding without the
> board DTS files having to supply the necessary properties themselves.
> 
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>

Reviewed-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number
  2020-03-17  9:38   ` [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number Lubomir Rintel
@ 2020-03-17 13:27     ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:27 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:38:58AM +0100, Lubomir Rintel wrote:
> gpio-pxa uses two cell to encode the interrupt source: the pin number
> and the trigger type. Adjust the device node accordingly.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property
       [not found]     ` <20200317093922.20785-6-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-17 13:28       ` Andrew Lunn
  2020-03-21  7:36         ` Robert Jarzmik
  0 siblings, 1 reply; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:28 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:38:59AM +0100, Lubomir Rintel wrote:
> This way the device tree validator learns that each cell of the property
> constitutes a separate item. Otherwise it gets unnecessairly upset:
> 
>   pxa300-raumfeld-speaker-s.dt.yaml: gpio@40e00000: interrupts:
>       [[8, 9, 10]] is too short
> 
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>

Reviewed-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number
  2020-03-17  9:39   ` [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number Lubomir Rintel
@ 2020-03-17 13:29     ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:29 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:00AM +0100, Lubomir Rintel wrote:
> gpio-pxa uses two cell to encode the interrupt source: the pin number
> and the trigger type. Adjust the device node accordingly.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property
  2020-03-17  9:39   ` [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
@ 2020-03-17 13:29     ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:29 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:01AM +0100, Lubomir Rintel wrote:
> This way the device tree validator learns that each cell of the property
> constitutes a separate item. Otherwise it gets unnecessairly upset:
> 
>   pxa168-aspenite.dt.yaml: rtc@d4010000: interrupts: [[5, 6]] is too short
>   pxa910-dkb.dt.yaml: rtc@d4010000: interrupts: [[5, 6]] is too short
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts property
       [not found]   ` <20200317093922.20785-9-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-17 13:30     ` Andrew Lunn
  2020-03-17 13:30     ` Andrew Lunn
  1 sibling, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:30 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:02AM +0100, Lubomir Rintel wrote:
> This way the device tree validator learns that each cell of the property
> constitutes a separate item. Otherwise it gets unnecessairly upset:
> 
>   mmp3-dell-ariel.dt.yaml: rtc@d4010000: interrupts: [[1, 0]] is too short
> 
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>

Reviewed-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts property
       [not found]   ` <20200317093922.20785-9-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  2020-03-17 13:30     ` Andrew Lunn
@ 2020-03-17 13:30     ` Andrew Lunn
  1 sibling, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:30 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:02AM +0100, Lubomir Rintel wrote:
> This way the device tree validator learns that each cell of the property
> constitutes a separate item. Otherwise it gets unnecessairly upset:
> 
>   mmp3-dell-ariel.dt.yaml: rtc@d4010000: interrupts: [[1, 0]] is too short
> 
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>

Reviewed-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name
  2020-03-17  9:39   ` [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name Lubomir Rintel
@ 2020-03-17 13:31     ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:31 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:03AM +0100, Lubomir Rintel wrote:
> The current one makes validation unhappy:
> 
>   mmp3-dell-ariel.dt.yaml: l2-cache-controller@d0020000: $nodename:0:
>       'l2-cache-controller@d0020000' does not match
>       '^(cache-controller|cpu)(@[0-9a-f,]+)*$'
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names
  2020-03-17  9:39 ` [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names Lubomir Rintel
@ 2020-03-17 13:32   ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:32 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:04AM +0100, Lubomir Rintel wrote:
> There are better generic ones and the validation is going to complain:
> 
>   mmp3-dell-ariel.dt.yaml: hsic@f0001000: $nodename:0: 'hsic@f0001000'
>       does not match '^usb(@.*)?'
>   mmp3-dell-ariel.dt.yaml: hsic@f0002000: $nodename:0: 'hsic@f0002000'
>       does not match '^usb(@.*)?'
>   ...
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI node names
  2020-03-17  9:39 ` [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI " Lubomir Rintel
@ 2020-03-17 13:34   ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:34 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:05AM +0100, Lubomir Rintel wrote:
> The node name preferred by mmc-controller.yaml binding spec is "mmc":
> 
>   berlin2-sony-nsz-gs7.dt.yaml: sdhci@ab0000: $nodename:0:
>       'sdhci@ab0000' does not match '^mmc(@.*)?$'
>   berlin2-sony-nsz-gs7.dt.yaml: sdhci@ab0800: $nodename:0:
>       'sdhci@ab0800' does not match '^mmc(@.*)?$'
>   berlin2-sony-nsz-gs7.dt.yaml: sdhci@ab1000: $nodename:0:
>       'sdhci@ab1000' does not match '^mmc(@.*)?$'
>   berlin2cd-google-chromecast.dt.yaml: sdhci@ab0000: $nodename:0:
>       'sdhci@ab0000' does not match '^mmc(@.*)?$'
>   berlin2cd-valve-steamlink.dt.yaml: sdhci@ab0000: $nodename:0:
>       'sdhci@ab0000' does not match '^mmc(@.*)?$'
>   berlin2q-marvell-dmp.dt.yaml: sdhci@ab0000: $nodename:0:
>       'sdhci@ab0000' does not match '^mmc(@.*)?$'
>   berlin2q-marvell-dmp.dt.yaml: sdhci@ab0800: $nodename:0:
>       'sdhci@ab0800' does not match '^mmc(@.*)?$'
>   berlin2q-marvell-dmp.dt.yaml: sdhci@ab1000: $nodename:0:
>       'sdhci@ab1000' does not match '^mmc(@.*)?$'
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 00/28] DT: Improve validation for Marvell SoCs
  2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
                   ` (18 preceding siblings ...)
  2020-03-17  9:39 ` [PATCH 28/28] dt-bindings: usb: Convert ehci-mv " Lubomir Rintel
@ 2020-03-17 13:46 ` Andrew Lunn
       [not found]   ` <20200317134609.GN24270-g2DYL2Zd6BY@public.gmane.org>
  19 siblings, 1 reply; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:46 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:38:54AM +0100, Lubomir Rintel wrote:
> Hello World,

Yah, that is an issue here. Marvell have a few different SoC families,
each with there own maintainers. Gregory and I tend to look after
'mvebu', aka orion5x, kirkwood, dove, berlin and a few others. All the
others are 'Somebody elses' problem'.

How do you think this patchset should get merged? Are we going to
split it up, just nominate one maintainer to merge the lot, or go
direct to arm-soc?

       Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc
  2020-03-17  9:39 ` [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc Lubomir Rintel
@ 2020-03-17 13:48   ` Andrew Lunn
  2020-03-17 19:09     ` Lubomir Rintel
  2020-03-19 16:09     ` Rob Herring
       [not found]   ` <20200317093922.20785-14-lkundrak-NGH9Lh4a5iE@public.gmane.org>
  1 sibling, 2 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:48 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:07AM +0100, Lubomir Rintel wrote:
> These ports are compatible with NS8250 and handled by the same driver.
> Get rid of the extra document that fails to document the properties that
> are actually supported.

Hi Lubmir

This is needs a bit closer examination. By the PXA maintainers. It
appears there are two serial drivers, the 8250 and a PXA specific
driver.

	Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings
  2020-03-17  9:39 ` [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings Lubomir Rintel
@ 2020-03-17 13:54   ` Andrew Lunn
  2020-03-27 19:06   ` Rob Herring
  1 sibling, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:54 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 10:39:09AM +0100, Lubomir Rintel wrote:
> Add compatible strings for the boards we have in tree. At the same time,
> fix the MMP3 compatible string: the preferred vendor name for Marvell is
> "marvell", not "mrvl", and indeed "marvell,mmp3" has been actively used,
> not "mrvl,mmp3".
> 
> Fixes: 95aecb71b84e ("dt-bindings: arm: mrvl: Document MMP3 compatible string")
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

What is implied by the Fixes: tag? Do you expect this to be
back ported? Is anything actually broken here?

Apart from that:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 00/28] DT: Improve validation for Marvell SoCs
       [not found]   ` <20200317134609.GN24270-g2DYL2Zd6BY@public.gmane.org>
@ 2020-03-17 13:55     ` Alexandre Belloni
       [not found]       ` <20200317135551.GE3448-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
  0 siblings, 1 reply; 81+ messages in thread
From: Alexandre Belloni @ 2020-03-17 13:55 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Lubomir Rintel, Rob Herring, Linus Walleij, Bartosz Golaszewski,
	Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Mauro Carvalho Chehab, Ulf Hansson, Kishon Vijay Abraham I,
	Alessandro Zummo, Greg Kroah-Hartman, Mark Brown, Daniel Lezcano,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel

On 17/03/2020 14:46:09+0100, Andrew Lunn wrote:
> On Tue, Mar 17, 2020 at 10:38:54AM +0100, Lubomir Rintel wrote:
> > Hello World,
> 
> Yah, that is an issue here. Marvell have a few different SoC families,
> each with there own maintainers. Gregory and I tend to look after
> 'mvebu', aka orion5x, kirkwood, dove, berlin and a few others. All the
> others are 'Somebody elses' problem'.
> 

Hum, berlin is not mvebu, it was the same BU as the MMP and it has been
sold to synopsys a while ago.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 00/28] DT: Improve validation for Marvell SoCs
       [not found]       ` <20200317135551.GE3448-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
@ 2020-03-17 13:59         ` Andrew Lunn
  0 siblings, 0 replies; 81+ messages in thread
From: Andrew Lunn @ 2020-03-17 13:59 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Lubomir Rintel, Rob Herring, Linus Walleij, Bartosz Golaszewski,
	Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Mauro Carvalho Chehab, Ulf Hansson, Kishon Vijay Abraham I,
	Alessandro Zummo, Greg Kroah-Hartman, Mark Brown, Daniel Lezcano,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TY76Z2rM5mHXA, linux-kernel

On Tue, Mar 17, 2020 at 02:55:59PM +0100, Alexandre Belloni wrote:
> On 17/03/2020 14:46:09+0100, Andrew Lunn wrote:
> > On Tue, Mar 17, 2020 at 10:38:54AM +0100, Lubomir Rintel wrote:
> > > Hello World,
> > 
> > Yah, that is an issue here. Marvell have a few different SoC families,
> > each with there own maintainers. Gregory and I tend to look after
> > 'mvebu', aka orion5x, kirkwood, dove, berlin and a few others. All the
> > others are 'Somebody elses' problem'.
> > 
> 
> Hum, berlin is not mvebu, it was the same BU as the MMP and it has been
> sold to synopsys a while ago.

Yes, the boundaries are a bit fluffy. At least the early work by
Sebastian was merged via the mvebu maintainers, even if it is not
technically part of mvebu.

This is also part of the discussion about how this lot actually gets
merged.

	   Andrew

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc
  2020-03-17 13:48   ` Andrew Lunn
@ 2020-03-17 19:09     ` Lubomir Rintel
  2020-03-19 16:09     ` Rob Herring
  1 sibling, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-17 19:09 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Gregory Clement,
	Daniel Mack, Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 02:48:05PM +0100, Andrew Lunn wrote:
> On Tue, Mar 17, 2020 at 10:39:07AM +0100, Lubomir Rintel wrote:
> > These ports are compatible with NS8250 and handled by the same driver.
> > Get rid of the extra document that fails to document the properties that
> > are actually supported.
> 
> Hi Lubmir
> 
> This is needs a bit closer examination. By the PXA maintainers. It
> appears there are two serial drivers, the 8250 and a PXA specific
> driver.

Well, for "mrvl,mmp-uart", there are three: SERIAL_OF_PLATFORM,
SERIAL_8250_PXA and SERIAL_PXA:

  drivers/tty/serial/8250/8250_of.c:      { .compatible = "mrvl,mmp-uart",
  drivers/tty/serial/8250/8250_pxa.c:     { .compatible = "mrvl,mmp-uart", },
  drivers/tty/serial/pxa.c:       { .compatible = "mrvl,mmp-uart", },

For that matter, the hardware is also compatible with intel,xscale-uart
and the mrvl,mmp-uart compatible string is perhaps entirely unnecessary.

I guess the story is somewhat similar for mrvl,pxa-uart; I can not
verify though.

I suppose SERIAL_PXA is not really needed at this point and if support
for mrvl,pxa-uart was added to SERIAL_OF_PLATFORM, then SERIAL_8250_PXA
would only be useful for platforms that don't use DT and the DT bits
could be stripped from it eventually. That is -- if PXA maintainers
agree, of course.

> 	Andrew

Regards
Lubo

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema
  2020-03-17  9:39 ` [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema Lubomir Rintel
@ 2020-03-18 22:14   ` Rob Herring
  2020-03-18 22:37   ` Rob Herring
  1 sibling, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-18 22:14 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, 17 Mar 2020 10:39:13 +0100, Lubomir Rintel wrote:
> Convert the sdhci-pxa binding to DT schema format using json-schema.
> 
> At the same time, fix a couple of issues with the examples discovered by
> the validation tool -- a semicolon instead of a comma and wrong node names.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/mmc/sdhci-pxa.txt     |  50 ---------
>  .../devicetree/bindings/mmc/sdhci-pxa.yaml    | 101 ++++++++++++++++++
>  2 files changed, 101 insertions(+), 50 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
>  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/sdhci-pxa.example.dt.yaml: mmc@d4280800: 'mrvl,clk-delay-cycles' does not match any of the regexes: '^#.*', '^(at25|devbus|dmacap|dsa|exynos|fsi[ab]|gpio-fan|gpio|gpmc|hdmi|i2c-gpio),.*', '^(keypad|m25p|max8952|max8997|max8998|mpmc),.*', '^(pinctrl-single|#pinctrl-single|PowerPC),.*', '^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*', '^(simple-audio-card|simple-graph-card|st-plgpio|st-spics|ts),.*', '^GEFanuc,.*', '^ORCL,.*', '^SUNW,.*', '^[a-zA-Z0-9#_][a-zA-Z0-9+\\-._@]{0,63}$', '^[a-zA-Z0-9+\\-._]*@[0-9a-zA-Z,]*$', '^abilis,.*', '^abracon,.*', '^acme,.*', '^actions,.*', '^active-semi,.*', '^ad,.*', '^adafruit,.*', '^adapteva,.*', '^adaptrum,.*', '^adh,.*', '^adi,.*', '^advantech,.*', '^aeroflexgaisler,.
 *', '^al,.*', '^allegro,.*', '^allo,.*', '^allwinner,.*', '^alphascale,.*', '^altr,.*', '^amarula,.*', '^amazon,.*', '^amcc,.*', '^amd,.*', '^amediatech,.*', '^amlogic,.*', '^ampire,.*', '^ams,.*', '^amstaos,.*', '^analogix,.*', '^andestech,.*', '^anvo,.*', '^apm,.*', '^aptina,.*', '^arasan,.*', '^archermind,.*', '^arctic,.*', '^arcx,.*', '^aries,.*', '^arm,.*', '^armadeus,.*', '^arrow,.*', '^artesyn,.*', '^asahi-kasei,.*', '^asc,.*', '^aspeed,.*', '^asus,.*', '^atlas,.*', '^atmel,.*', '^auo,.*', '^auvidea,.*', '^avago,.*', '^avia,.*', '^avic,.*', '^avnet,.*', '^axentia,.*', '^axis,.*', '^azoteq,.*', '^azw,.*', '^bananapi,.*', '^bhf,.*', '^bitmain,.*', '^boe,.*', '^bosch,.*', '^boundary,.*', '^brcm,.*', '^broadmobi,.*', '^bticino,.*', '^buffalo,.*', '^bur,.*', '^calaosystems,.*', '^calxe
 da,.*', '^capella,.*', '^cascoda,.*', '^catalyst,.*', '^cavium,.*', '^cdns,.*', '^cdtech,.*', '^ceva,.*', '^chipidea,.*', '^chipone,.*', '^chipspark,.*', '^chrp,.*', '^chunghwa,.*', '^chuwi,.*', '^ciaa,.*', '^cirrus,.*', '^cloudengines,.*', '^cnm,.*', '^cnxt,.*', '^colorfly,.*', '^compulab,.*', '^corpro,.*', '^cortina,.*', '^cosmic,.*', '^crane,.*', '^creative,.*', '^crystalfontz,.*', '^csky,.*', '^csq,.*', '^cubietech,.*', '^cypress,.*', '^cznic,.*', '^dallas,.*', '^dataimage,.*', '^davicom,.*', '^delta,.*', '^denx,.*', '^devantech,.*', '^dh,.*', '^difrnce,.*', '^digi,.*', '^digilent,.*', '^dioo,.*', '^dlc,.*', '^dlg,.*', '^dlink,.*', '^dmo,.*', '^domintech,.*', '^dongwoon,.*', '^dptechnics,.*', '^dragino,.*', '^dserve,.*', '^ea,.*', '^ebs-systart,.*', '^ebv,.*', '^eckelmann,.*', '^edt,
 .*', '^eeti,.*', '^einfochips,.*', '^elan,.*', '^elgin,.*', '^embest,.*', '^emlid,.*', '^emmicro,.*', '^empire-electronix,.*', '^emtrion,.*', '^endless,.*', '^energymicro,.*', '^engicam,.*', '^epcos,.*', '^epfl,.*', '^epson,.*', '^esp,.*', '^est,.*', '^ettus,.*', '^eukrea,.*', '^everest,.*', '^everspin,.*', '^evervision,.*', '^exar,.*', '^excito,.*', '^ezchip,.*', '^facebook,.*', '^fairphone,.*', '^faraday,.*', '^fastrax,.*', '^fcs,.*', '^feiyang,.*', '^firefly,.*', '^focaltech,.*', '^friendlyarm,.*', '^fsl,.*', '^fujitsu,.*', '^gardena,.*', '^gateworks,.*', '^gcw,.*', '^ge,.*', '^geekbuying,.*', '^gef,.*', '^gemei,.*', '^geniatech,.*', '^giantec,.*', '^giantplus,.*', '^globalscale,.*', '^globaltop,.*', '^gmt,.*', '^goodix,.*', '^google,.*', '^grinn,.*', '^grmn,.*', '^gumstix,.*', '^gw,.
 *', '^hannstar,.*', '^haoyu,.*', '^hardkernel,.*', '^hideep,.*', '^himax,.*', '^hisilicon,.*', '^hit,.*', '^hitex,.*', '^holt,.*', '^holtek,.*', '^honeywell,.*', '^hoperun,.*', '^hp,.*', '^hsg,.*', '^hugsun,.*', '^hwacom,.*', '^hyundai,.*', '^i2se,.*', '^ibm,.*', '^icplus,.*', '^idt,.*', '^ifi,.*', '^ilitek,.*', '^img,.*', '^incircuit,.*', '^inet-tek,.*', '^infineon,.*', '^inforce,.*', '^ingenic,.*', '^innolux,.*', '^inside-secure,.*', '^inspur,.*', '^intel,.*', '^intercontrol,.*', '^invensense,.*', '^inversepath,.*', '^iom,.*', '^isee,.*', '^isil,.*', '^issi,.*', '^itead,.*', '^iwave,.*', '^jdi,.*', '^jedec,.*', '^jesurun,.*', '^jianda,.*', '^kam,.*', '^karo,.*', '^keithkoep,.*', '^keymile,.*', '^khadas,.*', '^kiebackpeter,.*', '^kinetic,.*', '^kingdisplay,.*', '^kingnovel,.*', '^kionix
 ,.*', '^kobo,.*', '^koe,.*', '^kontron,.*', '^kosagi,.*', '^kyo,.*', '^lacie,.*', '^laird,.*', '^lamobo,.*', '^lantiq,.*', '^lattice,.*', '^leadtek,.*', '^leez,.*', '^lego,.*', '^lemaker,.*', '^lenovo,.*', '^lg,.*', '^lgphilips,.*', '^libretech,.*', '^licheepi,.*', '^linaro,.*', '^linksprite,.*', '^linksys,.*', '^linux,.*', '^linx,.*', '^lltc,.*', '^logicpd,.*', '^longcheer,.*', '^loongson,.*', '^lsi,.*', '^lwn,.*', '^macnica,.*', '^mapleboard,.*', '^marvell,.*', '^maxbotix,.*', '^maxim,.*', '^mbvl,.*', '^mcube,.*', '^meas,.*', '^mecer,.*', '^mediatek,.*', '^megachips,.*', '^mele,.*', '^melexis,.*', '^melfas,.*', '^mellanox,.*', '^memsic,.*', '^menlo,.*', '^merrii,.*', '^micrel,.*', '^microchip,.*', '^microcrystal,.*', '^micron,.*', '^microsoft,.*', '^mikroe,.*', '^miniand,.*', '^minix,.
 *', '^miramems,.*', '^mitsubishi,.*', '^mosaixtech,.*', '^motorola,.*', '^moxa,.*', '^mpl,.*', '^mps,.*', '^mqmaker,.*', '^mscc,.*', '^msi,.*', '^mti,.*', '^multi-inno,.*', '^mundoreader,.*', '^murata,.*', '^mxicy,.*', '^myir,.*', '^national,.*', '^nec,.*', '^neonode,.*', '^netgear,.*', '^netlogic,.*', '^netron-dy,.*', '^netxeon,.*', '^newhaven,.*', '^nexbox,.*', '^nextthing,.*', '^ni,.*', '^nintendo,.*', '^nlt,.*', '^nokia,.*', '^nordic,.*', '^novtech,.*', '^nutsboard,.*', '^nuvoton,.*', '^nvd,.*', '^nvidia,.*', '^nxp,.*', '^oceanic,.*', '^okaya,.*', '^oki,.*', '^olimex,.*', '^olpc,.*', '^onion,.*', '^onnn,.*', '^ontat,.*', '^opalkelly,.*', '^opencores,.*', '^openrisc,.*', '^option,.*', '^oranth,.*', '^orisetech,.*', '^ortustech,.*', '^osddisplays,.*', '^overkiz,.*', '^ovti,.*', '^oxsem
 i,.*', '^panasonic,.*', '^parade,.*', '^parallax,.*', '^pda,.*', '^pericom,.*', '^pervasive,.*', '^phicomm,.*', '^phytec,.*', '^picochip,.*', '^pine64,.*', '^pineriver,.*', '^pixcir,.*', '^plantower,.*', '^plathome,.*', '^plda,.*', '^plx,.*', '^pni,.*', '^polaroid,.*', '^portwell,.*', '^poslab,.*', '^pov,.*', '^powervr,.*', '^primux,.*', '^probox2,.*', '^pulsedlight,.*', '^purism,.*', '^qca,.*', '^qcom,.*', '^qemu,.*', '^qi,.*', '^qiaodian,.*', '^qihua,.*', '^qnap,.*', '^radxa,.*', '^raidsonic,.*', '^ralink,.*', '^ramtron,.*', '^raspberrypi,.*', '^raydium,.*', '^rda,.*', '^realtek,.*', '^renesas,.*', '^rervision,.*', '^richtek,.*', '^ricoh,.*', '^rikomagic,.*', '^riscv,.*', '^rockchip,.*', '^rocktech,.*', '^rohm,.*', '^ronbo,.*', '^roofull,.*', '^samsung,.*', '^samtec,.*', '^sancloud,.*'
 , '^sandisk,.*', '^satoz,.*', '^sbs,.*', '^schindler,.*', '^seagate,.*', '^seirobotics,.*', '^semtech,.*', '^sensirion,.*', '^sensortek,.*', '^sff,.*', '^sgd,.*', '^sgx,.*', '^sharp,.*', '^shimafuji,.*', '^si-en,.*', '^si-linux,.*', '^sifive,.*', '^sigma,.*', '^sii,.*', '^sil,.*', '^silabs,.*', '^silead,.*', '^silergy,.*', '^siliconmitus,.*', '^simtek,.*', '^sinlinx,.*', '^sinovoip,.*', '^sipeed,.*', '^sirf,.*', '^sis,.*', '^sitronix,.*', '^skyworks,.*', '^smsc,.*', '^snps,.*', '^sochip,.*', '^socionext,.*', '^solidrun,.*', '^solomon,.*', '^sony,.*', '^spansion,.*', '^sprd,.*', '^sst,.*', '^st,.*', '^st-ericsson,.*', '^starry,.*', '^startek,.*', '^ste,.*', '^stericsson,.*', '^summit,.*', '^sunchip,.*', '^swir,.*', '^syna,.*', '^synology,.*', '^tbs,.*', '^tbs-biometrics,.*', '^tcg,.*', '^
 tcl,.*', '^technexion,.*', '^technologic,.*', '^techstar,.*', '^tempo,.*', '^terasic,.*', '^tfc,.*', '^thine,.*', '^ti,.*', '^tianma,.*', '^tlm,.*', '^tmt,.*', '^topeet,.*', '^toppoly,.*', '^toradex,.*', '^toshiba,.*', '^toumaz,.*', '^tpk,.*', '^tplink,.*', '^tpo,.*', '^tq,.*', '^tronfy,.*', '^tronsmart,.*', '^truly,.*', '^tsd,.*', '^tyan,.*', '^u-blox,.*', '^ubnt,.*', '^ucrobotics,.*', '^udoo,.*', '^ugoos,.*', '^uniwest,.*', '^upisemi,.*', '^urt,.*', '^usi,.*', '^utoo,.*', '^v3,.*', '^vamrs,.*', '^variscite,.*', '^via,.*', '^videostrong,.*', '^virtio,.*', '^vishay,.*', '^vitesse,.*', '^vivante,.*', '^vocore,.*', '^voipac,.*', '^vot,.*', '^vxt,.*', '^wd,.*', '^wetek,.*', '^wexler,.*', '^whwave,.*', '^wi2wi,.*', '^winbond,.*', '^winstar,.*', '^wits,.*', '^wlf,.*', '^wm,.*', '^wobo,.*', '^
 x-powers,.*', '^xes,.*', '^xillybus,.*', '^xinpeng,.*', '^xlnx,.*', '^xunlong,.*', '^xylon,.*', '^yna,.*', '^yones-toptech,.*', '^ysoft,.*', '^zarlink,.*', '^zeitec,.*', '^zidoo,.*', '^zii,.*', '^zte,.*', '^zyxel,.*'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/sdhci-pxa.example.dt.yaml: mmc@d8000: 'mrvl,clk-delay-cycles' does not match any of the regexes: '^#.*', '^(at25|devbus|dmacap|dsa|exynos|fsi[ab]|gpio-fan|gpio|gpmc|hdmi|i2c-gpio),.*', '^(keypad|m25p|max8952|max8997|max8998|mpmc),.*', '^(pinctrl-single|#pinctrl-single|PowerPC),.*', '^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*', '^(simple-audio-card|simple-graph-card|st-plgpio|st-spics|ts),.*', '^GEFanuc,.*', '^ORCL,.*', '^SUNW,.*', '^[a-zA-Z0-9#_][a-zA-Z0-9+\\-._@]{0,63}$', '^[a-zA-Z0-9+\\-._]*@[0-9a-zA-Z,]*$', '^abilis,.*', '^abracon,.*', '^acme,.*', '^actions,.*', '^active-semi,.*', '^ad,.*', '^adafruit,.*', '^adapteva,.*', '^adaptrum,.*', '^adh,.*', '^adi,.*', '^advantech,.*', '^aeroflexgaisler,.*',
  '^al,.*', '^allegro,.*', '^allo,.*', '^allwinner,.*', '^alphascale,.*', '^altr,.*', '^amarula,.*', '^amazon,.*', '^amcc,.*', '^amd,.*', '^amediatech,.*', '^amlogic,.*', '^ampire,.*', '^ams,.*', '^amstaos,.*', '^analogix,.*', '^andestech,.*', '^anvo,.*', '^apm,.*', '^aptina,.*', '^arasan,.*', '^archermind,.*', '^arctic,.*', '^arcx,.*', '^aries,.*', '^arm,.*', '^armadeus,.*', '^arrow,.*', '^artesyn,.*', '^asahi-kasei,.*', '^asc,.*', '^aspeed,.*', '^asus,.*', '^atlas,.*', '^atmel,.*', '^auo,.*', '^auvidea,.*', '^avago,.*', '^avia,.*', '^avic,.*', '^avnet,.*', '^axentia,.*', '^axis,.*', '^azoteq,.*', '^azw,.*', '^bananapi,.*', '^bhf,.*', '^bitmain,.*', '^boe,.*', '^bosch,.*', '^boundary,.*', '^brcm,.*', '^broadmobi,.*', '^bticino,.*', '^buffalo,.*', '^bur,.*', '^calaosystems,.*', '^calxeda,
 .*', '^capella,.*', '^cascoda,.*', '^catalyst,.*', '^cavium,.*', '^cdns,.*', '^cdtech,.*', '^ceva,.*', '^chipidea,.*', '^chipone,.*', '^chipspark,.*', '^chrp,.*', '^chunghwa,.*', '^chuwi,.*', '^ciaa,.*', '^cirrus,.*', '^cloudengines,.*', '^cnm,.*', '^cnxt,.*', '^colorfly,.*', '^compulab,.*', '^corpro,.*', '^cortina,.*', '^cosmic,.*', '^crane,.*', '^creative,.*', '^crystalfontz,.*', '^csky,.*', '^csq,.*', '^cubietech,.*', '^cypress,.*', '^cznic,.*', '^dallas,.*', '^dataimage,.*', '^davicom,.*', '^delta,.*', '^denx,.*', '^devantech,.*', '^dh,.*', '^difrnce,.*', '^digi,.*', '^digilent,.*', '^dioo,.*', '^dlc,.*', '^dlg,.*', '^dlink,.*', '^dmo,.*', '^domintech,.*', '^dongwoon,.*', '^dptechnics,.*', '^dragino,.*', '^dserve,.*', '^ea,.*', '^ebs-systart,.*', '^ebv,.*', '^eckelmann,.*', '^edt,.*'
 , '^eeti,.*', '^einfochips,.*', '^elan,.*', '^elgin,.*', '^embest,.*', '^emlid,.*', '^emmicro,.*', '^empire-electronix,.*', '^emtrion,.*', '^endless,.*', '^energymicro,.*', '^engicam,.*', '^epcos,.*', '^epfl,.*', '^epson,.*', '^esp,.*', '^est,.*', '^ettus,.*', '^eukrea,.*', '^everest,.*', '^everspin,.*', '^evervision,.*', '^exar,.*', '^excito,.*', '^ezchip,.*', '^facebook,.*', '^fairphone,.*', '^faraday,.*', '^fastrax,.*', '^fcs,.*', '^feiyang,.*', '^firefly,.*', '^focaltech,.*', '^friendlyarm,.*', '^fsl,.*', '^fujitsu,.*', '^gardena,.*', '^gateworks,.*', '^gcw,.*', '^ge,.*', '^geekbuying,.*', '^gef,.*', '^gemei,.*', '^geniatech,.*', '^giantec,.*', '^giantplus,.*', '^globalscale,.*', '^globaltop,.*', '^gmt,.*', '^goodix,.*', '^google,.*', '^grinn,.*', '^grmn,.*', '^gumstix,.*', '^gw,.*',
  '^hannstar,.*', '^haoyu,.*', '^hardkernel,.*', '^hideep,.*', '^himax,.*', '^hisilicon,.*', '^hit,.*', '^hitex,.*', '^holt,.*', '^holtek,.*', '^honeywell,.*', '^hoperun,.*', '^hp,.*', '^hsg,.*', '^hugsun,.*', '^hwacom,.*', '^hyundai,.*', '^i2se,.*', '^ibm,.*', '^icplus,.*', '^idt,.*', '^ifi,.*', '^ilitek,.*', '^img,.*', '^incircuit,.*', '^inet-tek,.*', '^infineon,.*', '^inforce,.*', '^ingenic,.*', '^innolux,.*', '^inside-secure,.*', '^inspur,.*', '^intel,.*', '^intercontrol,.*', '^invensense,.*', '^inversepath,.*', '^iom,.*', '^isee,.*', '^isil,.*', '^issi,.*', '^itead,.*', '^iwave,.*', '^jdi,.*', '^jedec,.*', '^jesurun,.*', '^jianda,.*', '^kam,.*', '^karo,.*', '^keithkoep,.*', '^keymile,.*', '^khadas,.*', '^kiebackpeter,.*', '^kinetic,.*', '^kingdisplay,.*', '^kingnovel,.*', '^kionix,.*
 ', '^kobo,.*', '^koe,.*', '^kontron,.*', '^kosagi,.*', '^kyo,.*', '^lacie,.*', '^laird,.*', '^lamobo,.*', '^lantiq,.*', '^lattice,.*', '^leadtek,.*', '^leez,.*', '^lego,.*', '^lemaker,.*', '^lenovo,.*', '^lg,.*', '^lgphilips,.*', '^libretech,.*', '^licheepi,.*', '^linaro,.*', '^linksprite,.*', '^linksys,.*', '^linux,.*', '^linx,.*', '^lltc,.*', '^logicpd,.*', '^longcheer,.*', '^loongson,.*', '^lsi,.*', '^lwn,.*', '^macnica,.*', '^mapleboard,.*', '^marvell,.*', '^maxbotix,.*', '^maxim,.*', '^mbvl,.*', '^mcube,.*', '^meas,.*', '^mecer,.*', '^mediatek,.*', '^megachips,.*', '^mele,.*', '^melexis,.*', '^melfas,.*', '^mellanox,.*', '^memsic,.*', '^menlo,.*', '^merrii,.*', '^micrel,.*', '^microchip,.*', '^microcrystal,.*', '^micron,.*', '^microsoft,.*', '^mikroe,.*', '^miniand,.*', '^minix,.*',
  '^miramems,.*', '^mitsubishi,.*', '^mosaixtech,.*', '^motorola,.*', '^moxa,.*', '^mpl,.*', '^mps,.*', '^mqmaker,.*', '^mscc,.*', '^msi,.*', '^mti,.*', '^multi-inno,.*', '^mundoreader,.*', '^murata,.*', '^mxicy,.*', '^myir,.*', '^national,.*', '^nec,.*', '^neonode,.*', '^netgear,.*', '^netlogic,.*', '^netron-dy,.*', '^netxeon,.*', '^newhaven,.*', '^nexbox,.*', '^nextthing,.*', '^ni,.*', '^nintendo,.*', '^nlt,.*', '^nokia,.*', '^nordic,.*', '^novtech,.*', '^nutsboard,.*', '^nuvoton,.*', '^nvd,.*', '^nvidia,.*', '^nxp,.*', '^oceanic,.*', '^okaya,.*', '^oki,.*', '^olimex,.*', '^olpc,.*', '^onion,.*', '^onnn,.*', '^ontat,.*', '^opalkelly,.*', '^opencores,.*', '^openrisc,.*', '^option,.*', '^oranth,.*', '^orisetech,.*', '^ortustech,.*', '^osddisplays,.*', '^overkiz,.*', '^ovti,.*', '^oxsemi,.
 *', '^panasonic,.*', '^parade,.*', '^parallax,.*', '^pda,.*', '^pericom,.*', '^pervasive,.*', '^phicomm,.*', '^phytec,.*', '^picochip,.*', '^pine64,.*', '^pineriver,.*', '^pixcir,.*', '^plantower,.*', '^plathome,.*', '^plda,.*', '^plx,.*', '^pni,.*', '^polaroid,.*', '^portwell,.*', '^poslab,.*', '^pov,.*', '^powervr,.*', '^primux,.*', '^probox2,.*', '^pulsedlight,.*', '^purism,.*', '^qca,.*', '^qcom,.*', '^qemu,.*', '^qi,.*', '^qiaodian,.*', '^qihua,.*', '^qnap,.*', '^radxa,.*', '^raidsonic,.*', '^ralink,.*', '^ramtron,.*', '^raspberrypi,.*', '^raydium,.*', '^rda,.*', '^realtek,.*', '^renesas,.*', '^rervision,.*', '^richtek,.*', '^ricoh,.*', '^rikomagic,.*', '^riscv,.*', '^rockchip,.*', '^rocktech,.*', '^rohm,.*', '^ronbo,.*', '^roofull,.*', '^samsung,.*', '^samtec,.*', '^sancloud,.*', '
 ^sandisk,.*', '^satoz,.*', '^sbs,.*', '^schindler,.*', '^seagate,.*', '^seirobotics,.*', '^semtech,.*', '^sensirion,.*', '^sensortek,.*', '^sff,.*', '^sgd,.*', '^sgx,.*', '^sharp,.*', '^shimafuji,.*', '^si-en,.*', '^si-linux,.*', '^sifive,.*', '^sigma,.*', '^sii,.*', '^sil,.*', '^silabs,.*', '^silead,.*', '^silergy,.*', '^siliconmitus,.*', '^simtek,.*', '^sinlinx,.*', '^sinovoip,.*', '^sipeed,.*', '^sirf,.*', '^sis,.*', '^sitronix,.*', '^skyworks,.*', '^smsc,.*', '^snps,.*', '^sochip,.*', '^socionext,.*', '^solidrun,.*', '^solomon,.*', '^sony,.*', '^spansion,.*', '^sprd,.*', '^sst,.*', '^st,.*', '^st-ericsson,.*', '^starry,.*', '^startek,.*', '^ste,.*', '^stericsson,.*', '^summit,.*', '^sunchip,.*', '^swir,.*', '^syna,.*', '^synology,.*', '^tbs,.*', '^tbs-biometrics,.*', '^tcg,.*', '^tcl
 ,.*', '^technexion,.*', '^technologic,.*', '^techstar,.*', '^tempo,.*', '^terasic,.*', '^tfc,.*', '^thine,.*', '^ti,.*', '^tianma,.*', '^tlm,.*', '^tmt,.*', '^topeet,.*', '^toppoly,.*', '^toradex,.*', '^toshiba,.*', '^toumaz,.*', '^tpk,.*', '^tplink,.*', '^tpo,.*', '^tq,.*', '^tronfy,.*', '^tronsmart,.*', '^truly,.*', '^tsd,.*', '^tyan,.*', '^u-blox,.*', '^ubnt,.*', '^ucrobotics,.*', '^udoo,.*', '^ugoos,.*', '^uniwest,.*', '^upisemi,.*', '^urt,.*', '^usi,.*', '^utoo,.*', '^v3,.*', '^vamrs,.*', '^variscite,.*', '^via,.*', '^videostrong,.*', '^virtio,.*', '^vishay,.*', '^vitesse,.*', '^vivante,.*', '^vocore,.*', '^voipac,.*', '^vot,.*', '^vxt,.*', '^wd,.*', '^wetek,.*', '^wexler,.*', '^whwave,.*', '^wi2wi,.*', '^winbond,.*', '^winstar,.*', '^wits,.*', '^wlf,.*', '^wm,.*', '^wobo,.*', '^x-p
 owers,.*', '^xes,.*', '^xillybus,.*', '^xinpeng,.*', '^xlnx,.*', '^xunlong,.*', '^xylon,.*', '^yna,.*', '^yones-toptech,.*', '^ysoft,.*', '^zarlink,.*', '^zeitec,.*', '^zidoo,.*', '^zii,.*', '^zte,.*', '^zyxel,.*'

See https://patchwork.ozlabs.org/patch/1256162
Please check and re-submit.

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema
  2020-03-17  9:39 ` [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema Lubomir Rintel
  2020-03-18 22:14   ` Rob Herring
@ 2020-03-18 22:37   ` Rob Herring
  2020-05-17 18:35     ` Lubomir Rintel
  1 sibling, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-18 22:37 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> Convert the sdhci-pxa binding to DT schema format using json-schema.

Ignore what my bot said, I see you addressed that earlier in the series.

> At the same time, fix a couple of issues with the examples discovered by
> the validation tool -- a semicolon instead of a comma and wrong node names.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/mmc/sdhci-pxa.txt     |  50 ---------
>  .../devicetree/bindings/mmc/sdhci-pxa.yaml    | 101 ++++++++++++++++++
>  2 files changed, 101 insertions(+), 50 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
>  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
> deleted file mode 100644
> index 3d1b449d6097d..0000000000000
> --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -* Marvell sdhci-pxa v2/v3 controller
> -
> -This file documents differences between the core properties in mmc.txt
> -and the properties used by the sdhci-pxav2 and sdhci-pxav3 drivers.
> -
> -Required properties:
> -- compatible: Should be "mrvl,pxav2-mmc", "mrvl,pxav3-mmc" or
> -  "marvell,armada-380-sdhci".
> -- reg:
> -  * for "mrvl,pxav2-mmc" and "mrvl,pxav3-mmc", one register area for
> -    the SDHCI registers.
> -
> -  * for "marvell,armada-380-sdhci", three register areas. The first
> -    one for the SDHCI registers themselves, the second one for the
> -    AXI/Mbus bridge registers of the SDHCI unit, the third one for the
> -    SDIO3 Configuration register
> -- reg names: should be "sdhci", "mbus", "conf-sdio3". only mandatory
> -  for "marvell,armada-380-sdhci"
> -- clocks: Array of clocks required for SDHCI; requires at least one for
> -    I/O clock.
> -- clock-names: Array of names corresponding to clocks property; shall be
> -    "io" for I/O clock and "core" for optional core clock.
> -
> -Optional properties:
> -- mrvl,clk-delay-cycles: Specify a number of cycles to delay for tuning.
> -
> -Example:
> -
> -sdhci@d4280800 {
> -       compatible = "mrvl,pxav3-mmc";
> -       reg = <0xd4280800 0x800>;
> -       bus-width = <8>;
> -       interrupts = <27>;
> -       clocks = <&chip CLKID_SDIO1XIN>, <&chip CLKID_SDIO1>;
> -       clock-names = "io", "core";
> -       non-removable;
> -       mrvl,clk-delay-cycles = <31>;
> -};
> -
> -sdhci@d8000 {
> -       compatible = "marvell,armada-380-sdhci";
> -       reg-names = "sdhci", "mbus", "conf-sdio3";
> -       reg = <0xd8000 0x1000>,
> -               <0xdc000 0x100>;
> -               <0x18454 0x4>;
> -       interrupts = <0 25 0x4>;
> -       clocks = <&gateclk 17>;
> -       clock-names = "io";
> -       mrvl,clk-delay-cycles = <0x1F>;
> -};
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> new file mode 100644
> index 0000000000000..4ae0926ac294f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> @@ -0,0 +1,101 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA SDHCI v2/v3 bindings
> +
> +maintainers:
> +  - devicetree@vger.kernel.org
> +
> +allOf:
> +  - $ref: mmc-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: marvell,armada-380-sdhci
> +    then:
> +      properties:
> +        regs:
> +          minItems: 3
> +          maxItems: 3

Here, you just need minItems.

> +        reg-names:
> +          items:
> +            - const: sdhci
> +            - const: mbus
> +            - const: conf-sdio3

This should be under the main definition of 'reg-names' and then just
'minItems: 3' here.

> +      required:
> +        - reg-names
> +    else:
> +      properties:
> +        regs:
> +          minItems: 1
> +          maxItems: 1

Just 'maxItems' is sufficient.

> +        reg-names:
> +          minItems: 1
> +          maxItems: 1
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mrvl,pxav2-mmc
> +      - mrvl,pxav3-mmc
> +      - marvell,armada-380-sdhci
> +
> +  reg: true

Here you should have:

minItems: 1
maxItems: 3

> +
> +  reg-names: true
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 2
> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 2
> +    items:
> +      - const: io
> +      - const: core
> +
> +  mrvl,clk-delay-cycles:
> +    description: Specify a number of cycles to delay for tuning.
> +    $ref: /schemas/types.yaml#/definitions/uint32

No range of valid values?

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/berlin2.h>
> +    mmc@d4280800 {
> +        compatible = "mrvl,pxav3-mmc";
> +        reg = <0xd4280800 0x800>;
> +        bus-width = <8>;
> +        interrupts = <27>;
> +        clocks = <&chip CLKID_SDIO1XIN>, <&chip CLKID_SDIO1>;
> +        clock-names = "io", "core";
> +        non-removable;
> +        mrvl,clk-delay-cycles = <31>;
> +    };
> +  - |
> +    mmc@d8000 {
> +        compatible = "marvell,armada-380-sdhci";
> +        reg-names = "sdhci", "mbus", "conf-sdio3";
> +        reg = <0xd8000 0x1000>,
> +              <0xdc000 0x100>,
> +              <0x18454 0x4>;
> +        interrupts = <0 25 0x4>;
> +        clocks = <&gateclk 17>;
> +        clock-names = "io";
> +        mrvl,clk-delay-cycles = <0x1F>;
> +    };
> +
> +...
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc
  2020-03-17 13:48   ` Andrew Lunn
  2020-03-17 19:09     ` Lubomir Rintel
@ 2020-03-19 16:09     ` Rob Herring
  1 sibling, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-19 16:09 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Lubomir Rintel, Linus Walleij, Bartosz Golaszewski,
	Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Mauro Carvalho Chehab, Ulf Hansson, Kishon Vijay Abraham I,
	Alessandro Zummo, Alexandre Belloni, Greg Kroah-Hartman,
	Mark Brown, Daniel Lezcano, Gregory Clement, Daniel Mack,
	Haojian Zhuang, Robert Jarzmik, devicetree

On Tue, Mar 17, 2020 at 7:48 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Tue, Mar 17, 2020 at 10:39:07AM +0100, Lubomir Rintel wrote:
> > These ports are compatible with NS8250 and handled by the same driver.
> > Get rid of the extra document that fails to document the properties that
> > are actually supported.
>
> Hi Lubmir
>
> This is needs a bit closer examination. By the PXA maintainers. It
> appears there are two serial drivers, the 8250 and a PXA specific
> driver.

Yes, but that is independent of the binding.

The PXA driver (serial/pxa.c) is already deprecated in favor of
8250_pxa.c. That was 3.5 years ago now, so maybe time to remove the
old one.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc
       [not found]   ` <20200317093922.20785-14-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-19 16:11     ` Rob Herring
  2020-03-20  9:24       ` Lubomir Rintel
  0 siblings, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-19 16:11 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> wrote:
>
> These ports are compatible with NS8250 and handled by the same driver.
> Get rid of the extra document that fails to document the properties that
> are actually supported.
>
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/serial/8250.txt        | 2 ++
>  Documentation/devicetree/bindings/serial/mrvl-serial.txt | 4 ----
>  2 files changed, 2 insertions(+), 4 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/serial/mrvl-serial.txt

Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

I'd really like to see 8250.txt converted to schema.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 12/28] spi: dt-bindings: spi-controller: Slaves have no address cells
       [not found]   ` <20200317093922.20785-13-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-19 16:51     ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-19 16:51 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org> wrote:
>
> SPI controllers in slave mode have a single child node that has no
> address. Enforce #address-cells of zero instead of one.

Geert has fixed this making 'spi-slave' and '#address-cells' mutually exclusive.

https://lore.kernel.org/linux-devicetree/20200306085038.8111-2-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org/

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc
  2020-03-19 16:11     ` Rob Herring
@ 2020-03-20  9:24       ` Lubomir Rintel
  0 siblings, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-03-20  9:24 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Thu, Mar 19, 2020 at 10:11:02AM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
> >
> > These ports are compatible with NS8250 and handled by the same driver.
> > Get rid of the extra document that fails to document the properties that
> > are actually supported.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  Documentation/devicetree/bindings/serial/8250.txt        | 2 ++
> >  Documentation/devicetree/bindings/serial/mrvl-serial.txt | 4 ----
> >  2 files changed, 2 insertions(+), 4 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/serial/mrvl-serial.txt
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> I'd really like to see 8250.txt converted to schema.

I'll follow up just with that.

Thanks quarantine.

> Rob

Lubo

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property
  2020-03-17 13:28       ` Andrew Lunn
@ 2020-03-21  7:36         ` Robert Jarzmik
  0 siblings, 0 replies; 81+ messages in thread
From: Robert Jarzmik @ 2020-03-21  7:36 UTC (permalink / raw)
  To: Andrew Lunn
  Cc: Lubomir Rintel, Rob Herring, Linus Walleij, Bartosz Golaszewski,
	Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Mauro Carvalho Chehab, Ulf Hansson, Kishon Vijay Abraham I,
	Alessandro Zummo, Alexandre Belloni, Greg Kroah-Hartman,
	Mark Brown, Daniel Lezcano, Gregory Clement, Daniel Mack,
	Haojian Zhuang, devicetree

Andrew Lunn <andrew@lunn.ch> writes:

> On Tue, Mar 17, 2020 at 10:38:59AM +0100, Lubomir Rintel wrote:
>> This way the device tree validator learns that each cell of the property
>> constitutes a separate item. Otherwise it gets unnecessairly upset:
>> 
>>   pxa300-raumfeld-speaker-s.dt.yaml: gpio@40e00000: interrupts:
>>       [[8, 9, 10]] is too short
>> 
>> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr.>

-- 
Robert

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 18/28] dt-bindings: mmc: Fix node name in an example
  2020-03-17  9:39 ` [PATCH 18/28] dt-bindings: mmc: Fix node name in an example Lubomir Rintel
@ 2020-03-26 14:28   ` Ulf Hansson
  0 siblings, 0 replies; 81+ messages in thread
From: Ulf Hansson @ 2020-03-26 14:28 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Rob Herring, Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	DTML

On Tue, 17 Mar 2020 at 10:40, Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> The $nodename allows only "mmc@*" whereas the example node is named
> "sdhci".
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index c9384ed685b8f..c03fe268c29a0 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -351,7 +351,7 @@ dependencies:
>
>  examples:
>    - |
> -    sdhci@ab000000 {
> +    mmc@ab000000 {
>          compatible = "sdhci";
>          reg = <0xab000000 0x200>;
>          interrupts = <23>;
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema
  2020-03-17  9:39 ` [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio " Lubomir Rintel
@ 2020-03-27 10:04   ` Linus Walleij
  2020-03-27 19:29     ` Rob Herring
  2020-03-27 19:28   ` Rob Herring
  1 sibling, 1 reply; 81+ messages in thread
From: Linus Walleij @ 2020-03-27 10:04 UTC (permalink / raw)
  To: Lubomir Rintel, Robert Jarzmik
  Cc: Rob Herring, Bartosz Golaszewski, Thomas Gleixner, Jason Cooper,
	Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS

Hi Lubomir!

Excellent work! Just nitpicks:

On Tue, Mar 17, 2020 at 10:40 AM Lubomir Rintel <lkundrak@v3.sk> wrote:

> +++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> @@ -0,0 +1,173 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/mrvl-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA GPIO controller

This binding is lacking a license. Please use the dual GPL+BSD license
tag.

> +maintainers:
> +  - devicetree@vger.kernel.org

I don't know if Robert Jarzmik is in on maintaining this, would you accept
it Robert?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible
  2020-03-17  9:39 ` [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible Lubomir Rintel
@ 2020-03-27 19:03   ` Rob Herring
  2020-03-27 19:04   ` Rob Herring
  1 sibling, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:03 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:08AM +0100, Lubomir Rintel wrote:
> The validation is unhappy about mmp3-dell-ariel declaring its
> marvell,tauros3-cache node to be compatible with arm,pl310-cache:
> 
>   mmp3-dell-ariel.dt.yaml: cache-controller@d0020000: compatible:
>        Additional items are not allowed ('arm,pl310-cache' was unexpected)
>   mmp3-dell-ariel.dt.yaml: cache-controller@d0020000: compatible:
>        ['marvell,tauros3-cache', 'arm,pl310-cache'] is too long
> 
> Let's allow this -- Tauros 3 is designed to be compatible with PL310.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/arm/l2c2x0.yaml       | 45 ++++++++++---------
>  1 file changed, 24 insertions(+), 21 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/l2c2x0.yaml b/Documentation/devicetree/bindings/arm/l2c2x0.yaml
> index 913a8cd8b2c00..7e39088a9bed2 100644
> --- a/Documentation/devicetree/bindings/arm/l2c2x0.yaml
> +++ b/Documentation/devicetree/bindings/arm/l2c2x0.yaml
> @@ -29,27 +29,30 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - arm,pl310-cache
> -      - arm,l220-cache
> -      - arm,l210-cache
> -        # DEPRECATED by "brcm,bcm11351-a2-pl310-cache"
> -      - bcm,bcm11351-a2-pl310-cache
> -        # For Broadcom bcm11351 chipset where an
> -        # offset needs to be added to the address before passing down to the L2
> -        # cache controller
> -      - brcm,bcm11351-a2-pl310-cache
> -        # Marvell Controller designed to be
> -        # compatible with the ARM one, with system cache mode (meaning
> -        # maintenance operations on L1 are broadcasted to the L2 and L2
> -        # performs the same operation).
> -      - marvell,aurora-system-cache
> -        # Marvell Controller designed to be
> -        # compatible with the ARM one with outer cache mode.
> -      - marvell,aurora-outer-cache
> -        # Marvell Tauros3 cache controller, compatible
> -        # with arm,pl310-cache controller.
> -      - marvell,tauros3-cache
> +    oneOf:
> +      - enum:
> +        - arm,pl310-cache

The list should be indented 2 more spaces. I'll fixup when applying.

> +        - arm,l220-cache
> +        - arm,l210-cache
> +          # DEPRECATED by "brcm,bcm11351-a2-pl310-cache"
> +        - bcm,bcm11351-a2-pl310-cache
> +          # For Broadcom bcm11351 chipset where an
> +          # offset needs to be added to the address before passing down to the L2
> +          # cache controller
> +        - brcm,bcm11351-a2-pl310-cache
> +          # Marvell Controller designed to be
> +          # compatible with the ARM one, with system cache mode (meaning
> +          # maintenance operations on L1 are broadcasted to the L2 and L2
> +          # performs the same operation).
> +        - marvell,aurora-system-cache
> +          # Marvell Controller designed to be
> +          # compatible with the ARM one with outer cache mode.
> +        - marvell,aurora-outer-cache
> +      - items:
> +         # Marvell Tauros3 cache controller, compatible
> +         # with arm,pl310-cache controller.
> +        - const: marvell,tauros3-cache
> +        - const: arm,pl310-cache
>  
>    cache-level:
>      const: 2
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible
  2020-03-17  9:39 ` [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible Lubomir Rintel
  2020-03-27 19:03   ` Rob Herring
@ 2020-03-27 19:04   ` Rob Herring
  1 sibling, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:04 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, 17 Mar 2020 10:39:08 +0100, Lubomir Rintel wrote:
> The validation is unhappy about mmp3-dell-ariel declaring its
> marvell,tauros3-cache node to be compatible with arm,pl310-cache:
> 
>   mmp3-dell-ariel.dt.yaml: cache-controller@d0020000: compatible:
>        Additional items are not allowed ('arm,pl310-cache' was unexpected)
>   mmp3-dell-ariel.dt.yaml: cache-controller@d0020000: compatible:
>        ['marvell,tauros3-cache', 'arm,pl310-cache'] is too long
> 
> Let's allow this -- Tauros 3 is designed to be compatible with PL310.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/arm/l2c2x0.yaml       | 45 ++++++++++---------
>  1 file changed, 24 insertions(+), 21 deletions(-)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings
  2020-03-17  9:39 ` [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings Lubomir Rintel
  2020-03-17 13:54   ` Andrew Lunn
@ 2020-03-27 19:06   ` Rob Herring
  1 sibling, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:06 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, 17 Mar 2020 10:39:09 +0100, Lubomir Rintel wrote:
> Add compatible strings for the boards we have in tree. At the same time,
> fix the MMP3 compatible string: the preferred vendor name for Marvell is
> "marvell", not "mrvl", and indeed "marvell,mmp3" has been actively used,
> not "mrvl,mmp3".
> 
> Fixes: 95aecb71b84e ("dt-bindings: arm: mrvl: Document MMP3 compatible string")
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  Documentation/devicetree/bindings/arm/mrvl/mrvl.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 16/28] dt-bindings: Add "mrvl", a legacy vendor prefix for Marvell
  2020-03-17  9:39 ` [PATCH 16/28] dt-bindings: Add "mrvl", a legacy vendor prefix for Marvell Lubomir Rintel
@ 2020-03-27 19:06   ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:06 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, 17 Mar 2020 10:39:10 +0100, Lubomir Rintel wrote:
> While the preferred vendor prefix is "marvell", "mrvl" is used by many
> older bindings already. Add it, while also marking it deprecated.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example
       [not found]     ` <20200317093922.20785-18-lkundrak-NGH9Lh4a5iE@public.gmane.org>
@ 2020-03-27 19:08       ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:08 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree-u79uwXL29TZNg+MwTxZMZA

On Tue, Mar 17, 2020 at 10:39:11AM +0100, Lubomir Rintel wrote:
> This way the validator can know that the two cells constitute a singlej
> pair of clock phase degrees value, not separate items Otherwise it is
> unhappy:
> 
>   mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:0:
>       [63] is too short
>   mmc-controller.example.dt.yaml: mmc@ab000000: clk-phase-sd-hs:1:
>       [72] is too short

I'm going to fix this in the tools to allow either form. 

> 
> Signed-off-by: Lubomir Rintel <lkundrak-NGH9Lh4a5iE@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 8fded83c519ad..c9384ed685b8f 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -363,7 +363,7 @@ examples:
>          keep-power-in-suspend;
>          wakeup-source;
>          mmc-pwrseq = <&sdhci0_pwrseq>;
> -        clk-phase-sd-hs = <63>, <72>;
> +        clk-phase-sd-hs = <63 72>;
>      };
>  
>    - |
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema
  2020-03-17  9:39   ` [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema Lubomir Rintel
@ 2020-03-27 19:09     ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:09 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, 17 Mar 2020 10:39:14 +0100, Lubomir Rintel wrote:
> A rather straightforward conversion of the phy-mmp3-usb binding to DT
> schema format using json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../bindings/phy/marvell,mmp3-usb-phy.yaml    | 40 +++++++++++++++++++
>  .../devicetree/bindings/phy/phy-mmp3-usb.txt  | 13 ------
>  2 files changed, 40 insertions(+), 13 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/phy/marvell,mmp3-usb-phy.yaml
>  delete mode 100644 Documentation/devicetree/bindings/phy/phy-mmp3-usb.txt
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema
  2020-03-17  9:39 ` [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio " Lubomir Rintel
  2020-03-27 10:04   ` Linus Walleij
@ 2020-03-27 19:28   ` Rob Herring
  2020-05-17 19:00     ` Lubomir Rintel
  1 sibling, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:28 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:15AM +0100, Lubomir Rintel wrote:
> This converts the mrvl-gpio binding to DT schema format using json-schema.
> 
> Various fixes were done during the conversion, such as adding more
> properties that are in fact mandatory or extending the examples to
> include child nodes with extra GPIO blocks.

Ugg, not how I would have done this. Differences in register layout 
should be implied by the compatible strings. But I guess we have to live 
with it now.

> The compatible strings are a mess. It is not clear why so many of them
> are needed; the driver doesn't really seem to differentiate between the
> models. Some of them, like marvell,pxa93x-gpio and marvell,pxa1928-gpio
> are not used at all, so it's not known how many interrupts they utilize.
> On the other hand, mrvl,pxa-gpio has been seen in the tree, but it
> doesn't end up in any actual DTB file.

I added pxa1928 and then work on it ended. I think it is safe to remove, 
but I dug up dts file and it is 1 irq.

> In any case -- the schema merely copies whatever was in the original
> binding document, so it's hopefully no more wrong that the original.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/gpio/mrvl-gpio.txt    |  48 -----
>  .../devicetree/bindings/gpio/mrvl-gpio.yaml   | 173 ++++++++++++++++++
>  2 files changed, 173 insertions(+), 48 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
>  create mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt b/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
> deleted file mode 100644
> index 30fd2201b3d4c..0000000000000
> --- a/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
> +++ /dev/null
> @@ -1,48 +0,0 @@
> -* Marvell PXA GPIO controller
> -
> -Required properties:
> -- compatible : Should be "intel,pxa25x-gpio", "intel,pxa26x-gpio",
> -		"intel,pxa27x-gpio", "intel,pxa3xx-gpio",
> -		"marvell,pxa93x-gpio", "marvell,mmp-gpio",
> -		"marvell,mmp2-gpio" or marvell,pxa1928-gpio.
> -- reg : Address and length of the register set for the device
> -- interrupts : Should be the port interrupt shared by all gpio pins.
> -  There're three gpio interrupts in arch-pxa, and they're gpio0,
> -  gpio1 and gpio_mux. There're only one gpio interrupt in arch-mmp,
> -  gpio_mux.
> -- interrupt-names : Should be the names of irq resources. Each interrupt
> -  uses its own interrupt name, so there should be as many interrupt names
> -  as referenced interrupts.
> -- interrupt-controller : Identifies the node as an interrupt controller.
> -- #interrupt-cells: Specifies the number of cells needed to encode an
> -  interrupt source.
> -- gpio-controller : Marks the device node as a gpio controller.
> -- #gpio-cells : Should be two.  The first cell is the pin number and
> -  the second cell is used to specify flags. See gpio.txt for possible
> -  values.
> -
> -Example for a MMP platform:
> -
> -	gpio: gpio@d4019000 {
> -		compatible = "marvell,mmp-gpio";
> -		reg = <0xd4019000 0x1000>;
> -		interrupts = <49>;
> -		interrupt-names = "gpio_mux";
> -		gpio-controller;
> -		#gpio-cells = <2>;
> -		interrupt-controller;
> -		#interrupt-cells = <1>;
> -      };
> -
> -Example for a PXA3xx platform:
> -
> -	gpio: gpio@40e00000 {
> -		compatible = "intel,pxa3xx-gpio";
> -		reg = <0x40e00000 0x10000>;
> -		interrupt-names = "gpio0", "gpio1", "gpio_mux";
> -		interrupts = <8 9 10>;
> -		gpio-controller;
> -		#gpio-cells = <0x2>;
> -		interrupt-controller;
> -		#interrupt-cells = <0x2>;
> -	};
> diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> new file mode 100644
> index 0000000000000..5c713bf59b06d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> @@ -0,0 +1,173 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/mrvl-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA GPIO controller
> +
> +maintainers:
> +  - devicetree@vger.kernel.org

Needs to be a real person that cares about this h/w.

> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - intel,pxa25x-gpio
> +              - intel,pxa26x-gpio
> +              - intel,pxa27x-gpio
> +              - intel,pxa3xx-gpio
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 3
> +          maxItems: 3
> +        interrupt-names:
> +          items:
> +            - const: gpio0
> +            - const: gpio1
> +            - const: gpio_mux
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - marvell,mmp-gpio
> +              - marvell,mmp2-gpio

I'd make this an else clause.

> +    then:
> +      properties:
> +        interrupts:
> +          maxItems: 1
> +        interrupt-names:
> +          items:
> +            - const: gpio_mux
> +
> +properties:
> +  $nodename:
> +    pattern: '^gpio@[0-9a-f]+$'
> +
> +  compatible:
> +    enum:
> +      - intel,pxa25x-gpio
> +      - intel,pxa26x-gpio
> +      - intel,pxa27x-gpio
> +      - intel,pxa3xx-gpio
> +      - marvell,mmp-gpio
> +      - marvell,mmp2-gpio
> +      - marvell,pxa93x-gpio
> +      - marvell,pxa1928-gpio
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  ranges: true
> +
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  gpio-ranges:
> +    maxItems: 1

My pxa1928 dts has this in the child nodes. Sure this is right?

> +
> +  interrupts: true
> +
> +  interrupt-names: true
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 2
> +
> +patternProperties:
> +  '^gpio@[0-9a-f]*$':
> +    type: object
> +    properties:
> +      reg:
> +        maxItems: 1
> +
> +    required:
> +      - reg
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - '#address-cells'
> +  - '#size-cells'
> +  - reg
> +  - gpio-controller
> +  - '#gpio-cells'
> +  - interrupts
> +  - interrupt-names
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +  - ranges
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/pxa-clock.h>
> +    gpio@40e00000 {
> +        compatible = "intel,pxa3xx-gpio";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        reg = <0x40e00000 0x10000>;
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +        interrupts = <8>, <9>, <10>;
> +        interrupt-names = "gpio0", "gpio1", "gpio_mux";
> +        clocks = <&clks CLK_GPIO>;
> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +        ranges;

No child, so there should be no ranges here.

> +    };
> +  - |
> +    #include <dt-bindings/clock/marvell,pxa910.h>
> +    gpio@d4019000 {
> +        compatible = "marvell,mmp-gpio";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        reg = <0xd4019000 0x1000>;
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +        interrupts = <49>;
> +        interrupt-names = "gpio_mux";
> +        clocks = <&soc_clocks PXA910_CLK_GPIO>;
> +        resets = <&soc_clocks PXA910_CLK_GPIO>;
> +        interrupt-controller;
> +        #interrupt-cells = <2>;
> +        ranges;
> +
> +        gpio@d4019000 {
> +            reg = <0xd4019000 0x4>;
> +        };
> +
> +        gpio@d4019004 {
> +            reg = <0xd4019004 0x4>;
> +        };
> +
> +        gpio@d4019008 {
> +            reg = <0xd4019008 0x4>;
> +        };
> +
> +        gpio@d4019100 {
> +            reg = <0xd4019100 0x4>;
> +        };
> +     };
> +
> +...
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema
  2020-03-27 10:04   ` Linus Walleij
@ 2020-03-27 19:29     ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:29 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Lubomir Rintel, Robert Jarzmik, Bartosz Golaszewski,
	Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Mauro Carvalho Chehab, Ulf Hansson, Kishon Vijay Abraham I,
	Alessandro Zummo, Alexandre Belloni, Greg Kroah-Hartman,
	Mark Brown, Daniel Lezcano, Andrew Lunn, Gregory Clement,
	Daniel Mack, Haojian Zhuang, OPEN

On Fri, Mar 27, 2020 at 11:04:00AM +0100, Linus Walleij wrote:
> Hi Lubomir!
> 
> Excellent work! Just nitpicks:
> 
> On Tue, Mar 17, 2020 at 10:40 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
> 
> > +++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> > @@ -0,0 +1,173 @@
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/mrvl-gpio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell PXA GPIO controller
> 
> This binding is lacking a license. Please use the dual GPL+BSD license
> tag.

That is preferred, but should only be dual if you have rights on the old 
binding file or get relicensing permissions.

> 
> > +maintainers:
> > +  - devicetree@vger.kernel.org
> 
> I don't know if Robert Jarzmik is in on maintaining this, would you accept
> it Robert?
> 
> Yours,
> Linus Walleij

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc to json-schema
  2020-03-17  9:39 ` [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc " Lubomir Rintel
@ 2020-03-27 19:42   ` Rob Herring
  2020-05-17 19:11     ` Lubomir Rintel
  0 siblings, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:42 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:17AM +0100, Lubomir Rintel wrote:
> Convert the mrvl,intc binding to DT schema format using json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../interrupt-controller/mrvl,intc.txt        |  64 --------
>  .../interrupt-controller/mrvl,intc.yaml       | 144 ++++++++++++++++++
>  2 files changed, 144 insertions(+), 64 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
> deleted file mode 100644
> index a0ed02725a9d7..0000000000000
> --- a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
> +++ /dev/null
> @@ -1,64 +0,0 @@
> -* Marvell MMP Interrupt controller
> -
> -Required properties:
> -- compatible : Should be
> -               "mrvl,mmp-intc" on Marvel MMP,
> -               "mrvl,mmp2-intc" along with "mrvl,mmp2-mux-intc" on MMP2 or
> -               "marvell,mmp3-intc" with "mrvl,mmp2-mux-intc" on MMP3
> -- reg : Address and length of the register set of the interrupt controller.
> -  If the interrupt controller is intc, address and length means the range
> -  of the whole interrupt controller. The "marvell,mmp3-intc" controller
> -  also has a secondary range for the second CPU core.  If the interrupt
> -  controller is mux-intc, address and length means one register. Since
> -  address of mux-intc is in the range of intc. mux-intc is secondary
> -  interrupt controller.
> -- reg-names : Name of the register set of the interrupt controller. It's
> -  only required in mux-intc interrupt controller.
> -- interrupts : Should be the port interrupt shared by mux interrupts. It's
> -  only required in mux-intc interrupt controller.
> -- interrupt-controller : Identifies the node as an interrupt controller.
> -- #interrupt-cells : Specifies the number of cells needed to encode an
> -  interrupt source.
> -- mrvl,intc-nr-irqs : Specifies the number of interrupts in the interrupt
> -  controller.
> -- mrvl,clr-mfp-irq : Specifies the interrupt that needs to clear MFP edge
> -  detection first.
> -
> -Example:
> -	intc: interrupt-controller@d4282000 {
> -		compatible = "mrvl,mmp2-intc";
> -		interrupt-controller;
> -		#interrupt-cells = <1>;
> -		reg = <0xd4282000 0x1000>;
> -		mrvl,intc-nr-irqs = <64>;
> -	};
> -
> -	intcmux4@d4282150 {
> -		compatible = "mrvl,mmp2-mux-intc";
> -		interrupts = <4>;
> -		interrupt-controller;
> -		#interrupt-cells = <1>;
> -		reg = <0x150 0x4>, <0x168 0x4>;
> -		reg-names = "mux status", "mux mask";
> -		mrvl,intc-nr-irqs = <2>;
> -	};
> -
> -* Marvell Orion Interrupt controller
> -
> -Required properties
> -- compatible :  Should be "marvell,orion-intc".
> -- #interrupt-cells: Specifies the number of cells needed to encode an
> -  interrupt source. Supported value is <1>.
> -- interrupt-controller : Declare this node to be an interrupt controller.
> -- reg : Interrupt mask address. A list of 4 byte ranges, one per controller.
> -        One entry in the list represents 32 interrupts.
> -
> -Example:
> -
> -	intc: interrupt-controller {
> -        	compatible = "marvell,orion-intc", "marvell,intc";
> -		interrupt-controller;
> -		#interrupt-cells = <1>;
> -                reg = <0xfed20204 0x04>,
> -		      <0xfed20214 0x04>;
> -        };
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
> new file mode 100644
> index 0000000000000..f0644f7d7e1d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
> @@ -0,0 +1,144 @@
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/mrvl,intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MMP/Orion Interrupt controller bindings
> +
> +maintainers:
> +  - devicetree@vger.kernel.org
> +
> +allOf:
> +  - $ref: /schemas/interrupt-controller.yaml#

Drop this. It is already applied based on matching on the node name.

> +  - if:
> +      properties:
> +        compatible:
> +          not:
> +            contains:
> +              const: marvell,orion-intc
> +    then:
> +      required:
> +        - mrvl,intc-nr-irqs
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mrvl,mmp-intc
> +              - mrvl,mmp2-intc
> +    then:
> +      properties:
> +        reg:
> +          minItems: 1
> +          maxItems: 1

Drop minItems, as just 'maxItems: 1' is enough.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - marvell,mmp3-intc
> +              - mrvl,mmp2-mux-intc
> +    then:
> +      properties:
> +        reg:
> +          minItems: 2
> +          maxItems: 2

Just 'minItems: 2'.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: marvell,orion-intc
> +    then:
> +      properties:
> +        reg:
> +          minItems: 1
> +          maxItems: 2

Normally, for a compatible this would not vary...

In any case, move this to the main section and drop this if.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: mrvl,mmp2-mux-intc
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 1
> +          maxItems: 1

Just 'maxItems'

> +        reg-names:
> +          minItems: 2
> +          maxItems: 2

These are redundant as 'items' size implies this.

> +          items:
> +            - const: 'mux status'
> +            - const: 'mux mask'

Move this to the main section.

> +      required:
> +        - interrupts
> +    else:
> +      properties:
> +        interrupts: false
> +
> +properties:
> +  '#interrupt-cells':
> +    const: 1
> +
> +  compatible:
> +    enum:
> +      - mrvl,mmp-intc
> +      - mrvl,mmp2-intc
> +      - marvell,mmp3-intc
> +      - marvell,orion-intc
> +      - mrvl,mmp2-mux-intc
> +
> +  reg: true
> +
> +  reg-names: true
> +
> +  interrupts: true
> +
> +  interrupt-controller: true
> +
> +  mrvl,intc-nr-irqs:
> +    description: |
> +      Specifies the number of interrupts in the interrupt controller.
> +    $ref: /schemas/types.yaml#/definitions/uint32

Is there a max number?

> +
> +  mrvl,clr-mfp-irq:
> +    description: |
> +      Specifies the interrupt that needs to clear MFP edge detection first.
> +    $ref: /schemas/types.yaml#/definitions/uint32

Constraints?

> +
> +required:
> +  - '#interrupt-cells'
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    interrupt-controller@d4282000 {
> +        compatible = "mrvl,mmp2-intc";
> +        interrupt-controller;
> +        #interrupt-cells = <1>;
> +        reg = <0xd4282000 0x1000>;
> +        mrvl,intc-nr-irqs = <64>;
> +    };
> +
> +    interrupt-controller@d4282150 {
> +        compatible = "mrvl,mmp2-mux-intc";
> +        interrupts = <4>;
> +        interrupt-controller;
> +        #interrupt-cells = <1>;
> +        reg = <0x150 0x4>, <0x168 0x4>;
> +        reg-names = "mux status", "mux mask";
> +        mrvl,intc-nr-irqs = <2>;
> +    };
> +  - |
> +    interrupt-controller@fed20204 {
> +        compatible = "marvell,orion-intc";
> +        interrupt-controller;
> +        #interrupt-cells = <1>;
> +        reg = <0xfed20204 0x04>,
> +              <0xfed20214 0x04>;
> +    };
> +
> +...
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic to json-schema
  2020-03-17  9:39 ` [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic " Lubomir Rintel
@ 2020-03-27 19:46   ` Rob Herring
  2020-05-17 19:21     ` Lubomir Rintel
  0 siblings, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:46 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:18AM +0100, Lubomir Rintel wrote:
> Convert the marvell,mmp2-ccic binding to DT schema format using
> json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../bindings/media/marvell,mmp2-ccic.txt      |  50 ---------
>  .../bindings/media/marvell,mmp2-ccic.yaml     | 102 ++++++++++++++++++
>  2 files changed, 102 insertions(+), 50 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
>  create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> deleted file mode 100644
> index 7ec2c8c8a3b98..0000000000000
> --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> +++ /dev/null
> @@ -1,50 +0,0 @@
> -Marvell MMP2 camera host interface
> -
> -Required properties:
> - - compatible: Should be "marvell,mmp2-ccic".
> - - reg: Register base and size.
> - - interrupts: The interrupt number.
> - - #clock-cells: Must be 0.
> -
> -Optional properties:
> - - clocks: Reference to the input clock as specified by
> -           Documentation/devicetree/bindings/clock/clock-bindings.txt.
> - - clock-names: Names of the clocks used; "axi" for the AXI bus interface,
> -                "func" for the peripheral clock and "phy" for the parallel
> -                video bus interface.
> - - clock-output-names: Optional clock source for sensors. Shall be "mclk".
> -
> -Required subnodes:
> - - port: The parallel bus interface port with a single endpoint linked to
> -         the sensor's endpoint as described in
> -         Documentation/devicetree/bindings/media/video-interfaces.txt.
> -
> -Required endpoint properties:
> - - bus-type: data bus type, <5> or <6> for Parallel or Bt.656 respectively
> - - pclk-sample: pixel clock polarity
> - - hsync-active: horizontal synchronization polarity (only required for
> -   parallel bus)
> - - vsync-active: vertical synchronization polarity (only required for
> -   parallel bus)
> -
> -Example:
> -
> -	camera0: camera@d420a000 {
> -		compatible = "marvell,mmp2-ccic";
> -		reg = <0xd420a000 0x800>;
> -		interrupts = <42>;
> -		clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> -		clock-names = "axi";
> -		#clock-cells = <0>;
> -		clock-output-names = "mclk";
> -
> -		port {
> -			camera0_0: endpoint {
> -				remote-endpoint = <&ov7670_0>;
> -                                bus-type = <5>;      /* Parallel */
> -                                hsync-active = <1>;  /* Active high */
> -                                vsync-active = <1>;  /* Active high */
> -                                pclk-sample = <0>;   /* Falling */
> -			};
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> new file mode 100644
> index 0000000000000..890a3f9d0302f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> @@ -0,0 +1,102 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)

GPL-2.0-only please. Dual license only if you have rights on the old 
file to do so.

> +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/marvell,mmp2-ccic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MMP2 camera host interface bindings
> +
> +maintainers:
> +  - Lubomir Rintel <lkundrak@v3.sk>
> +
> +properties:
> +  $nodename:
> +    pattern: '^camera@[a-f0-9]+$'
> +
> +  compatible:
> +    const: marvell,mmp2-ccic
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  port:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +       endpoint:

Wrong indentaion.

> +         type: object
> +         additionalProperties: false
> +
> +         # Properties described in
> +         # Documentation/devicetree/bindings/media/video-interfaces.txt
> +         properties:
> +           remote-endpoint: true
> +           hsync-active: true
> +           vsync-active: true
> +           pclk-sample: true
> +           bus-type: true
> +
> +         required:
> +           - remote-endpoint
> +
> +    required:
> +      - endpoint
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 3

Shouldn't really be variable for a single compatible.

> +    items:
> +      - description: AXI bus interface clock
> +      - description: Peripheral clock
> +      - description: Parallel video bus interface clock
> +
> +  clock-names:
> +    minItems: 1
> +    maxItems: 3
> +    items:
> +      - const: axi
> +      - const: func
> +      - const: phy
> +
> +  '#clock-cells':
> +    const: 0
> +
> +  clock-output-names:
> +    const: mclk
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - port
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/marvell,mmp2.h>
> +
> +    camera@d420a000 {
> +      compatible = "marvell,mmp2-ccic";
> +      reg = <0xd420a000 0x800>;
> +      interrupts = <42>;
> +      clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> +      clock-names = "axi";
> +      #clock-cells = <0>;
> +      clock-output-names = "mclk";
> +
> +      port {
> +        camera0_0: endpoint {
> +          remote-endpoint = <&ov7670_0>;
> +          bus-type = <5>;      /* Parallel */
> +          hsync-active = <1>;  /* Active high */
> +          vsync-active = <1>;  /* Active high */
> +          pclk-sample = <0>;   /* Falling */
> +        };
> +      };
> +    };
> +
> +...
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc to json-schema
  2020-03-17  9:39 ` [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc " Lubomir Rintel
@ 2020-03-27 19:49   ` Rob Herring
  2020-05-17 19:25     ` Lubomir Rintel
  0 siblings, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:49 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:19AM +0100, Lubomir Rintel wrote:
> Convert the sa1100-rtc binding to DT schema format using json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/rtc/sa1100-rtc.txt    | 17 ------
>  .../devicetree/bindings/rtc/sa1100-rtc.yaml   | 55 +++++++++++++++++++
>  2 files changed, 55 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
>  create mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt b/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> deleted file mode 100644
> index 968ac820254bb..0000000000000
> --- a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -* Marvell Real Time Clock controller
> -
> -Required properties:
> -- compatible: should be "mrvl,sa1100-rtc"
> -- reg: physical base address of the controller and length of memory mapped
> -  region.
> -- interrupts: Should be two. The first interrupt number is the rtc alarm
> -  interrupt and the second interrupt number is the rtc hz interrupt.
> -- interrupt-names: Assign name of irq resource.
> -
> -Example:
> -	rtc: rtc@d4010000 {
> -		compatible = "mrvl,mmp-rtc";
> -		reg = <0xd4010000 0x1000>;
> -		interrupts = <5>, <6>;
> -		interrupt-names = "rtc 1Hz", "rtc alarm";
> -	};
> diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> new file mode 100644
> index 0000000000000..53a8b72df9f34
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> @@ -0,0 +1,55 @@

License

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/sa1100-rtc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell Real Time Clock controller bindings
> +
> +allOf:
> +  - $ref: rtc.yaml#
> +
> +maintainers:
> +  - devicetree@vger.kernel.org

Real person

> +
> +properties:
> +  compatible:
> +    enum:
> +      - mrvl,sa1100-rtc
> +      - mrvl,mmp-rtc
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1

clocks and resets weren't documented before. Fine to add here, but add 
that to the commit msg.

> +
> +  interrupts:
> +    minItems: 2
> +    maxItems: 2

Drop minItems.

> +
> +  interrupt-names:
> +    items:
> +      - const: 'rtc 1Hz'
> +      - const: 'rtc alarm'
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    rtc: rtc@d4010000 {
> +        compatible = "mrvl,mmp-rtc";
> +        reg = <0xd4010000 0x1000>;
> +        interrupts = <5>, <6>;
> +        interrupt-names = "rtc 1Hz", "rtc alarm";
> +    };
> +
> +...
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema
  2020-03-17  9:39 ` [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx " Lubomir Rintel
@ 2020-03-27 19:52   ` Rob Herring
  2020-05-17 19:30     ` Lubomir Rintel
  0 siblings, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:52 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:20AM +0100, Lubomir Rintel wrote:
> A straightforward conversion of the the spi-pxa2xx binding to DT schema
> format using json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../bindings/spi/marvell,mmp2-ssp.yaml        | 58 +++++++++++++++++++
>  .../devicetree/bindings/spi/spi-pxa2xx.txt    | 27 ---------
>  2 files changed, 58 insertions(+), 27 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
>  delete mode 100644 Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> new file mode 100644
> index 0000000000000..de6b6a53b70d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)

Same issue on license...

> +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/marvell,mmp2-ssp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PXA2xx SSP SPI Controller bindings
> +
> +maintainers:
> +  - Lubomir Rintel <lkundrak@v3.sk>
> +
> +allOf:
> +  - $ref: spi-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: marvell,mmp2-ssp
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  ready-gpios:
> +    description: |
> +      GPIO used to signal a SPI master that the FIFO is filled and we're
> +      ready to service a transfer. Only useful in slave mode.
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks

> +  - '#address-cells'
> +  - '#size-cells'

spi-controller.yaml handles these being required and also that they 
aren't for slave mode.

> +
> +dependencies:
> +  ready-gpios: [ spi-slave ]
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/marvell,mmp2.h>
> +    spi@d4035000 {
> +        compatible = "marvell,mmp2-ssp";
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        reg = <0xd4035000 0x1000>;
> +        clocks = <&soc_clocks MMP2_CLK_SSP0>;
> +        interrupts = <0>;
> +    };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> deleted file mode 100644
> index e30e0c2a4bce1..0000000000000
> --- a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -PXA2xx SSP SPI Controller
> -
> -Required properties:
> -- compatible: Must be "marvell,mmp2-ssp".
> -- reg: Offset and length of the device's register set.
> -- interrupts: Should be the interrupt number.
> -- clocks: Should contain a single entry describing the clock input.
> -- #address-cells:  Number of cells required to define a chip select address.
> -- #size-cells: Should be zero.
> -
> -Optional properties:
> -- cs-gpios: list of GPIO chip selects. See the SPI bus bindings,
> -  Documentation/devicetree/bindings/spi/spi-bus.txt
> -- spi-slave: Empty property indicating the SPI controller is used in slave mode.
> -- ready-gpios: GPIO used to signal a SPI master that the FIFO is filled
> -  and we're ready to service a transfer. Only useful in slave mode.
> -
> -Child nodes represent devices on the SPI bus
> -  See ../spi/spi-bus.txt
> -
> -Example:
> -	ssp1: spi@d4035000 {
> -		compatible = "marvell,mmp2-ssp";
> -		reg = <0xd4035000 0x1000>;
> -		clocks = <&soc_clocks MMP2_CLK_SSP0>;
> -		interrupts = <0>;
> -	};
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer to json-schema
  2020-03-17  9:39 ` [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer " Lubomir Rintel
@ 2020-03-27 19:53   ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:53 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:21AM +0100, Lubomir Rintel wrote:
> A straightforward conversion of the mrvl,mmp-timer binding to DT schema
> format using json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../bindings/timer/mrvl,mmp-timer.txt         | 17 --------
>  .../bindings/timer/mrvl,mmp-timer.yaml        | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
>  create mode 100644 Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml
> 
> diff --git a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
> deleted file mode 100644
> index b8f02c6635219..0000000000000
> --- a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -* Marvell MMP Timer controller
> -
> -Required properties:
> -- compatible : Should be "mrvl,mmp-timer".
> -- reg : Address and length of the register set of timer controller.
> -- interrupts : Should be the interrupt number.
> -
> -Optional properties:
> -- clocks : Should contain a single entry describing the clock input.
> -
> -Example:
> -	timer0: timer@d4014000 {
> -		compatible = "mrvl,mmp-timer";
> -		reg = <0xd4014000 0x100>;
> -		interrupts = <13>;
> -		clocks = <&coreclk 2>;
> -	};
> diff --git a/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml
> new file mode 100644
> index 0000000000000..ebee0b862d493
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/mrvl,mmp-timer.yaml
> @@ -0,0 +1,43 @@

License?

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/mrvl,mmp-timer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell MMP Timer bindings
> +
> +maintainers:
> +  - devicetree@vger.kernel.org

Real person?

> +
> +properties:
> +  $nodename:
> +    pattern: '^timer@[a-f0-9]+$'
> +
> +  compatible:
> +    const: mrvl,mmp-timer
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    timer@d4014000 {
> +        compatible = "mrvl,mmp-timer";
> +        reg = <0xd4014000 0x100>;
> +        interrupts = <13>;
> +        clocks = <&coreclk 2>;
> +    };
> +
> +...
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema
  2020-03-17  9:39 ` [PATCH 28/28] dt-bindings: usb: Convert ehci-mv " Lubomir Rintel
@ 2020-03-27 19:55   ` Rob Herring
  2020-05-17 19:34     ` Lubomir Rintel
  0 siblings, 1 reply; 81+ messages in thread
From: Rob Herring @ 2020-03-27 19:55 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree

On Tue, Mar 17, 2020 at 10:39:22AM +0100, Lubomir Rintel wrote:
> A straightforward conversion of the ehci-mv binding to DT schema format
> using json-schema.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
>  .../devicetree/bindings/usb/ehci-mv.txt       | 23 -------
>  .../bindings/usb/marvell,pxau2o-ehci.yaml     | 60 +++++++++++++++++++
>  2 files changed, 60 insertions(+), 23 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/usb/ehci-mv.txt
>  create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> 
> diff --git a/Documentation/devicetree/bindings/usb/ehci-mv.txt b/Documentation/devicetree/bindings/usb/ehci-mv.txt
> deleted file mode 100644
> index 335589895763e..0000000000000
> --- a/Documentation/devicetree/bindings/usb/ehci-mv.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -* Marvell PXA/MMP EHCI controller.
> -
> -Required properties:
> -
> -- compatible: must be "marvell,pxau2o-ehci"
> -- reg: physical base addresses of the controller and length of memory mapped region
> -- interrupts: one EHCI controller interrupt should be described here
> -- clocks: phandle list of usb clocks
> -- clock-names: should be "USBCLK"
> -- phys: phandle for the PHY device
> -- phy-names: should be "usb"
> -
> -Example:
> -
> -	ehci0: usb-ehci@d4208000 {
> -		compatible = "marvell,pxau2o-ehci";
> -		reg = <0xd4208000 0x200>;
> -		interrupts = <44>;
> -		clocks = <&soc_clocks MMP2_CLK_USB>;
> -		clock-names = "USBCLK";
> -		phys = <&usb_otg_phy>;
> -		phy-names = "usb";
> -	};
> diff --git a/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> new file mode 100644
> index 0000000000000..189025ef1e92e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)

Same license comment.

> +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/marvell,pxau2o-ehci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA/MMP EHCI bindings
> +
> +maintainers:
> +  - Lubomir Rintel <lkundrak@v3.sk>
> +
> +allOf:
> +  - $ref: usb-hcd.yaml#
> +
> +properties:
> +  compatible:
> +    const: marvell,pxau2o-ehci
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: USBCLK
> +
> +  phys:
> +    maxItems: 1
> +
> +  phy-names:
> +    const: usb
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - phys
> +  - phy-names
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/marvell,mmp2.h>
> +    usb@d4208000 {
> +        compatible = "marvell,pxau2o-ehci";
> +        reg = <0xd4208000 0x200>;
> +        interrupts = <44>;
> +        clocks = <&soc_clocks MMP2_CLK_USB>;
> +        clock-names = "USBCLK";
> +        phys = <&usb_otg_phy>;
> +        phy-names = "usb";
> +    };
> +
> +...
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema
  2020-03-18 22:37   ` Rob Herring
@ 2020-05-17 18:35     ` Lubomir Rintel
  0 siblings, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-05-17 18:35 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, open list:GPIO SUBSYSTEM, Linux I2C,
	Linux Media Mailing List, linux-mmc,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
	open list:SERIAL DRIVERS, linux-spi, Linux USB List

On Wed, Mar 18, 2020 at 04:37:55PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 3:40 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
> >
> > Convert the sdhci-pxa binding to DT schema format using json-schema.
> 
> Ignore what my bot said, I see you addressed that earlier in the series.
> 
> > At the same time, fix a couple of issues with the examples discovered by
> > the validation tool -- a semicolon instead of a comma and wrong node names.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  .../devicetree/bindings/mmc/sdhci-pxa.txt     |  50 ---------
> >  .../devicetree/bindings/mmc/sdhci-pxa.yaml    | 101 ++++++++++++++++++
> >  2 files changed, 101 insertions(+), 50 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
> >  create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt b/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
> > deleted file mode 100644
> > index 3d1b449d6097d..0000000000000
> > --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.txt
> > +++ /dev/null
> > @@ -1,50 +0,0 @@
> > -* Marvell sdhci-pxa v2/v3 controller
> > -
> > -This file documents differences between the core properties in mmc.txt
> > -and the properties used by the sdhci-pxav2 and sdhci-pxav3 drivers.
> > -
> > -Required properties:
> > -- compatible: Should be "mrvl,pxav2-mmc", "mrvl,pxav3-mmc" or
> > -  "marvell,armada-380-sdhci".
> > -- reg:
> > -  * for "mrvl,pxav2-mmc" and "mrvl,pxav3-mmc", one register area for
> > -    the SDHCI registers.
> > -
> > -  * for "marvell,armada-380-sdhci", three register areas. The first
> > -    one for the SDHCI registers themselves, the second one for the
> > -    AXI/Mbus bridge registers of the SDHCI unit, the third one for the
> > -    SDIO3 Configuration register
> > -- reg names: should be "sdhci", "mbus", "conf-sdio3". only mandatory
> > -  for "marvell,armada-380-sdhci"
> > -- clocks: Array of clocks required for SDHCI; requires at least one for
> > -    I/O clock.
> > -- clock-names: Array of names corresponding to clocks property; shall be
> > -    "io" for I/O clock and "core" for optional core clock.
> > -
> > -Optional properties:
> > -- mrvl,clk-delay-cycles: Specify a number of cycles to delay for tuning.
> > -
> > -Example:
> > -
> > -sdhci@d4280800 {
> > -       compatible = "mrvl,pxav3-mmc";
> > -       reg = <0xd4280800 0x800>;
> > -       bus-width = <8>;
> > -       interrupts = <27>;
> > -       clocks = <&chip CLKID_SDIO1XIN>, <&chip CLKID_SDIO1>;
> > -       clock-names = "io", "core";
> > -       non-removable;
> > -       mrvl,clk-delay-cycles = <31>;
> > -};
> > -
> > -sdhci@d8000 {
> > -       compatible = "marvell,armada-380-sdhci";
> > -       reg-names = "sdhci", "mbus", "conf-sdio3";
> > -       reg = <0xd8000 0x1000>,
> > -               <0xdc000 0x100>;
> > -               <0x18454 0x4>;
> > -       interrupts = <0 25 0x4>;
> > -       clocks = <&gateclk 17>;
> > -       clock-names = "io";
> > -       mrvl,clk-delay-cycles = <0x1F>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> > new file mode 100644
> > index 0000000000000..4ae0926ac294f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml
> > @@ -0,0 +1,101 @@
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell PXA SDHCI v2/v3 bindings
> > +
> > +maintainers:
> > +  - devicetree@vger.kernel.org
> > +
> > +allOf:
> > +  - $ref: mmc-controller.yaml#
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: marvell,armada-380-sdhci
> > +    then:
> > +      properties:
> > +        regs:
> > +          minItems: 3
> > +          maxItems: 3
> 
> Here, you just need minItems.
> 
> > +        reg-names:
> > +          items:
> > +            - const: sdhci
> > +            - const: mbus
> > +            - const: conf-sdio3
> 
> This should be under the main definition of 'reg-names' and then just
> 'minItems: 3' here.
> 
> > +      required:
> > +        - reg-names
> > +    else:
> > +      properties:
> > +        regs:
> > +          minItems: 1
> > +          maxItems: 1
> 
> Just 'maxItems' is sufficient.
> 
> > +        reg-names:
> > +          minItems: 1
> > +          maxItems: 1
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - mrvl,pxav2-mmc
> > +      - mrvl,pxav3-mmc
> > +      - marvell,armada-380-sdhci
> > +
> > +  reg: true
> 
> Here you should have:
> 
> minItems: 1
> maxItems: 3
> 
> > +
> > +  reg-names: true
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    minItems: 1
> > +    maxItems: 2
> > +
> > +  clock-names:
> > +    minItems: 1
> > +    maxItems: 2
> > +    items:
> > +      - const: io
> > +      - const: core
> > +
> > +  mrvl,clk-delay-cycles:
> > +    description: Specify a number of cycles to delay for tuning.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> No range of valid values?

No. The document I'm converting didn't specify a range. For some of the
hardware supported Marvell doesn't provide documentation, and the
drivers that use this seem to accept any u32 number.

If this needs a range, then I need to make something up. I can do that,
but it will be difficult to defend that number if anyone asks.

Lubo

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio to json-schema
  2020-03-27 19:28   ` Rob Herring
@ 2020-05-17 19:00     ` Lubomir Rintel
  0 siblings, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-05-17 19:00 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, linux-gpio, linux-i2c, linux-media,
	linux-mmc, linux-rtc, linux-serial, linux-spi, linux-usb

On Fri, Mar 27, 2020 at 01:28:20PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:15AM +0100, Lubomir Rintel wrote:
> > This converts the mrvl-gpio binding to DT schema format using json-schema.
> > 
> > Various fixes were done during the conversion, such as adding more
> > properties that are in fact mandatory or extending the examples to
> > include child nodes with extra GPIO blocks.
> 
> Ugg, not how I would have done this. Differences in register layout 
> should be implied by the compatible strings. But I guess we have to live 
> with it now.
> 
> > The compatible strings are a mess. It is not clear why so many of them
> > are needed; the driver doesn't really seem to differentiate between the
> > models. Some of them, like marvell,pxa93x-gpio and marvell,pxa1928-gpio
> > are not used at all, so it's not known how many interrupts they utilize.
> > On the other hand, mrvl,pxa-gpio has been seen in the tree, but it
> > doesn't end up in any actual DTB file.
> 
> I added pxa1928 and then work on it ended. I think it is safe to remove, 
> but I dug up dts file and it is 1 irq.
> 
> > In any case -- the schema merely copies whatever was in the original
> > binding document, so it's hopefully no more wrong that the original.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  .../devicetree/bindings/gpio/mrvl-gpio.txt    |  48 -----
> >  .../devicetree/bindings/gpio/mrvl-gpio.yaml   | 173 ++++++++++++++++++
> >  2 files changed, 173 insertions(+), 48 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
> >  create mode 100644 Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt b/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
> > deleted file mode 100644
> > index 30fd2201b3d4c..0000000000000
> > --- a/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
> > +++ /dev/null
> > @@ -1,48 +0,0 @@
> > -* Marvell PXA GPIO controller
> > -
> > -Required properties:
> > -- compatible : Should be "intel,pxa25x-gpio", "intel,pxa26x-gpio",
> > -		"intel,pxa27x-gpio", "intel,pxa3xx-gpio",
> > -		"marvell,pxa93x-gpio", "marvell,mmp-gpio",
> > -		"marvell,mmp2-gpio" or marvell,pxa1928-gpio.
> > -- reg : Address and length of the register set for the device
> > -- interrupts : Should be the port interrupt shared by all gpio pins.
> > -  There're three gpio interrupts in arch-pxa, and they're gpio0,
> > -  gpio1 and gpio_mux. There're only one gpio interrupt in arch-mmp,
> > -  gpio_mux.
> > -- interrupt-names : Should be the names of irq resources. Each interrupt
> > -  uses its own interrupt name, so there should be as many interrupt names
> > -  as referenced interrupts.
> > -- interrupt-controller : Identifies the node as an interrupt controller.
> > -- #interrupt-cells: Specifies the number of cells needed to encode an
> > -  interrupt source.
> > -- gpio-controller : Marks the device node as a gpio controller.
> > -- #gpio-cells : Should be two.  The first cell is the pin number and
> > -  the second cell is used to specify flags. See gpio.txt for possible
> > -  values.
> > -
> > -Example for a MMP platform:
> > -
> > -	gpio: gpio@d4019000 {
> > -		compatible = "marvell,mmp-gpio";
> > -		reg = <0xd4019000 0x1000>;
> > -		interrupts = <49>;
> > -		interrupt-names = "gpio_mux";
> > -		gpio-controller;
> > -		#gpio-cells = <2>;
> > -		interrupt-controller;
> > -		#interrupt-cells = <1>;
> > -      };
> > -
> > -Example for a PXA3xx platform:
> > -
> > -	gpio: gpio@40e00000 {
> > -		compatible = "intel,pxa3xx-gpio";
> > -		reg = <0x40e00000 0x10000>;
> > -		interrupt-names = "gpio0", "gpio1", "gpio_mux";
> > -		interrupts = <8 9 10>;
> > -		gpio-controller;
> > -		#gpio-cells = <0x2>;
> > -		interrupt-controller;
> > -		#interrupt-cells = <0x2>;
> > -	};
> > diff --git a/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> > new file mode 100644
> > index 0000000000000..5c713bf59b06d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/mrvl-gpio.yaml
> > @@ -0,0 +1,173 @@
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gpio/mrvl-gpio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell PXA GPIO controller
> > +
> > +maintainers:
> > +  - devicetree@vger.kernel.org
> 
> Needs to be a real person that cares about this h/w.

As I've said in the cover letter -- it's not clear who would that be.

> > +
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - intel,pxa25x-gpio
> > +              - intel,pxa26x-gpio
> > +              - intel,pxa27x-gpio
> > +              - intel,pxa3xx-gpio
> > +    then:
> > +      properties:
> > +        interrupts:
> > +          minItems: 3
> > +          maxItems: 3
> > +        interrupt-names:
> > +          items:
> > +            - const: gpio0
> > +            - const: gpio1
> > +            - const: gpio_mux
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - marvell,mmp-gpio
> > +              - marvell,mmp2-gpio
> 
> I'd make this an else clause.

This would imply that marvell,pxa93x-gpio has one interrupt and it is
not know whether that is actually the case.

> > +    then:
> > +      properties:
> > +        interrupts:
> > +          maxItems: 1
> > +        interrupt-names:
> > +          items:
> > +            - const: gpio_mux
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: '^gpio@[0-9a-f]+$'
> > +
> > +  compatible:
> > +    enum:
> > +      - intel,pxa25x-gpio
> > +      - intel,pxa26x-gpio
> > +      - intel,pxa27x-gpio
> > +      - intel,pxa3xx-gpio
> > +      - marvell,mmp-gpio
> > +      - marvell,mmp2-gpio
> > +      - marvell,pxa93x-gpio
> > +      - marvell,pxa1928-gpio
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  resets:
> > +    maxItems: 1
> > +
> > +  ranges: true
> > +
> > +  '#address-cells':
> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 1
> > +
> > +  gpio-controller: true
> > +
> > +  '#gpio-cells':
> > +    const: 2
> > +
> > +  gpio-ranges:
> > +    maxItems: 1
> 
> My pxa1928 dts has this in the child nodes. Sure this is right?

I actually don't know anything about pxa1928. pxa27x.dtsi and
pxa3xx.dtsi specify gpio-ranges on main gpio nodes and have no gcb
child nodes.

> > +
> > +  interrupts: true
> > +
> > +  interrupt-names: true
> > +
> > +  interrupt-controller: true
> > +
> > +  '#interrupt-cells':
> > +    const: 2
> > +
> > +patternProperties:
> > +  '^gpio@[0-9a-f]*$':
> > +    type: object
> > +    properties:
> > +      reg:
> > +        maxItems: 1
> > +
> > +    required:
> > +      - reg
> > +
> > +    additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - '#address-cells'
> > +  - '#size-cells'
> > +  - reg
> > +  - gpio-controller
> > +  - '#gpio-cells'
> > +  - interrupts
> > +  - interrupt-names
> > +  - interrupt-controller
> > +  - '#interrupt-cells'
> > +  - ranges
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/pxa-clock.h>
> > +    gpio@40e00000 {
> > +        compatible = "intel,pxa3xx-gpio";
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +        reg = <0x40e00000 0x10000>;
> > +        gpio-controller;
> > +        #gpio-cells = <2>;
> > +        interrupts = <8>, <9>, <10>;
> > +        interrupt-names = "gpio0", "gpio1", "gpio_mux";
> > +        clocks = <&clks CLK_GPIO>;
> > +        interrupt-controller;
> > +        #interrupt-cells = <2>;
> > +        ranges;
> 
> No child, so there should be no ranges here.

Will fix in next version.

> > +    };
> > +  - |
> > +    #include <dt-bindings/clock/marvell,pxa910.h>
> > +    gpio@d4019000 {
> > +        compatible = "marvell,mmp-gpio";
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +        reg = <0xd4019000 0x1000>;
> > +        gpio-controller;
> > +        #gpio-cells = <2>;
> > +        interrupts = <49>;
> > +        interrupt-names = "gpio_mux";
> > +        clocks = <&soc_clocks PXA910_CLK_GPIO>;
> > +        resets = <&soc_clocks PXA910_CLK_GPIO>;
> > +        interrupt-controller;
> > +        #interrupt-cells = <2>;
> > +        ranges;
> > +
> > +        gpio@d4019000 {
> > +            reg = <0xd4019000 0x4>;
> > +        };
> > +
> > +        gpio@d4019004 {
> > +            reg = <0xd4019004 0x4>;
> > +        };
> > +
> > +        gpio@d4019008 {
> > +            reg = <0xd4019008 0x4>;
> > +        };
> > +
> > +        gpio@d4019100 {
> > +            reg = <0xd4019100 0x4>;
> > +        };
> > +     };
> > +
> > +...
> > -- 
> > 2.25.1
> > 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc to json-schema
  2020-03-27 19:42   ` Rob Herring
@ 2020-05-17 19:11     ` Lubomir Rintel
  0 siblings, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-05-17 19:11 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, linux-gpio, linux-i2c, linux-media,
	linux-mmc, linux-rtc, linux-serial, linux-spi, linux-usb

On Fri, Mar 27, 2020 at 01:42:07PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:17AM +0100, Lubomir Rintel wrote:
> > Convert the mrvl,intc binding to DT schema format using json-schema.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  .../interrupt-controller/mrvl,intc.txt        |  64 --------
> >  .../interrupt-controller/mrvl,intc.yaml       | 144 ++++++++++++++++++
> >  2 files changed, 144 insertions(+), 64 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
> >  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
> > deleted file mode 100644
> > index a0ed02725a9d7..0000000000000
> > --- a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.txt
> > +++ /dev/null
> > @@ -1,64 +0,0 @@
> > -* Marvell MMP Interrupt controller
> > -
> > -Required properties:
> > -- compatible : Should be
> > -               "mrvl,mmp-intc" on Marvel MMP,
> > -               "mrvl,mmp2-intc" along with "mrvl,mmp2-mux-intc" on MMP2 or
> > -               "marvell,mmp3-intc" with "mrvl,mmp2-mux-intc" on MMP3
> > -- reg : Address and length of the register set of the interrupt controller.
> > -  If the interrupt controller is intc, address and length means the range
> > -  of the whole interrupt controller. The "marvell,mmp3-intc" controller
> > -  also has a secondary range for the second CPU core.  If the interrupt
> > -  controller is mux-intc, address and length means one register. Since
> > -  address of mux-intc is in the range of intc. mux-intc is secondary
> > -  interrupt controller.
> > -- reg-names : Name of the register set of the interrupt controller. It's
> > -  only required in mux-intc interrupt controller.
> > -- interrupts : Should be the port interrupt shared by mux interrupts. It's
> > -  only required in mux-intc interrupt controller.
> > -- interrupt-controller : Identifies the node as an interrupt controller.
> > -- #interrupt-cells : Specifies the number of cells needed to encode an
> > -  interrupt source.
> > -- mrvl,intc-nr-irqs : Specifies the number of interrupts in the interrupt
> > -  controller.
> > -- mrvl,clr-mfp-irq : Specifies the interrupt that needs to clear MFP edge
> > -  detection first.
> > -
> > -Example:
> > -	intc: interrupt-controller@d4282000 {
> > -		compatible = "mrvl,mmp2-intc";
> > -		interrupt-controller;
> > -		#interrupt-cells = <1>;
> > -		reg = <0xd4282000 0x1000>;
> > -		mrvl,intc-nr-irqs = <64>;
> > -	};
> > -
> > -	intcmux4@d4282150 {
> > -		compatible = "mrvl,mmp2-mux-intc";
> > -		interrupts = <4>;
> > -		interrupt-controller;
> > -		#interrupt-cells = <1>;
> > -		reg = <0x150 0x4>, <0x168 0x4>;
> > -		reg-names = "mux status", "mux mask";
> > -		mrvl,intc-nr-irqs = <2>;
> > -	};
> > -
> > -* Marvell Orion Interrupt controller
> > -
> > -Required properties
> > -- compatible :  Should be "marvell,orion-intc".
> > -- #interrupt-cells: Specifies the number of cells needed to encode an
> > -  interrupt source. Supported value is <1>.
> > -- interrupt-controller : Declare this node to be an interrupt controller.
> > -- reg : Interrupt mask address. A list of 4 byte ranges, one per controller.
> > -        One entry in the list represents 32 interrupts.
> > -
> > -Example:
> > -
> > -	intc: interrupt-controller {
> > -        	compatible = "marvell,orion-intc", "marvell,intc";
> > -		interrupt-controller;
> > -		#interrupt-cells = <1>;
> > -                reg = <0xfed20204 0x04>,
> > -		      <0xfed20214 0x04>;
> > -        };
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
> > new file mode 100644
> > index 0000000000000..f0644f7d7e1d2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/mrvl,intc.yaml
> > @@ -0,0 +1,144 @@
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/interrupt-controller/mrvl,intc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell MMP/Orion Interrupt controller bindings
> > +
> > +maintainers:
> > +  - devicetree@vger.kernel.org
> > +
> > +allOf:
> > +  - $ref: /schemas/interrupt-controller.yaml#
> 
> Drop this. It is already applied based on matching on the node name.
> 
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          not:
> > +            contains:
> > +              const: marvell,orion-intc
> > +    then:
> > +      required:
> > +        - mrvl,intc-nr-irqs
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - mrvl,mmp-intc
> > +              - mrvl,mmp2-intc
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 1
> > +          maxItems: 1
> 
> Drop minItems, as just 'maxItems: 1' is enough.
> 
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - marvell,mmp3-intc
> > +              - mrvl,mmp2-mux-intc
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 2
> > +          maxItems: 2
> 
> Just 'minItems: 2'.
> 
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: marvell,orion-intc
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 1
> > +          maxItems: 2
> 
> Normally, for a compatible this would not vary...
> 
> In any case, move this to the main section and drop this if.
> 
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: mrvl,mmp2-mux-intc
> > +    then:
> > +      properties:
> > +        interrupts:
> > +          minItems: 1
> > +          maxItems: 1
> 
> Just 'maxItems'
> 
> > +        reg-names:
> > +          minItems: 2
> > +          maxItems: 2
> 
> These are redundant as 'items' size implies this.
> 
> > +          items:
> > +            - const: 'mux status'
> > +            - const: 'mux mask'
> 
> Move this to the main section.
> 
> > +      required:
> > +        - interrupts
> > +    else:
> > +      properties:
> > +        interrupts: false
> > +
> > +properties:
> > +  '#interrupt-cells':
> > +    const: 1
> > +
> > +  compatible:
> > +    enum:
> > +      - mrvl,mmp-intc
> > +      - mrvl,mmp2-intc
> > +      - marvell,mmp3-intc
> > +      - marvell,orion-intc
> > +      - mrvl,mmp2-mux-intc
> > +
> > +  reg: true
> > +
> > +  reg-names: true
> > +
> > +  interrupts: true
> > +
> > +  interrupt-controller: true
> > +
> > +  mrvl,intc-nr-irqs:
> > +    description: |
> > +      Specifies the number of interrupts in the interrupt controller.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> Is there a max number?

There's none in the original bindings document or enforced by the
driver.

> > +
> > +  mrvl,clr-mfp-irq:
> > +    description: |
> > +      Specifies the interrupt that needs to clear MFP edge detection first.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> Constraints?

I don't know how should this be constrained and the original bindings
document is not helpful.

> > +
> > +required:
> > +  - '#interrupt-cells'
> > +  - compatible
> > +  - reg
> > +  - interrupt-controller
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    interrupt-controller@d4282000 {
> > +        compatible = "mrvl,mmp2-intc";
> > +        interrupt-controller;
> > +        #interrupt-cells = <1>;
> > +        reg = <0xd4282000 0x1000>;
> > +        mrvl,intc-nr-irqs = <64>;
> > +    };
> > +
> > +    interrupt-controller@d4282150 {
> > +        compatible = "mrvl,mmp2-mux-intc";
> > +        interrupts = <4>;
> > +        interrupt-controller;
> > +        #interrupt-cells = <1>;
> > +        reg = <0x150 0x4>, <0x168 0x4>;
> > +        reg-names = "mux status", "mux mask";
> > +        mrvl,intc-nr-irqs = <2>;
> > +    };
> > +  - |
> > +    interrupt-controller@fed20204 {
> > +        compatible = "marvell,orion-intc";
> > +        interrupt-controller;
> > +        #interrupt-cells = <1>;
> > +        reg = <0xfed20204 0x04>,
> > +              <0xfed20214 0x04>;
> > +    };
> > +
> > +...
> > -- 
> > 2.25.1
> > 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic to json-schema
  2020-03-27 19:46   ` Rob Herring
@ 2020-05-17 19:21     ` Lubomir Rintel
  0 siblings, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-05-17 19:21 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, linux-gpio, linux-i2c, linux-media,
	linux-mmc, linux-rtc, linux-serial, linux-spi, linux-usb

On Fri, Mar 27, 2020 at 01:46:37PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:18AM +0100, Lubomir Rintel wrote:
> > Convert the marvell,mmp2-ccic binding to DT schema format using
> > json-schema.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  .../bindings/media/marvell,mmp2-ccic.txt      |  50 ---------
> >  .../bindings/media/marvell,mmp2-ccic.yaml     | 102 ++++++++++++++++++
> >  2 files changed, 102 insertions(+), 50 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> >  create mode 100644 Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> > deleted file mode 100644
> > index 7ec2c8c8a3b98..0000000000000
> > --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.txt
> > +++ /dev/null
> > @@ -1,50 +0,0 @@
> > -Marvell MMP2 camera host interface
> > -
> > -Required properties:
> > - - compatible: Should be "marvell,mmp2-ccic".
> > - - reg: Register base and size.
> > - - interrupts: The interrupt number.
> > - - #clock-cells: Must be 0.
> > -
> > -Optional properties:
> > - - clocks: Reference to the input clock as specified by
> > -           Documentation/devicetree/bindings/clock/clock-bindings.txt.
> > - - clock-names: Names of the clocks used; "axi" for the AXI bus interface,
> > -                "func" for the peripheral clock and "phy" for the parallel
> > -                video bus interface.
> > - - clock-output-names: Optional clock source for sensors. Shall be "mclk".
> > -
> > -Required subnodes:
> > - - port: The parallel bus interface port with a single endpoint linked to
> > -         the sensor's endpoint as described in
> > -         Documentation/devicetree/bindings/media/video-interfaces.txt.
> > -
> > -Required endpoint properties:
> > - - bus-type: data bus type, <5> or <6> for Parallel or Bt.656 respectively
> > - - pclk-sample: pixel clock polarity
> > - - hsync-active: horizontal synchronization polarity (only required for
> > -   parallel bus)
> > - - vsync-active: vertical synchronization polarity (only required for
> > -   parallel bus)
> > -
> > -Example:
> > -
> > -	camera0: camera@d420a000 {
> > -		compatible = "marvell,mmp2-ccic";
> > -		reg = <0xd420a000 0x800>;
> > -		interrupts = <42>;
> > -		clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> > -		clock-names = "axi";
> > -		#clock-cells = <0>;
> > -		clock-output-names = "mclk";
> > -
> > -		port {
> > -			camera0_0: endpoint {
> > -				remote-endpoint = <&ov7670_0>;
> > -                                bus-type = <5>;      /* Parallel */
> > -                                hsync-active = <1>;  /* Active high */
> > -                                vsync-active = <1>;  /* Active high */
> > -                                pclk-sample = <0>;   /* Falling */
> > -			};
> > -		};
> > -	};
> > diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > new file mode 100644
> > index 0000000000000..890a3f9d0302f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> > @@ -0,0 +1,102 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> 
> GPL-2.0-only please. Dual license only if you have rights on the old 
> file to do so.

I do. I wrote the original binding file.

> > +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/marvell,mmp2-ccic.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell MMP2 camera host interface bindings
> > +
> > +maintainers:
> > +  - Lubomir Rintel <lkundrak@v3.sk>
> > +
> > +properties:
> > +  $nodename:
> > +    pattern: '^camera@[a-f0-9]+$'
> > +
> > +  compatible:
> > +    const: marvell,mmp2-ccic
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  port:
> > +    type: object
> > +    additionalProperties: false
> > +
> > +    properties:
> > +       endpoint:
> 
> Wrong indentaion.
> 
> > +         type: object
> > +         additionalProperties: false
> > +
> > +         # Properties described in
> > +         # Documentation/devicetree/bindings/media/video-interfaces.txt
> > +         properties:
> > +           remote-endpoint: true
> > +           hsync-active: true
> > +           vsync-active: true
> > +           pclk-sample: true
> > +           bus-type: true
> > +
> > +         required:
> > +           - remote-endpoint
> > +
> > +    required:
> > +      - endpoint
> > +
> > +  clocks:
> > +    minItems: 1
> > +    maxItems: 3
> 
> Shouldn't really be variable for a single compatible.
> 
> > +    items:
> > +      - description: AXI bus interface clock
> > +      - description: Peripheral clock
> > +      - description: Parallel video bus interface clock
> > +
> > +  clock-names:
> > +    minItems: 1
> > +    maxItems: 3
> > +    items:
> > +      - const: axi
> > +      - const: func
> > +      - const: phy
> > +
> > +  '#clock-cells':
> > +    const: 0
> > +
> > +  clock-output-names:
> > +    const: mclk
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - port
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/marvell,mmp2.h>
> > +
> > +    camera@d420a000 {
> > +      compatible = "marvell,mmp2-ccic";
> > +      reg = <0xd420a000 0x800>;
> > +      interrupts = <42>;
> > +      clocks = <&soc_clocks MMP2_CLK_CCIC0>;
> > +      clock-names = "axi";
> > +      #clock-cells = <0>;
> > +      clock-output-names = "mclk";
> > +
> > +      port {
> > +        camera0_0: endpoint {
> > +          remote-endpoint = <&ov7670_0>;
> > +          bus-type = <5>;      /* Parallel */
> > +          hsync-active = <1>;  /* Active high */
> > +          vsync-active = <1>;  /* Active high */
> > +          pclk-sample = <0>;   /* Falling */
> > +        };
> > +      };
> > +    };
> > +
> > +...
> > -- 
> > 2.25.1
> > 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc to json-schema
  2020-03-27 19:49   ` Rob Herring
@ 2020-05-17 19:25     ` Lubomir Rintel
  2020-05-18 15:12       ` Rob Herring
  0 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-05-17 19:25 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, linux-gpio, linux-i2c, linux-media,
	linux-mmc, linux-rtc, linux-serial, linux-spi, linux-usb

On Fri, Mar 27, 2020 at 01:49:02PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:19AM +0100, Lubomir Rintel wrote:
> > Convert the sa1100-rtc binding to DT schema format using json-schema.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  .../devicetree/bindings/rtc/sa1100-rtc.txt    | 17 ------
> >  .../devicetree/bindings/rtc/sa1100-rtc.yaml   | 55 +++++++++++++++++++
> >  2 files changed, 55 insertions(+), 17 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> >  create mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt b/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> > deleted file mode 100644
> > index 968ac820254bb..0000000000000
> > --- a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> > +++ /dev/null
> > @@ -1,17 +0,0 @@
> > -* Marvell Real Time Clock controller
> > -
> > -Required properties:
> > -- compatible: should be "mrvl,sa1100-rtc"
> > -- reg: physical base address of the controller and length of memory mapped
> > -  region.
> > -- interrupts: Should be two. The first interrupt number is the rtc alarm
> > -  interrupt and the second interrupt number is the rtc hz interrupt.
> > -- interrupt-names: Assign name of irq resource.
> > -
> > -Example:
> > -	rtc: rtc@d4010000 {
> > -		compatible = "mrvl,mmp-rtc";
> > -		reg = <0xd4010000 0x1000>;
> > -		interrupts = <5>, <6>;
> > -		interrupt-names = "rtc 1Hz", "rtc alarm";
> > -	};
> > diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> > new file mode 100644
> > index 0000000000000..53a8b72df9f34
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> > @@ -0,0 +1,55 @@
> 
> License

The original file lacked one. Should I just go with GPL-2.0?

> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/sa1100-rtc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell Real Time Clock controller bindings
> > +
> > +allOf:
> > +  - $ref: rtc.yaml#
> > +
> > +maintainers:
> > +  - devicetree@vger.kernel.org
> 
> Real person

It's not clear who would that be.

> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - mrvl,sa1100-rtc
> > +      - mrvl,mmp-rtc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  resets:
> > +    maxItems: 1
> 
> clocks and resets weren't documented before. Fine to add here, but add 
> that to the commit msg.
> 
> > +
> > +  interrupts:
> > +    minItems: 2
> > +    maxItems: 2
> 
> Drop minItems.

It needs to be exactly 2. I suppose for that I should drop maxItems
instead?

> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: 'rtc 1Hz'
> > +      - const: 'rtc alarm'
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - interrupt-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    rtc: rtc@d4010000 {
> > +        compatible = "mrvl,mmp-rtc";
> > +        reg = <0xd4010000 0x1000>;
> > +        interrupts = <5>, <6>;
> > +        interrupt-names = "rtc 1Hz", "rtc alarm";
> > +    };
> > +
> > +...
> > -- 
> > 2.25.1
> > 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx to json-schema
  2020-03-27 19:52   ` Rob Herring
@ 2020-05-17 19:30     ` Lubomir Rintel
  0 siblings, 0 replies; 81+ messages in thread
From: Lubomir Rintel @ 2020-05-17 19:30 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, linux-gpio, linux-i2c, linux-media,
	linux-mmc, linux-rtc, linux-serial, linux-spi, linux-usb

On Fri, Mar 27, 2020 at 01:52:39PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:20AM +0100, Lubomir Rintel wrote:
> > A straightforward conversion of the the spi-pxa2xx binding to DT schema
> > format using json-schema.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  .../bindings/spi/marvell,mmp2-ssp.yaml        | 58 +++++++++++++++++++
> >  .../devicetree/bindings/spi/spi-pxa2xx.txt    | 27 ---------
> >  2 files changed, 58 insertions(+), 27 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> > new file mode 100644
> > index 0000000000000..de6b6a53b70d8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/spi/marvell,mmp2-ssp.yaml
> > @@ -0,0 +1,58 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> 
> Same issue on license...

I've written the original document and have chosen this license (for no
good reason, but I don't think that matters).

> > +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/spi/marvell,mmp2-ssp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: PXA2xx SSP SPI Controller bindings
> > +
> > +maintainers:
> > +  - Lubomir Rintel <lkundrak@v3.sk>
> > +
> > +allOf:
> > +  - $ref: spi-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: marvell,mmp2-ssp
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  ready-gpios:
> > +    description: |
> > +      GPIO used to signal a SPI master that the FIFO is filled and we're
> > +      ready to service a transfer. Only useful in slave mode.
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> 
> > +  - '#address-cells'
> > +  - '#size-cells'
> 
> spi-controller.yaml handles these being required and also that they 
> aren't for slave mode.
> 
> > +
> > +dependencies:
> > +  ready-gpios: [ spi-slave ]
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/marvell,mmp2.h>
> > +    spi@d4035000 {
> > +        compatible = "marvell,mmp2-ssp";
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        reg = <0xd4035000 0x1000>;
> > +        clocks = <&soc_clocks MMP2_CLK_SSP0>;
> > +        interrupts = <0>;
> > +    };
> > +
> > +...
> > diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> > deleted file mode 100644
> > index e30e0c2a4bce1..0000000000000
> > --- a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt
> > +++ /dev/null
> > @@ -1,27 +0,0 @@
> > -PXA2xx SSP SPI Controller
> > -
> > -Required properties:
> > -- compatible: Must be "marvell,mmp2-ssp".
> > -- reg: Offset and length of the device's register set.
> > -- interrupts: Should be the interrupt number.
> > -- clocks: Should contain a single entry describing the clock input.
> > -- #address-cells:  Number of cells required to define a chip select address.
> > -- #size-cells: Should be zero.
> > -
> > -Optional properties:
> > -- cs-gpios: list of GPIO chip selects. See the SPI bus bindings,
> > -  Documentation/devicetree/bindings/spi/spi-bus.txt
> > -- spi-slave: Empty property indicating the SPI controller is used in slave mode.
> > -- ready-gpios: GPIO used to signal a SPI master that the FIFO is filled
> > -  and we're ready to service a transfer. Only useful in slave mode.
> > -
> > -Child nodes represent devices on the SPI bus
> > -  See ../spi/spi-bus.txt
> > -
> > -Example:
> > -	ssp1: spi@d4035000 {
> > -		compatible = "marvell,mmp2-ssp";
> > -		reg = <0xd4035000 0x1000>;
> > -		clocks = <&soc_clocks MMP2_CLK_SSP0>;
> > -		interrupts = <0>;
> > -	};
> > -- 
> > 2.25.1
> > 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema
  2020-03-27 19:55   ` Rob Herring
@ 2020-05-17 19:34     ` Lubomir Rintel
  2020-05-18 15:20       ` Rob Herring
  0 siblings, 1 reply; 81+ messages in thread
From: Lubomir Rintel @ 2020-05-17 19:34 UTC (permalink / raw)
  To: Rob Herring
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, linux-gpio, linux-i2c, linux-media,
	linux-mmc, linux-rtc, linux-serial, linux-spi, linux-usb

On Fri, Mar 27, 2020 at 01:55:20PM -0600, Rob Herring wrote:
> On Tue, Mar 17, 2020 at 10:39:22AM +0100, Lubomir Rintel wrote:
> > A straightforward conversion of the ehci-mv binding to DT schema format
> > using json-schema.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  .../devicetree/bindings/usb/ehci-mv.txt       | 23 -------
> >  .../bindings/usb/marvell,pxau2o-ehci.yaml     | 60 +++++++++++++++++++
> >  2 files changed, 60 insertions(+), 23 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/usb/ehci-mv.txt
> >  create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/ehci-mv.txt b/Documentation/devicetree/bindings/usb/ehci-mv.txt
> > deleted file mode 100644
> > index 335589895763e..0000000000000
> > --- a/Documentation/devicetree/bindings/usb/ehci-mv.txt
> > +++ /dev/null
> > @@ -1,23 +0,0 @@
> > -* Marvell PXA/MMP EHCI controller.
> > -
> > -Required properties:
> > -
> > -- compatible: must be "marvell,pxau2o-ehci"
> > -- reg: physical base addresses of the controller and length of memory mapped region
> > -- interrupts: one EHCI controller interrupt should be described here
> > -- clocks: phandle list of usb clocks
> > -- clock-names: should be "USBCLK"
> > -- phys: phandle for the PHY device
> > -- phy-names: should be "usb"
> > -
> > -Example:
> > -
> > -	ehci0: usb-ehci@d4208000 {
> > -		compatible = "marvell,pxau2o-ehci";
> > -		reg = <0xd4208000 0x200>;
> > -		interrupts = <44>;
> > -		clocks = <&soc_clocks MMP2_CLK_USB>;
> > -		clock-names = "USBCLK";
> > -		phys = <&usb_otg_phy>;
> > -		phy-names = "usb";
> > -	};
> > diff --git a/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > new file mode 100644
> > index 0000000000000..189025ef1e92e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> 
> Same license comment.

I wrote that binding document and chose that license.

> > +# Copyright 2019,2020 Lubomir Rintel <lkundrak@v3.sk>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/usb/marvell,pxau2o-ehci.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Marvell PXA/MMP EHCI bindings
> > +
> > +maintainers:
> > +  - Lubomir Rintel <lkundrak@v3.sk>
> > +
> > +allOf:
> > +  - $ref: usb-hcd.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: marvell,pxau2o-ehci
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    const: USBCLK
> > +
> > +  phys:
> > +    maxItems: 1
> > +
> > +  phy-names:
> > +    const: usb
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - clock-names
> > +  - phys
> > +  - phy-names
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/marvell,mmp2.h>
> > +    usb@d4208000 {
> > +        compatible = "marvell,pxau2o-ehci";
> > +        reg = <0xd4208000 0x200>;
> > +        interrupts = <44>;
> > +        clocks = <&soc_clocks MMP2_CLK_USB>;
> > +        clock-names = "USBCLK";
> > +        phys = <&usb_otg_phy>;
> > +        phy-names = "usb";
> > +    };
> > +
> > +...
> > -- 
> > 2.25.1
> > 

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc to json-schema
  2020-05-17 19:25     ` Lubomir Rintel
@ 2020-05-18 15:12       ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-05-18 15:12 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, open list:GPIO SUBSYSTEM, Linux I2C,
	Linux Media Mailing List, linux-mmc,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
	open list:SERIAL DRIVERS, linux-spi, Linux USB List

On Sun, May 17, 2020 at 1:26 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> On Fri, Mar 27, 2020 at 01:49:02PM -0600, Rob Herring wrote:
> > On Tue, Mar 17, 2020 at 10:39:19AM +0100, Lubomir Rintel wrote:
> > > Convert the sa1100-rtc binding to DT schema format using json-schema.
> > >
> > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > > ---
> > >  .../devicetree/bindings/rtc/sa1100-rtc.txt    | 17 ------
> > >  .../devicetree/bindings/rtc/sa1100-rtc.yaml   | 55 +++++++++++++++++++
> > >  2 files changed, 55 insertions(+), 17 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> > >  create mode 100644 Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt b/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> > > deleted file mode 100644
> > > index 968ac820254bb..0000000000000
> > > --- a/Documentation/devicetree/bindings/rtc/sa1100-rtc.txt
> > > +++ /dev/null
> > > @@ -1,17 +0,0 @@
> > > -* Marvell Real Time Clock controller
> > > -
> > > -Required properties:
> > > -- compatible: should be "mrvl,sa1100-rtc"
> > > -- reg: physical base address of the controller and length of memory mapped
> > > -  region.
> > > -- interrupts: Should be two. The first interrupt number is the rtc alarm
> > > -  interrupt and the second interrupt number is the rtc hz interrupt.
> > > -- interrupt-names: Assign name of irq resource.
> > > -
> > > -Example:
> > > -   rtc: rtc@d4010000 {
> > > -           compatible = "mrvl,mmp-rtc";
> > > -           reg = <0xd4010000 0x1000>;
> > > -           interrupts = <5>, <6>;
> > > -           interrupt-names = "rtc 1Hz", "rtc alarm";
> > > -   };
> > > diff --git a/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> > > new file mode 100644
> > > index 0000000000000..53a8b72df9f34
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/rtc/sa1100-rtc.yaml
> > > @@ -0,0 +1,55 @@
> >
> > License
>
> The original file lacked one. Should I just go with GPL-2.0?

Yes, that is what files in the kernel with no license default to. Or
figure out the authors and get permission to dual-license.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

* Re: [PATCH 28/28] dt-bindings: usb: Convert ehci-mv to json-schema
  2020-05-17 19:34     ` Lubomir Rintel
@ 2020-05-18 15:20       ` Rob Herring
  0 siblings, 0 replies; 81+ messages in thread
From: Rob Herring @ 2020-05-18 15:20 UTC (permalink / raw)
  To: Lubomir Rintel
  Cc: Linus Walleij, Bartosz Golaszewski, Thomas Gleixner,
	Jason Cooper, Marc Zyngier, Mauro Carvalho Chehab, Ulf Hansson,
	Kishon Vijay Abraham I, Alessandro Zummo, Alexandre Belloni,
	Greg Kroah-Hartman, Mark Brown, Daniel Lezcano, Andrew Lunn,
	Gregory Clement, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	devicetree, linux-kernel, open list:GPIO SUBSYSTEM, Linux I2C,
	Linux Media Mailing List, linux-mmc,
	open list:REAL TIME CLOCK (RTC) SUBSYSTEM,
	open list:SERIAL DRIVERS, linux-spi, Linux USB List

On Sun, May 17, 2020 at 1:34 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> On Fri, Mar 27, 2020 at 01:55:20PM -0600, Rob Herring wrote:
> > On Tue, Mar 17, 2020 at 10:39:22AM +0100, Lubomir Rintel wrote:
> > > A straightforward conversion of the ehci-mv binding to DT schema format
> > > using json-schema.
> > >
> > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > > ---
> > >  .../devicetree/bindings/usb/ehci-mv.txt       | 23 -------
> > >  .../bindings/usb/marvell,pxau2o-ehci.yaml     | 60 +++++++++++++++++++
> > >  2 files changed, 60 insertions(+), 23 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/usb/ehci-mv.txt
> > >  create mode 100644 Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/usb/ehci-mv.txt b/Documentation/devicetree/bindings/usb/ehci-mv.txt
> > > deleted file mode 100644
> > > index 335589895763e..0000000000000
> > > --- a/Documentation/devicetree/bindings/usb/ehci-mv.txt
> > > +++ /dev/null
> > > @@ -1,23 +0,0 @@
> > > -* Marvell PXA/MMP EHCI controller.
> > > -
> > > -Required properties:
> > > -
> > > -- compatible: must be "marvell,pxau2o-ehci"
> > > -- reg: physical base addresses of the controller and length of memory mapped region
> > > -- interrupts: one EHCI controller interrupt should be described here
> > > -- clocks: phandle list of usb clocks
> > > -- clock-names: should be "USBCLK"
> > > -- phys: phandle for the PHY device
> > > -- phy-names: should be "usb"
> > > -
> > > -Example:
> > > -
> > > -   ehci0: usb-ehci@d4208000 {
> > > -           compatible = "marvell,pxau2o-ehci";
> > > -           reg = <0xd4208000 0x200>;
> > > -           interrupts = <44>;
> > > -           clocks = <&soc_clocks MMP2_CLK_USB>;
> > > -           clock-names = "USBCLK";
> > > -           phys = <&usb_otg_phy>;
> > > -           phy-names = "usb";
> > > -   };
> > > diff --git a/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > > new file mode 100644
> > > index 0000000000000..189025ef1e92e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/usb/marvell,pxau2o-ehci.yaml
> > > @@ -0,0 +1,60 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> >
> > Same license comment.
>
> I wrote that binding document and chose that license.

Okay, but please make it GPL-2.0-only instead of or-later. If everyone
was attentive to licensing picking their own variations would be fine,
but they aren't and just copy-n-paste. So there's 2 choices
GPL-2.0-only (for converted bindings) or (GPL-2.0-only OR
BSD-2-Clause) for new or re-licensed bindings.

Rob

^ permalink raw reply	[flat|nested] 81+ messages in thread

end of thread, back to index

Thread overview: 81+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17  9:38 [PATCH 00/28] DT: Improve validation for Marvell SoCs Lubomir Rintel
2020-03-17  9:38 ` [PATCH 01/28] ARM: dts: kirkwood: Fix interrupt controller node name Lubomir Rintel
     [not found]   ` <20200317093922.20785-2-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:20     ` Andrew Lunn
2020-03-17  9:39 ` [PATCH 08/28] ARM: dts: mmp*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
     [not found]   ` <20200317093922.20785-9-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:30     ` Andrew Lunn
2020-03-17 13:30     ` Andrew Lunn
2020-03-17  9:39 ` [PATCH 10/28] ARM: dts: mmp3: fix USB & USB PHY node names Lubomir Rintel
2020-03-17 13:32   ` Andrew Lunn
2020-03-17  9:39 ` [PATCH 11/28] ARM: dts: berlin*: Fix up the SDHCI " Lubomir Rintel
2020-03-17 13:34   ` Andrew Lunn
2020-03-17  9:39 ` [PATCH 12/28] spi: dt-bindings: spi-controller: Slaves have no address cells Lubomir Rintel
     [not found]   ` <20200317093922.20785-13-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-19 16:51     ` Rob Herring
2020-03-17  9:39 ` [PATCH 13/28] dt-bindings: serial: move Marvell compatible string to 8250 binding doc Lubomir Rintel
2020-03-17 13:48   ` Andrew Lunn
2020-03-17 19:09     ` Lubomir Rintel
2020-03-19 16:09     ` Rob Herring
     [not found]   ` <20200317093922.20785-14-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-19 16:11     ` Rob Herring
2020-03-20  9:24       ` Lubomir Rintel
2020-03-17  9:39 ` [PATCH 14/28] dt-bindings: arm: l2x0: Tauros 3 is PL310 compatible Lubomir Rintel
2020-03-27 19:03   ` Rob Herring
2020-03-27 19:04   ` Rob Herring
2020-03-17  9:39 ` [PATCH 15/28] dt-bindings: arm: mrvl: Add missing compatible strings Lubomir Rintel
2020-03-17 13:54   ` Andrew Lunn
2020-03-27 19:06   ` Rob Herring
2020-03-17  9:39 ` [PATCH 16/28] dt-bindings: Add "mrvl", a legacy vendor prefix for Marvell Lubomir Rintel
2020-03-27 19:06   ` Rob Herring
     [not found] ` <20200317093922.20785-1-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17  9:38   ` [PATCH 02/28] ARM: dts: dove: Fix interrupt controller node name Lubomir Rintel
2020-03-17 13:20     ` Andrew Lunn
2020-03-17  9:38   ` [PATCH 03/28] ARM: dts: pxa168: Add missing address/size cells to i2c nodes Lubomir Rintel
     [not found]     ` <20200317093922.20785-4-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:21       ` Andrew Lunn
2020-03-17  9:38   ` [PATCH 04/28] ARM: dts: pxa168: Fix the gpio interrupt cell number Lubomir Rintel
2020-03-17 13:27     ` Andrew Lunn
2020-03-17  9:38   ` [PATCH 05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property Lubomir Rintel
     [not found]     ` <20200317093922.20785-6-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-17 13:28       ` Andrew Lunn
2020-03-21  7:36         ` Robert Jarzmik
2020-03-17  9:39   ` [PATCH 06/28] ARM: dts: pxa910: Fix the gpio interrupt cell number Lubomir Rintel
2020-03-17 13:29     ` Andrew Lunn
2020-03-17  9:39   ` [PATCH 07/28] ARM: dts: pxa*: Fix up encoding of the /rtc interrupts property Lubomir Rintel
2020-03-17 13:29     ` Andrew Lunn
2020-03-17  9:39   ` [PATCH 09/28] ARM: dts: mmp3: fix L2 cache controller node name Lubomir Rintel
2020-03-17 13:31     ` Andrew Lunn
2020-03-17  9:39   ` [PATCH 17/28] dt-bindings: mmc: Fix up clk-phase-sd-hs in an example Lubomir Rintel
2020-03-17 10:04     ` Sergei Shtylyov
     [not found]     ` <20200317093922.20785-18-lkundrak-NGH9Lh4a5iE@public.gmane.org>
2020-03-27 19:08       ` Rob Herring
2020-03-17  9:39   ` [PATCH 20/28] dt-bindings: phy: Convert phy-mmp3-usb to json-schema Lubomir Rintel
2020-03-27 19:09     ` Rob Herring
2020-03-17  9:39   ` [PATCH 22/28] dt-bindings: i2c: Convert i2c-pxa " Lubomir Rintel
2020-03-17 13:19   ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Mark Brown
2020-03-17  9:39 ` [PATCH 18/28] dt-bindings: mmc: Fix node name in an example Lubomir Rintel
2020-03-26 14:28   ` Ulf Hansson
2020-03-17  9:39 ` [PATCH 19/28] dt-bindings: mmc: Convert sdhci-pxa to json-schema Lubomir Rintel
2020-03-18 22:14   ` Rob Herring
2020-03-18 22:37   ` Rob Herring
2020-05-17 18:35     ` Lubomir Rintel
2020-03-17  9:39 ` [PATCH 21/28] dt-bindings: gpio: Convert mrvl-gpio " Lubomir Rintel
2020-03-27 10:04   ` Linus Walleij
2020-03-27 19:29     ` Rob Herring
2020-03-27 19:28   ` Rob Herring
2020-05-17 19:00     ` Lubomir Rintel
2020-03-17  9:39 ` [PATCH 23/28] dt-bindings: interrupt-controller: Convert mrvl,intc " Lubomir Rintel
2020-03-27 19:42   ` Rob Herring
2020-05-17 19:11     ` Lubomir Rintel
2020-03-17  9:39 ` [PATCH 24/28] dt-bindings: media: Convert marvell,mmp2-ccic " Lubomir Rintel
2020-03-27 19:46   ` Rob Herring
2020-05-17 19:21     ` Lubomir Rintel
2020-03-17  9:39 ` [PATCH 25/28] dt-bindings: rtc: Convert sa1100-rtc " Lubomir Rintel
2020-03-27 19:49   ` Rob Herring
2020-05-17 19:25     ` Lubomir Rintel
2020-05-18 15:12       ` Rob Herring
2020-03-17  9:39 ` [PATCH 26/28] dt-bindings: spi: Convert spi-pxa2xx " Lubomir Rintel
2020-03-27 19:52   ` Rob Herring
2020-05-17 19:30     ` Lubomir Rintel
2020-03-17  9:39 ` [PATCH 27/28] dt-bindings: timer: Convert mrvl,mmp-timer " Lubomir Rintel
2020-03-27 19:53   ` Rob Herring
2020-03-17  9:39 ` [PATCH 28/28] dt-bindings: usb: Convert ehci-mv " Lubomir Rintel
2020-03-27 19:55   ` Rob Herring
2020-05-17 19:34     ` Lubomir Rintel
2020-05-18 15:20       ` Rob Herring
2020-03-17 13:46 ` [PATCH 00/28] DT: Improve validation for Marvell SoCs Andrew Lunn
     [not found]   ` <20200317134609.GN24270-g2DYL2Zd6BY@public.gmane.org>
2020-03-17 13:55     ` Alexandre Belloni
     [not found]       ` <20200317135551.GE3448-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2020-03-17 13:59         ` Andrew Lunn

Linux-i2c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i2c/0 linux-i2c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i2c linux-i2c/ https://lore.kernel.org/linux-i2c \
		linux-i2c@vger.kernel.org
	public-inbox-index linux-i2c

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-i2c


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git