From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jenny Ho <hsiufangho@google.com>, Arnd Bergmann <arnd@arndb.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] eeprom: at24: Add permission to write_timeout
Date: Thu, 28 Jan 2021 10:44:10 +0100 [thread overview]
Message-ID: <CAMpxmJXejQjbR1qZEYTcyrFUYivJ5_U0Tchmh5V4ZqOi5NK=7A@mail.gmail.com> (raw)
In-Reply-To: <YBJ/3UuIMyfjpMHg@kroah.com>
On Thu, Jan 28, 2021 at 10:12 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Jan 28, 2021 at 10:04:42AM +0100, Bartosz Golaszewski wrote:
> > On Thu, Jan 28, 2021 at 9:10 AM Jenny Ho <hsiufangho@google.com> wrote:
> > >
> > > Need to change timeout time for different use
> > > cases to prevent I2C error cases. Open the api
> > > and allow Read/Write permission to write_timeout
> > >
> > > Signed-off-by: Jenny Ho <hsiufangho@google.com>
> > > ---
> > > drivers/misc/eeprom/at24.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> > > index 926408b41270..39caead4058c 100644
> > > --- a/drivers/misc/eeprom/at24.c
> > > +++ b/drivers/misc/eeprom/at24.c
> > > @@ -117,7 +117,7 @@ MODULE_PARM_DESC(at24_io_limit, "Maximum bytes per I/O (default 128)");
> > > * it's important to recover from write timeouts.
> > > */
> > > static unsigned int at24_write_timeout = 25;
> > > -module_param_named(write_timeout, at24_write_timeout, uint, 0);
> > > +module_param_named(write_timeout, at24_write_timeout, uint, 0600);
> > > MODULE_PARM_DESC(at24_write_timeout, "Time (in ms) to try writes (default 25)");
> > >
> > > struct at24_chip_data {
> > > --
> > > 2.30.0.280.ga3ce27912f-goog
> > >
> >
> > IMO this should be a per-chip device property and not a global module
> > param. Any chance you could maybe try and extend the driver with a new
> > property for that?
>
> This already is a global module parameter :)
>
I know but if we're touching it, then better do the right thing. :)
> But I agree, having it per-device would be much better, a sysfs
> attribute would easily work for that.
>
I was thinking about a generic device property that could be set from
device tree etc. I doubt there's much need to change this at runtime
outside of development?
Bart
prev parent reply other threads:[~2021-01-28 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 8:10 [PATCH] eeprom: at24: Add permission to write_timeout Jenny Ho
2021-01-28 9:04 ` Bartosz Golaszewski
2021-01-28 9:11 ` Greg Kroah-Hartman
2021-01-28 9:44 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJXejQjbR1qZEYTcyrFUYivJ5_U0Tchmh5V4ZqOi5NK=7A@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hsiufangho@google.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).