From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D627C433ED for ; Mon, 19 Apr 2021 13:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E5E061246 for ; Mon, 19 Apr 2021 13:54:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237575AbhDSNyz (ORCPT ); Mon, 19 Apr 2021 09:54:55 -0400 Received: from mail-ua1-f42.google.com ([209.85.222.42]:42962 "EHLO mail-ua1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235854AbhDSNyv (ORCPT ); Mon, 19 Apr 2021 09:54:51 -0400 Received: by mail-ua1-f42.google.com with SMTP id 23so1608852uac.9; Mon, 19 Apr 2021 06:54:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JL6d1XdDaj8WiEzJbvQLLWoDwh1itkt9fBhBIziUdrE=; b=N+KBUYxUS893845ogE4U/8MMkARopY8b8qcUsy6kfH/Ms5+Xs6inIl88q8jjvYKUX4 /G0X3Qgv/eKCNC/h1O4elCDO2/1oAYoPtTAn82GcowuMzs9F/6iXPd7WaGD9HvyXWF+l 6ZNZHzmqnDkYkejDZSaHJzvpQZB5NnCOfS07Q6uRcXoPIcS8G/i3+cm8LihYVVx0thra FD0+xfNT0D2wjrxf6Ou9AtBviwP9rM90CKg+s+qbGPpgrlGIjw5R4kCgUKEJn9mrgoeZ EJ/n+07s19PT33P/CRm6O4xXJueNSvHrRxkJsp9/lc8RGc4oRzhpFscNBCQhbskZJSxY mr0g== X-Gm-Message-State: AOAM530KCXQ2iXlSoilkhUH+GCcENi8jQ8Q8TfyZ+em7+MB1HTKTIxql g2zDvQaAXCBbSGyj0osT8Cr1J4C1vOOqYzmNaTU= X-Google-Smtp-Source: ABdhPJyjQdTQ1aETHy6U3DdnBYa0ha6mMDdDcINzkW86JQMI52CmM0oSsy2rSRgm5LHhvDe6IrlXkhiqQ5078m8cBVQ= X-Received: by 2002:ab0:2c16:: with SMTP id l22mr7503352uar.100.1618840461416; Mon, 19 Apr 2021 06:54:21 -0700 (PDT) MIME-Version: 1.0 References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 19 Apr 2021 15:54:10 +0200 Message-ID: Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI To: Andy Shevchenko Cc: Andy Shevchenko , Yicong Yang , Wei Xu , Wolfram Sang , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List , Linuxarm Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Andy, On Mon, Apr 19, 2021 at 3:35 PM Andy Shevchenko wrote: > On Mon, Apr 19, 2021 at 4:02 PM Geert Uytterhoeven wrote: > > On Thu, Apr 15, 2021 at 10:50 AM Andy Shevchenko > > wrote: > > > On Thu, Apr 15, 2021 at 3:43 AM Geert Uytterhoeven wrote: > > > > On Wed, Apr 14, 2021 at 9:14 PM Andy Shevchenko > > > > wrote: > > > > > On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote: > > > > > > On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko > > > > > > wrote: > > > > > > > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote: > > > > > > > > On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang wrote: > > ... > > > > > > > > > I guess it's still fine to add a dependency on ACPI? > > > > > > > > > > > > > > But why? > > > > > > > > > > > > Please tell me how/when the driver is used when CONFIG_ACPI=n. > > > > > > > > > > I'm not using it at all. Ask the author :-) > > > > > > > > > > But if we follow your logic, then we need to mark all the _platform_ drivers > > > > > for x86 world as ACPI dependent? This sounds ugly. > > > > > > > > Do all other x86 platform drivers have (1) an .acpi_match_table[] and > > > > (2) no other way of instantiating their devices? > > > > The first driver from the top of my memory I looked at is rtc-cmos: > > > > it has no .acpi_match_table[], and the rtc-cmos device is instantiated > > > > from arch/x86/kernel/rtc.c. > > > > > > > > For drivers with only an .of_match_table(), and no legacy users > > > > instantiating platform devices, we do have dependencies on OF. > > > > > > This is not true. Entire IIO subsystem is an example. > > > > Do you care to elaborate? > > Three quarters of the IIO drivers are I2C and SPI drivers, and thus not > > subject to the above. > > It seems I missed that you are talking about platform device drivers. OK. > In any case it's not true. We have the platform drivers w/o legacy > users that are not dependent on OF. Example? ;-) > They may _indirectly_ be dependent, but this is fine as I stated above > when suggested to move ACPI dependency on ARCH_xxx level. As per the response from the driver maintainer https://lore.kernel.org/linux-arm-kernel/bd8db435-24e1-5ab3-6b35-1d4d8a292a7e@hisilicon.com/, there is no dependency on ARCH_HISI, so moving the ACPI dependency up won't help. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds