From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729C6C433B4 for ; Tue, 13 Apr 2021 12:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5143261369 for ; Tue, 13 Apr 2021 12:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236591AbhDMMvA (ORCPT ); Tue, 13 Apr 2021 08:51:00 -0400 Received: from mail-vk1-f172.google.com ([209.85.221.172]:37510 "EHLO mail-vk1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345905AbhDMMsq (ORCPT ); Tue, 13 Apr 2021 08:48:46 -0400 Received: by mail-vk1-f172.google.com with SMTP id p206so1060810vkd.4; Tue, 13 Apr 2021 05:48:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BPCwCEu/tlD0sPdVV7Acf3Q88fdnLj8wuh/uaB99fZ0=; b=SxSg1XYx4RyYpuIGG8o9w0PpfCiC/84tJy6jumMgo888duy0YbQFzbvt4yUji2H89h lBLyIUiruh+dIMQC/YPCPiL90s5aEBe5FjsjaZHc1WN1MBxrP2112yy4sMTxd8csHGFm 404tXIc9leiIb04bO+lm+hudoOnhTdiRhLg0wdE9y/7/oi1hvTV/oUdoQxnZkpjnquuy Gt+tebNdPfwmPubPrIx3beAxjjT8yOKLqNuqe+6cM/5K+PVv6mwqIopJebHkY7OjtHRG oRwM7PUSk/wXn8HsvSBuj99IJXx9AlZM/89fONfmo4ciKOHy3UaaF1/i+63/BFLxWZQW fEdg== X-Gm-Message-State: AOAM5311/P1x8gka0sSnmoDXvIXdG6qLTn1U6Xp0C61SZ6QrrCp9y/HZ DCPM8CqhMv/aWp8eg/sii9q/xnWTiQDqzF14icg= X-Google-Smtp-Source: ABdhPJzV+Q6RQgrKzEVEruhMtyqX3cZ+hfIXaRTxVkQJ4gAkFfCxaCbMerKFjzCqhoZqkiQzh4ee87eJb2p6DQ1CyqQ= X-Received: by 2002:a1f:1f81:: with SMTP id f123mr567276vkf.6.1618318106468; Tue, 13 Apr 2021 05:48:26 -0700 (PDT) MIME-Version: 1.0 References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 13 Apr 2021 14:48:15 +0200 Message-ID: Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI To: Andy Shevchenko Cc: Yicong Yang , Wei Xu , Wolfram Sang , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi Andy, On Tue, Apr 13, 2021 at 2:37 PM Andy Shevchenko wrote: > On Tue, Apr 13, 2021 at 02:26:15PM +0200, Geert Uytterhoeven wrote: > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. > > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user > > about this driver when configuring a kernel without Hisilicon platform > > or ACPI firmware support. > > I don't by the ACPI dependency, sorry. > > The driver is a pure platform driver that can be enumerated on ACPI enabled > devices, but otherwise it can be used as a platform one. Sure, you can manually instantiate a platform device with a matching name, and set up the "clk_rate" device property. But would it make sense to do that? Would anyone ever do that? The corresponding SPI_HISI_KUNPENG depends on ACPI, too. > If you remove ACPI dependency, feel free to add my > Reviewed-by: Andy Shevchenko Thanks! ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds