From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org,
Alain Volmat <alain.volmat@st.com>
Subject: Re: [PATCH] i2c: core: do not use logical device when creating irq domain
Date: Mon, 27 Jul 2020 12:04:44 +0200 [thread overview]
Message-ID: <CAO-hwJ+VwOZ5Wcn2-5452ZQP8buFyuAZFsUpcidZV0VtzSFSBQ@mail.gmail.com> (raw)
In-Reply-To: <20200724194719.GF1227@ninjato>
On Fri, Jul 24, 2020 at 9:54 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> On Wed, Jul 01, 2020 at 10:23:18AM +0200, Wolfram Sang wrote:
> > Let's rather use its physical parent device to give proper namings and
> > connections in debugfs.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> >
> > This turns the name from "unknown-1" to ":soc:i2c@e6540000" in debugfs
> > for my use case.
> >
> > @Benjamin: I am not aware of any other side effects or regression
> > possibilites. Do you see any?
>
> Last call for opinions before I apply it ;)
Sorry for the late reply.
AFAICT, there should not be any side effects. This is internal API and
I don't think the callers need to walk through the tree anywhere. So
if that gives a vetter debugfs, why not.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> >
> > drivers/i2c/i2c-core-base.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> > index dc43242a85ba..69217d2193da 100644
> > --- a/drivers/i2c/i2c-core-base.c
> > +++ b/drivers/i2c/i2c-core-base.c
> > @@ -1227,7 +1227,7 @@ static int i2c_setup_host_notify_irq_domain(struct i2c_adapter *adap)
> > if (!i2c_check_functionality(adap, I2C_FUNC_SMBUS_HOST_NOTIFY))
> > return 0;
> >
> > - domain = irq_domain_create_linear(adap->dev.fwnode,
> > + domain = irq_domain_create_linear(adap->dev.parent->fwnode,
> > I2C_ADDR_7BITS_COUNT,
> > &i2c_host_notify_irq_ops, adap);
> > if (!domain)
> > --
> > 2.20.1
> >
next prev parent reply other threads:[~2020-07-27 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 8:23 [PATCH] i2c: core: do not use logical device when creating irq domain Wolfram Sang
2020-07-24 19:47 ` Wolfram Sang
2020-07-27 10:04 ` Benjamin Tissoires [this message]
2020-07-27 20:32 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO-hwJ+VwOZ5Wcn2-5452ZQP8buFyuAZFsUpcidZV0VtzSFSBQ@mail.gmail.com \
--to=benjamin.tissoires@redhat.com \
--cc=alain.volmat@st.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).