From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: mail@richard-neumann.de
Cc: syniurge@gmail.com, nehal-bakulchandra.shah@amd.com,
shyam-sundar.s-k@amd.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] Removed unused work_amd_i2c_common macro
Date: Fri, 29 Jan 2021 20:52:00 +0200 [thread overview]
Message-ID: <YBRZUHv+21FIQ/2g@smile.fi.intel.com> (raw)
In-Reply-To: <20210129182606.41518-3-mail@richard-neumann.de>
On Fri, Jan 29, 2021 at 07:26:06PM +0100, mail@richard-neumann.de wrote:
> From: Richard Neumann <mail@richard-neumann.de>
>
> The macro work_amd_i2c_common is not used anywhere in the driver.
> Removed it.
After addressing Subject as per comment against the previous patch, feel free
to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Richard Neumann <mail@richard-neumann.de>
> ---
> drivers/i2c/busses/i2c-amd-mp2.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-amd-mp2.h b/drivers/i2c/busses/i2c-amd-mp2.h
> index 6b91e285745d..ddecd0c88656 100644
> --- a/drivers/i2c/busses/i2c-amd-mp2.h
> +++ b/drivers/i2c/busses/i2c-amd-mp2.h
> @@ -185,9 +185,6 @@ struct amd_mp2_dev {
> unsigned int probed;
> };
>
> -#define work_amd_i2c_common(__work) \
> - container_of(__work, struct amd_i2c_common, work.work)
> -
> /* PCIe communication driver */
>
> int amd_mp2_rw(struct amd_i2c_common *i2c_common, enum i2c_cmd reqcmd);
> --
> 2.30.0
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-01-29 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 18:26 [PATCH v1 0/2] Cleanup i2c-amd-mp2 driver mail
2021-01-29 18:26 ` [PATCH v1 1/2] Removed NIH log functions mail
2021-01-29 18:50 ` Andy Shevchenko
2021-01-29 18:26 ` [PATCH v1 2/2] Removed unused work_amd_i2c_common macro mail
2021-01-29 18:52 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBRZUHv+21FIQ/2g@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@richard-neumann.de \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=syniurge@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).