From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D4EC433C1 for ; Wed, 24 Mar 2021 11:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29F4661A08 for ; Wed, 24 Mar 2021 11:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230500AbhCXLGZ (ORCPT ); Wed, 24 Mar 2021 07:06:25 -0400 Received: from mga18.intel.com ([134.134.136.126]:46277 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230318AbhCXLGP (ORCPT ); Wed, 24 Mar 2021 07:06:15 -0400 IronPort-SDR: 8O4DmIOtRYR66qFzA1eN4C/5oTRAnlxzPv73UyZqdy+YZvZslHKyLm0vIEbTwYliAovMgRy1vb B55j8FNyus9w== X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="178237462" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="178237462" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 04:06:14 -0700 IronPort-SDR: X5cTuCP8F8OdrSHhGFRehusBqOSRST4zmDHcUB4uPCwik2iVY7Z5qu097LmLJvt+zQLNAbOvRe bs9Y9u3xq3JQ== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="525204313" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 04:06:11 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lP1Ky-00FeHZ-SA; Wed, 24 Mar 2021 13:06:08 +0200 Date: Wed, 24 Mar 2021 13:06:08 +0200 From: Andy Shevchenko To: Yicong Yang Cc: Dmitry Osipenko , wsa@kernel.org, linux-i2c@vger.kernel.org, treding@nvidia.com, jarkko.nikula@linux.intel.com, rmk+kernel@armlinux.org.uk, song.bao.hua@hisilicon.com, john.garry@huawei.com, prime.zeng@huawei.com, linuxarm@huawei.com Subject: Re: [PATCH v3 1/3] i2c: core: add managed function for adding i2c adapters Message-ID: References: <1616411413-7177-1-git-send-email-yangyicong@hisilicon.com> <1616411413-7177-2-git-send-email-yangyicong@hisilicon.com> <23efcf01-5d04-242e-8574-bb9a5ef5face@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <23efcf01-5d04-242e-8574-bb9a5ef5face@hisilicon.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, Mar 24, 2021 at 04:29:26PM +0800, Yicong Yang wrote: > On 2021/3/23 0:45, Dmitry Osipenko wrote: > > 22.03.2021 14:10, Yicong Yang пишет: ... > >> +EXPORT_SYMBOL(devm_i2c_add_adapter); > > > > EXPORT_SYMBOL_GPL > > considering i2c_add_adapter exported with no GPL, i think the variant should > keep the same. Nope. You should follow other devm_*() APIs. Hint: they are using struct device which is GPL. Please, fix. -- With Best Regards, Andy Shevchenko