Linux-i2c Archive on lore.kernel.org
 help / color / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yicong Yang <yangyicong@hisilicon.com>,
	Wei Xu <xuwei5@hisilicon.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI
Date: Tue, 13 Apr 2021 18:19:11 +0300
Message-ID: <YHW2b4aBHh3ohs8r@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdV1kTcPhutZZa04zd53C37Ci7Fr51nq1z8OX3kg1C14CA@mail.gmail.com>

On Tue, Apr 13, 2021 at 04:44:33PM +0200, Geert Uytterhoeven wrote:
> On Tue, Apr 13, 2021 at 4:41 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Apr 13, 2021 at 02:48:15PM +0200, Geert Uytterhoeven wrote:
> > > On Tue, Apr 13, 2021 at 2:37 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Tue, Apr 13, 2021 at 02:26:15PM +0200, Geert Uytterhoeven wrote:
> > > > > The HiSilicon Kunpeng I2C controller is only present on HiSilicon
> > > > > Kunpeng SoCs, and its driver relies on ACPI to probe for its presence.
> > > > > Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user
> > > > > about this driver when configuring a kernel without Hisilicon platform
> > > > > or ACPI firmware support.
> > > >
> > > > I don't by the ACPI dependency, sorry.
> > > >
> > > > The driver is a pure platform driver that can be enumerated on ACPI enabled
> > > > devices, but otherwise it can be used as a platform one.
> > >
> > > Sure, you can manually instantiate a platform device with a matching
> > > name, and set up the "clk_rate" device property.
> > > But would it make sense to do that? Would anyone ever do that?
> >
> > It will narrow down the possibility to have One Kernel for as many as possible
> > platforms.
> 
> That One Kernel needs to have CONFIG_ACPI enabled to use I2C on the
> HiSilicon Kunpeng.  If CONFIG_ACPI is disabled, it cannot be used, as there
> is no other code that creates "hisi-i2c" platform devices.

It is fine, but since you add a dependency to the ARCH variant, the ACPI should
be added there, not here. Here is simply wrong place for this dependency as driver
is *not* dependent on ACPI per se.

-- 
With Best Regards,
Andy Shevchenko



  reply index

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 12:26 Geert Uytterhoeven
2021-04-13 12:36 ` Andy Shevchenko
2021-04-13 12:48   ` Geert Uytterhoeven
2021-04-13 14:41     ` Andy Shevchenko
2021-04-13 14:44       ` Geert Uytterhoeven
2021-04-13 15:19         ` Andy Shevchenko [this message]
2021-04-14  9:19 ` Yicong Yang
2021-04-14 18:06   ` Geert Uytterhoeven
2021-04-14 18:18     ` Andy Shevchenko
2021-04-14 18:55       ` Geert Uytterhoeven
2021-04-14 19:14         ` Andy Shevchenko
2021-04-14 19:21           ` Geert Uytterhoeven
2021-04-15  8:50             ` Andy Shevchenko
2021-04-19 13:02               ` Geert Uytterhoeven
2021-04-19 13:31                 ` Andy Shevchenko
2021-04-19 13:54                   ` Geert Uytterhoeven
2021-04-19 13:58                     ` Andy Shevchenko
2021-04-19 14:14                       ` Andy Shevchenko
2021-04-19 14:18                         ` Geert Uytterhoeven
2021-04-19 14:27                           ` Andy Shevchenko
2021-04-19 14:15                       ` Geert Uytterhoeven
2021-04-19 14:39                         ` Andy Shevchenko
2021-04-15  8:18     ` Yicong Yang
2021-04-15  9:04       ` Yicong Yang
2021-04-15 10:36         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHW2b4aBHh3ohs8r@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=digetx@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=xuwei5@hisilicon.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-i2c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i2c/0 linux-i2c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i2c linux-i2c/ https://lore.kernel.org/linux-i2c \
		linux-i2c@vger.kernel.org
	public-inbox-index linux-i2c

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-i2c


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git