Linux-i2c Archive on lore.kernel.org
 help / color / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yicong Yang <yangyicong@hisilicon.com>,
	Masahiro Yamada <masahiroy@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Wei Xu <xuwei5@hisilicon.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI
Date: Thu, 15 Apr 2021 13:36:24 +0300
Message-ID: <YHgXKHvjnC5qzDPy@smile.fi.intel.com> (raw)
In-Reply-To: <39f6bbed-9eea-963a-1ef1-a83248f162aa@hisilicon.com>

On Thu, Apr 15, 2021 at 05:04:39PM +0800, Yicong Yang wrote:
> On 2021/4/15 16:18, Yicong Yang wrote:
> > On 2021/4/15 2:06, Geert Uytterhoeven wrote:
> >> On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang <yangyicong@hisilicon.com> wrote:
> >>> On 2021/4/13 20:26, Geert Uytterhoeven wrote:
> >>>> The HiSilicon Kunpeng I2C controller is only present on HiSilicon
> >>>> Kunpeng SoCs, and its driver relies on ACPI to probe for its presence.
> >>>> Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user
> >>>> about this driver when configuring a kernel without Hisilicon platform
> >>>> or ACPI firmware support.
> >>>
> >>> this is a public IP which doesn't specifically depend on ARCH_HISI. I'm
> >>> not sure all the platform this IP on has ARCH_HISI configured. The driver
> >>> will not be compiled by default config. This is not correct to have
> >>> this dependence.
> >>
> >> Thanks for your answer!
> >>
> >> I guess it's still fine to add a dependency on ACPI?
> > 
> > yes. currently we only use this driver through ACPI. So at least
> > for this driver, it make sense to keep the dependency.
> > 
> 
> sorry. i was a little mess about this. I dropped this in [1].
> so just keep it as is.
> 
> [1] https://lore.kernel.org/linux-i2c/YGMntYT2iz72wgrd@smile.fi.intel.com/

If you think that ACPI dependency is good to have there, go ahead, not my
worries of the consequences. I just consider that as unneeded dependencies.

The proper fix would be to have a split in Kbuild infra for compile
dependencies and run-time dependencies.

+Cc: Masahiro for the discussion, maybe it had already taken place and there is
an impediment to do so.

-- 
With Best Regards,
Andy Shevchenko



      reply index

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 12:26 Geert Uytterhoeven
2021-04-13 12:36 ` Andy Shevchenko
2021-04-13 12:48   ` Geert Uytterhoeven
2021-04-13 14:41     ` Andy Shevchenko
2021-04-13 14:44       ` Geert Uytterhoeven
2021-04-13 15:19         ` Andy Shevchenko
2021-04-14  9:19 ` Yicong Yang
2021-04-14 18:06   ` Geert Uytterhoeven
2021-04-14 18:18     ` Andy Shevchenko
2021-04-14 18:55       ` Geert Uytterhoeven
2021-04-14 19:14         ` Andy Shevchenko
2021-04-14 19:21           ` Geert Uytterhoeven
2021-04-15  8:50             ` Andy Shevchenko
2021-04-19 13:02               ` Geert Uytterhoeven
2021-04-19 13:31                 ` Andy Shevchenko
2021-04-19 13:54                   ` Geert Uytterhoeven
2021-04-19 13:58                     ` Andy Shevchenko
2021-04-19 14:14                       ` Andy Shevchenko
2021-04-19 14:18                         ` Geert Uytterhoeven
2021-04-19 14:27                           ` Andy Shevchenko
2021-04-19 14:15                       ` Geert Uytterhoeven
2021-04-19 14:39                         ` Andy Shevchenko
2021-04-15  8:18     ` Yicong Yang
2021-04-15  9:04       ` Yicong Yang
2021-04-15 10:36         ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YHgXKHvjnC5qzDPy@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=digetx@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=masahiroy@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=xuwei5@hisilicon.com \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-i2c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i2c/0 linux-i2c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i2c linux-i2c/ https://lore.kernel.org/linux-i2c \
		linux-i2c@vger.kernel.org
	public-inbox-index linux-i2c

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-i2c


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git