From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE8F7C433B4 for ; Thu, 15 Apr 2021 10:36:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7232613A9 for ; Thu, 15 Apr 2021 10:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232364AbhDOKg4 (ORCPT ); Thu, 15 Apr 2021 06:36:56 -0400 Received: from mga07.intel.com ([134.134.136.100]:25587 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232233AbhDOKgy (ORCPT ); Thu, 15 Apr 2021 06:36:54 -0400 IronPort-SDR: IEnvXnyjXYVYrezVu2r7nicDeVzAtyb8S0rdydNq79UhbqEiDRsnPpEXbaXNmKs2Px+FIh7zcE U5zbpfhWH4FQ== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="258789617" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="258789617" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 03:36:30 -0700 IronPort-SDR: JWGyp9+PPSR53zav66bKAZd/Xsmd/rWmwo2rlRUx4L7nniUkwlQUJOrKA7mp+07hmz2SRoJI37 Rul1GLppECHQ== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="399530258" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 03:36:27 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lWzMG-004DhB-5Q; Thu, 15 Apr 2021 13:36:24 +0300 Date: Thu, 15 Apr 2021 13:36:24 +0300 From: Andy Shevchenko To: Yicong Yang , Masahiro Yamada Cc: Geert Uytterhoeven , Geert Uytterhoeven , Wei Xu , Wolfram Sang , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List , Linuxarm Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI Message-ID: References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> <21d833f0-b1b8-9732-21c7-3a73676e07d3@hisilicon.com> <39f6bbed-9eea-963a-1ef1-a83248f162aa@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39f6bbed-9eea-963a-1ef1-a83248f162aa@hisilicon.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, Apr 15, 2021 at 05:04:39PM +0800, Yicong Yang wrote: > On 2021/4/15 16:18, Yicong Yang wrote: > > On 2021/4/15 2:06, Geert Uytterhoeven wrote: > >> On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang wrote: > >>> On 2021/4/13 20:26, Geert Uytterhoeven wrote: > >>>> The HiSilicon Kunpeng I2C controller is only present on HiSilicon > >>>> Kunpeng SoCs, and its driver relies on ACPI to probe for its presence. > >>>> Hence add dependencies on ARCH_HISI and ACPI, to prevent asking the user > >>>> about this driver when configuring a kernel without Hisilicon platform > >>>> or ACPI firmware support. > >>> > >>> this is a public IP which doesn't specifically depend on ARCH_HISI. I'm > >>> not sure all the platform this IP on has ARCH_HISI configured. The driver > >>> will not be compiled by default config. This is not correct to have > >>> this dependence. > >> > >> Thanks for your answer! > >> > >> I guess it's still fine to add a dependency on ACPI? > > > > yes. currently we only use this driver through ACPI. So at least > > for this driver, it make sense to keep the dependency. > > > > sorry. i was a little mess about this. I dropped this in [1]. > so just keep it as is. > > [1] https://lore.kernel.org/linux-i2c/YGMntYT2iz72wgrd@smile.fi.intel.com/ If you think that ACPI dependency is good to have there, go ahead, not my worries of the consequences. I just consider that as unneeded dependencies. The proper fix would be to have a split in Kbuild infra for compile dependencies and run-time dependencies. +Cc: Masahiro for the discussion, maybe it had already taken place and there is an impediment to do so. -- With Best Regards, Andy Shevchenko