From: Wolfram Sang <wsa@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Jie Deng <jie.deng@intel.com>,
linux-i2c@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, mst@redhat.com, arnd@arndb.de,
jasowang@redhat.com, andriy.shevchenko@linux.intel.com,
yu1.wang@intel.com, shuo.a.liu@intel.com, conghui.chen@intel.com,
stefanha@redhat.com
Subject: Re: [PATCH v11] i2c: virtio: add a virtio i2c frontend driver
Date: Thu, 1 Jul 2021 21:24:40 +0200 [thread overview]
Message-ID: <YN4WeJCepCrpylOD@kunai> (raw)
In-Reply-To: <20210701040436.p7kega6rzeqz5tlm@vireshk-i7>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
> I just noticed this now, but this function even tries to send data
> partially, which isn't right. If the caller (i2c device's driver)
> calls this for 5 struct i2c_msg instances, then all 5 need to get
> through or none.. where as we try to send as many as possible here.
>
> This looks broken to me. Rather return an error value here on success,
> or make it complete failure.
>
> Though to be fair I see i2c-core also returns number of messages
> processed from i2c_transfer().
>
> Wolfram, what's expected here ? Shouldn't all message transfer or
> none?
Well, on a physical bus, it can simply happen that after message 3 of 5,
the bus is stalled, so we need to bail out.
Again, I am missing details of a virtqueue, but I'd think it is
different. If adding to the queue fails, then it probably make sense to
drop the whole transfer.
Of course, it can later happen on the physical bus of the host, though,
that the bus is stalled after message 3 of 5, and I2C_RDWR will bail
out.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-01 19:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 3:24 [PATCH v11] i2c: virtio: add a virtio i2c frontend driver Jie Deng
2021-07-01 4:04 ` Viresh Kumar
2021-07-01 6:10 ` Jie Deng
2021-07-01 6:18 ` Viresh Kumar
2021-07-02 3:36 ` Jie Deng
2021-07-02 4:56 ` Viresh Kumar
2021-07-01 19:24 ` Wolfram Sang [this message]
2021-07-02 4:55 ` Viresh Kumar
2021-07-02 6:22 ` Wolfram Sang
2021-07-02 6:52 ` Jie Deng
2021-07-02 6:56 ` Viresh Kumar
2021-07-02 7:11 ` Wolfram Sang
2021-07-02 7:15 ` Jie Deng
2021-07-02 7:21 ` Viresh Kumar
2021-07-02 7:36 ` Wolfram Sang
2021-07-01 8:50 ` kernel test robot
2021-07-01 10:00 ` kernel test robot
2021-07-02 3:12 ` Jie Deng
2021-07-02 6:38 ` [kbuild-all] " Rong Chen
2021-07-01 10:45 ` Andy Shevchenko
2021-07-02 1:05 ` Jie Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN4WeJCepCrpylOD@kunai \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=conghui.chen@intel.com \
--cc=jasowang@redhat.com \
--cc=jie.deng@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=shuo.a.liu@intel.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yu1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).