From: Wolfram Sang <wsa@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
f.fainelli@gmail.com
Subject: Re: [PATCH -next] i2c: bcm2835: add missing disable and put clk on error in bcm2835_i2c_probe()
Date: Mon, 7 Feb 2022 15:49:44 +0100 [thread overview]
Message-ID: <YgExiKpGzpr01Bbf@shikoro> (raw)
In-Reply-To: <20210601140835.3595921-1-yangyingliang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Tue, Jun 01, 2021 at 10:08:35PM +0800, Yang Yingliang wrote:
> Add clk_disable_unprepare() and clk_rate_exclusive_put() on error
> path in bcm2835_i2c_probe().
>
> Fixes: bebff81fb8b9 ("i2c: bcm2835: Model Divider in CCF")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Correct, but I applied another version instead which was a tad better:
http://patchwork.ozlabs.org/project/linux-i2c/patch/338008c444af4785a07fb5a402b60225a4964ae9.1629484876.git.christophe.jaillet@wanadoo.fr/
But thanks for working on it!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-02-07 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 14:08 [PATCH -next] i2c: bcm2835: add missing disable and put clk on error in bcm2835_i2c_probe() Yang Yingliang
2022-02-07 14:49 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgExiKpGzpr01Bbf@shikoro \
--to=wsa@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).