From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, jsd@semihalf.com,
Jose.Abreu@synopsys.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, linux-i2c@vger.kernel.org,
linux-gpio@vger.kernel.org, mengyuanlou@net-swift.com,
Piotr Raczynski <piotr.raczynski@intel.com>
Subject: Re: [PATCH net-next v9 4/9] net: txgbe: Register I2C platform device
Date: Sat, 27 May 2023 11:38:48 +0300 [thread overview]
Message-ID: <ZHHBmJwwaw1KynB9@smile.fi.intel.com> (raw)
In-Reply-To: <20230524091722.522118-5-jiawenwu@trustnetic.com>
On Wed, May 24, 2023 at 05:17:17PM +0800, Jiawen Wu wrote:
> Register the platform device to use Designware I2C bus master driver.
> Use regmap to read/write I2C device region from given base offset.
...
> +#include <linux/platform_device.h>
Can this be ordered (to some extent), please?
> #include <linux/gpio/property.h>
> #include <linux/clk-provider.h>
> #include <linux/clkdev.h>
> +#include <linux/regmap.h>
This too.
> #include <linux/i2c.h>
> #include <linux/pci.h>
Somewhere here...
...
Otherwise looks good, thank you.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-05-27 8:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 9:17 [PATCH net-next v9 0/9] TXGBE PHYLINK support Jiawen Wu
2023-05-24 9:17 ` [PATCH net-next v9 1/9] net: txgbe: Add software nodes to support phylink Jiawen Wu
2023-05-27 8:44 ` Andy Shevchenko
2023-05-30 6:11 ` Jiawen Wu
2023-05-30 10:45 ` andy.shevchenko
2023-05-24 9:17 ` [PATCH net-next v9 2/9] i2c: designware: Add driver support for Wangxun 10Gb NIC Jiawen Wu
2023-05-27 8:36 ` Andy Shevchenko
2023-05-24 9:17 ` [PATCH net-next v9 3/9] net: txgbe: Register fixed rate clock Jiawen Wu
2023-05-24 12:17 ` Andrew Lunn
2023-05-24 9:17 ` [PATCH net-next v9 4/9] net: txgbe: Register I2C platform device Jiawen Wu
2023-05-26 9:35 ` kernel test robot
2023-05-27 8:38 ` Andy Shevchenko [this message]
2023-05-24 9:17 ` [PATCH net-next v9 5/9] net: txgbe: Add SFP module identify Jiawen Wu
2023-05-26 11:30 ` kernel test robot
2023-05-26 11:36 ` Russell King (Oracle)
2023-05-29 2:06 ` Jiawen Wu
2023-05-30 8:40 ` Jiawen Wu
2023-05-31 9:19 ` Jiawen Wu
2023-05-31 9:47 ` Russell King (Oracle)
2023-05-31 10:11 ` Jiawen Wu
2023-05-24 9:17 ` [PATCH net-next v9 6/9] net: txgbe: Support GPIO to SFP socket Jiawen Wu
2023-05-24 12:51 ` Andrew Lunn
2023-05-24 13:07 ` Russell King (Oracle)
2023-05-24 9:17 ` [PATCH net-next v9 7/9] net: pcs: Add 10GBASE-R mode for Synopsys Designware XPCS Jiawen Wu
2023-05-24 9:17 ` [PATCH net-next v9 8/9] net: txgbe: Implement phylink pcs Jiawen Wu
2023-05-24 12:53 ` Andrew Lunn
2023-05-26 4:14 ` Jakub Kicinski
2023-05-26 6:21 ` Jiawen Wu
2023-05-26 8:43 ` Russell King (Oracle)
2023-05-26 9:01 ` Jiawen Wu
2023-05-26 9:07 ` Russell King (Oracle)
2023-05-26 9:22 ` Jiawen Wu
2023-05-26 9:37 ` Russell King (Oracle)
2023-05-26 10:42 ` Russell King (Oracle)
2023-05-29 1:57 ` Jiawen Wu
2023-05-24 9:17 ` [PATCH net-next v9 9/9] net: txgbe: Support phylink MAC layer Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHHBmJwwaw1KynB9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jose.Abreu@synopsys.com \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=jsd@semihalf.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=mika.westerberg@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=piotr.raczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).