From: Daniel Golle <daniel@makrotopia.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Qii Wang" <qii.wang@mediatek.com>,
"Sam Shih" <sam.shih@mediatek.com>, 郭小桥 <joe@gainstrong.cn>
Subject: Re: [PATCH 1/2] dt-bindings: i2c: i2c-mt65xx: add additional clocks
Date: Thu, 1 Jun 2023 20:10:11 +0100 [thread overview]
Message-ID: <ZHjtExYIdVFo3HnB@makrotopia.org> (raw)
In-Reply-To: <12fea13e-e2c3-487f-8d2b-cfd320c98ba7@linaro.org>
On Thu, Jun 01, 2023 at 06:54:01PM +0200, Krzysztof Kozlowski wrote:
> On 31/05/2023 18:10, Daniel Golle wrote:
> > Add pck and mck clocks which are needed to access I2C registers on MT7981.
> >
> > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> > index fda0467cdd954..550795f6573c5 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
> > @@ -78,6 +78,8 @@ properties:
> > - const: dma
> > - const: arb
> > - const: pmic
> > + - const: mck
> > + - const: pck
> >
>
> Adding names does not magically add the clocks. This wasn't tested.
Adding the clocks is done in patch 2/2 which just wasn't sent to
devicetree@ and dt maintainers, but to the relevant mailing lists
instead. Was that wrong and should I always send the complete series
also to devicetree@ as well as dt maintainers?
Anyway. It turns out that arb and pmic clocks are intended for that,
so we can cancel this and I'll just use those instead.
next prev parent reply other threads:[~2023-06-01 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 16:10 [PATCH 1/2] dt-bindings: i2c: i2c-mt65xx: add additional clocks Daniel Golle
2023-05-31 16:11 ` [PATCH 2/2] i2c: mt65xx: " Daniel Golle
2023-06-01 9:18 ` AngeloGioacchino Del Regno
2023-06-01 16:54 ` [PATCH 1/2] dt-bindings: i2c: i2c-mt65xx: " Krzysztof Kozlowski
2023-06-01 19:10 ` Daniel Golle [this message]
2023-06-01 20:16 ` Conor Dooley
2023-06-02 7:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHjtExYIdVFo3HnB@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joe@gainstrong.cn \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sam.shih@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).