* [PATCH 3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource()
@ 2023-03-06 14:45 Md Sadre Alam
2023-06-07 10:34 ` Wolfram Sang
2023-06-08 19:26 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Md Sadre Alam @ 2023-03-06 14:45 UTC (permalink / raw)
To: loic.poulain, rfoss, linux-i2c, linux-arm-msm, linux-kernel
Cc: quic_sjaganat, quic_srichara, quic_varada, quic_mdalam
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
---
drivers/i2c/busses/i2c-qcom-cci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index 01358472680c..ed70bc1e4926 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -581,8 +581,7 @@ static int cci_probe(struct platform_device *pdev)
/* Memory */
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- cci->base = devm_ioremap_resource(dev, r);
+ cci->base = devm_platform_get_and_ioremap_resource(pdev, 0, &r);
if (IS_ERR(cci->base))
return PTR_ERR(cci->base);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource()
2023-03-06 14:45 [PATCH 3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource() Md Sadre Alam
@ 2023-06-07 10:34 ` Wolfram Sang
2023-06-07 12:25 ` Robert Foss
2023-06-08 19:26 ` Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2023-06-07 10:34 UTC (permalink / raw)
To: Md Sadre Alam
Cc: loic.poulain, rfoss, linux-i2c, linux-arm-msm, linux-kernel,
quic_sjaganat, quic_srichara, quic_varada
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Mon, Mar 06, 2023 at 08:15:22PM +0530, Md Sadre Alam wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
Loic, Robert, do you agree with this patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource()
2023-06-07 10:34 ` Wolfram Sang
@ 2023-06-07 12:25 ` Robert Foss
0 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2023-06-07 12:25 UTC (permalink / raw)
To: Wolfram Sang, Md Sadre Alam, loic.poulain, rfoss, linux-i2c,
linux-arm-msm, linux-kernel, quic_sjaganat, quic_srichara,
quic_varada
On Wed, Jun 7, 2023 at 12:34 PM Wolfram Sang <wsa@kernel.org> wrote:
>
> On Mon, Mar 06, 2023 at 08:15:22PM +0530, Md Sadre Alam wrote:
> > Convert platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.
> >
> > Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
>
> Loic, Robert, do you agree with this patch?
>
Acked-by: Robert Foss <rfoss@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource()
2023-03-06 14:45 [PATCH 3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource() Md Sadre Alam
2023-06-07 10:34 ` Wolfram Sang
@ 2023-06-08 19:26 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2023-06-08 19:26 UTC (permalink / raw)
To: Md Sadre Alam
Cc: loic.poulain, rfoss, linux-i2c, linux-arm-msm, linux-kernel,
quic_sjaganat, quic_srichara, quic_varada
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
On Mon, Mar 06, 2023 at 08:15:22PM +0530, Md Sadre Alam wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
Applied to for-next, thanks! Also, thanks, Robert.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-08 19:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-06 14:45 [PATCH 3/5] i2c: qcom-cci:Use devm_platform_get_and_ioremap_resource() Md Sadre Alam
2023-06-07 10:34 ` Wolfram Sang
2023-06-07 12:25 ` Robert Foss
2023-06-08 19:26 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).