From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: "Ard Biesheuvel" <ardb@kernel.org>,
"Barry Song" <baohua@kernel.org>,
"Baruch Siach" <baruch@tkos.co.il>,
"Fabio Estevam" <festevam@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Heiko Stübner" <heiko@sntech.de>,
"Kevin Hilman" <khilman@baylibre.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [PATCH v2 1/2] drivers: provide devm_platform_request_irq()
Date: Sun, 24 May 2020 09:00:28 +0200 [thread overview]
Message-ID: <b0a8e1be-359a-17bf-0eb8-dcf175042811@web.de> (raw)
> It will call devm_request_irq() after platform_get_irq() function
> in many drivers, sometimes, it is not right for the error handling
> of these two functions in some drivers. so provide this function
> to simplify the driver.
I recommend to improve also this change description.
How do you think about a wording variant like the following?
The function “devm_request_irq” is called after the
function “platform_get_irq” in many drivers.
The exception handling is incomplete there sometimes.
Thus add a corresponding wrapper function for the simplification
of the drivers.
Will a companion script for the semantic patch language (Coccinelle software)
become helpful for further support of collateral evolution?
Regards,
Markus
next reply other threads:[~2020-05-24 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 7:00 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-23 14:51 [PATCH v2 0/2] drivers: provide devm_platform_request_irq() Dejin Zheng
2020-05-23 14:51 ` [PATCH v2 1/2] " Dejin Zheng
2020-05-26 17:11 ` Grygorii Strashko
2020-05-27 13:31 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0a8e1be-359a-17bf-0eb8-dcf175042811@web.de \
--to=markus.elfring@web.de \
--cc=ardb@kernel.org \
--cc=baohua@kernel.org \
--cc=baruch@tkos.co.il \
--cc=cocci@systeme.lip6.fr \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=paul@crapouillou.net \
--cc=rafael@kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).