From: Samuel Holland <samuel@sholland.org>
To: Andre Przywara <andre.przywara@arm.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>
Cc: "Icenowy Zheng" <icenowy@aosc.io>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Clément Péron" <peron.clem@gmail.com>,
"Shuosheng Huang" <huangshuosheng@allwinnertech.com>,
"Yangtao Li" <tiny.windzz@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Mark Brown" <broonie@kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-media@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 18/21] dt-bindings: allwinner: Add H616 compatible strings
Date: Sun, 17 Jan 2021 22:28:47 -0600 [thread overview]
Message-ID: <c21019af-a6e4-4a06-5307-23b227d25934@sholland.org> (raw)
In-Reply-To: <20210118020848.11721-19-andre.przywara@arm.com>
On 1/17/21 8:08 PM, Andre Przywara wrote:
> Add simple "allwinner,sun50i-h616-xxx" compatible names to existing
> bindings, and pair them with an existing fallback compatible string,
> as the devices are compatible.
> This covers I2C, infrared, RTC and SPI.
>
> Use enums to group all compatible devices together.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C
> ---
> .../bindings/i2c/marvell,mv64xxx-i2c.yaml | 21 +++++++------------
> .../media/allwinner,sun4i-a10-ir.yaml | 16 ++++++--------
> .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 3 +++
> .../bindings/spi/allwinner,sun6i-a31-spi.yaml | 1 +
> 4 files changed, 17 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> index 5b5ae402f97a..eb72dd571def 100644
> --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -18,21 +18,14 @@ properties:
> - const: allwinner,sun4i-a10-i2c
> - const: allwinner,sun6i-a31-i2c
> - items:
> - - const: allwinner,sun8i-a23-i2c
> + - enum:
> + - allwinner,sun8i-a23-i2c
> + - allwinner,sun8i-a83t-i2c
> + - allwinner,sun50i-a64-i2c
> + - allwinner,sun50i-a100-i2c
> + - allwinner,sun50i-h6-i2c
> + - allwinner,sun50i-h616-i2c
> - const: allwinner,sun6i-a31-i2c
> - - items:
> - - const: allwinner,sun8i-a83t-i2c
> - - const: allwinner,sun6i-a31-i2c
> - - items:
> - - const: allwinner,sun50i-a64-i2c
> - - const: allwinner,sun6i-a31-i2c
> - - items:
> - - const: allwinner,sun50i-a100-i2c
> - - const: allwinner,sun6i-a31-i2c
> - - items:
> - - const: allwinner,sun50i-h6-i2c
> - - const: allwinner,sun6i-a31-i2c
> -
> - const: marvell,mv64xxx-i2c
> - const: marvell,mv78230-i2c
> - const: marvell,mv78230-a0-i2c
> diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-ir.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-ir.yaml
> index 5fa19d4aeaf3..6d8395d6bca0 100644
> --- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-ir.yaml
> +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-ir.yaml
> @@ -20,16 +20,12 @@ properties:
> - const: allwinner,sun5i-a13-ir
> - const: allwinner,sun6i-a31-ir
> - items:
> - - const: allwinner,sun8i-a83t-ir
> - - const: allwinner,sun6i-a31-ir
> - - items:
> - - const: allwinner,sun8i-r40-ir
> - - const: allwinner,sun6i-a31-ir
> - - items:
> - - const: allwinner,sun50i-a64-ir
> - - const: allwinner,sun6i-a31-ir
> - - items:
> - - const: allwinner,sun50i-h6-ir
> + - enum:
> + - allwinner,sun8i-a83t-ir
> + - allwinner,sun8i-r40-ir
> + - allwinner,sun50i-a64-ir
> + - allwinner,sun50i-h6-ir
> + - allwinner,sun50i-h616-ir
> - const: allwinner,sun6i-a31-ir
>
> reg:
> diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> index 37c2a601c3fa..97928efd2bc9 100644
> --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml
> @@ -26,6 +26,9 @@ properties:
> - const: allwinner,sun50i-a64-rtc
> - const: allwinner,sun8i-h3-rtc
> - const: allwinner,sun50i-h6-rtc
> + - items:
> + - const: allwinner,sun50i-h616-rtc
> + - const: allwinner,sun50i-h6-rtc
Since H6, the RTC manages the 24 MHz DCXO, so it provides a fourth clock
output. If this is easy to change later, then it is fine for now, but
maybe it is better to get the H616 binding correct from the beginning?
Cheers,
Samuel
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> index 7866a655d81c..908248260afa 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> @@ -25,6 +25,7 @@ properties:
> - enum:
> - allwinner,sun8i-r40-spi
> - allwinner,sun50i-h6-spi
> + - allwinner,sun50i-h616-spi
> - const: allwinner,sun8i-h3-spi
>
> reg:
>
next prev parent reply other threads:[~2021-01-18 4:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210118020848.11721-1-andre.przywara@arm.com>
2021-01-18 2:08 ` [PATCH v3 18/21] dt-bindings: allwinner: Add H616 compatible strings Andre Przywara
2021-01-18 4:28 ` Samuel Holland [this message]
2021-01-25 11:59 ` Andre Przywara
2021-01-18 12:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c21019af-a6e4-4a06-5307-23b227d25934@sholland.org \
--to=samuel@sholland.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=huangshuosheng@allwinnertech.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).