From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE01FC07E99 for ; Mon, 5 Jul 2021 19:07:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8FA661982 for ; Mon, 5 Jul 2021 19:07:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbhGETKO (ORCPT ); Mon, 5 Jul 2021 15:10:14 -0400 Received: from mxout03.lancloud.ru ([45.84.86.113]:49690 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229809AbhGETKN (ORCPT ); Mon, 5 Jul 2021 15:10:13 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru E415720D4741 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH v2 2/3] i2c: pca-platform: fix deferred probing From: Sergey Shtylyov To: References: <67f7fcd8-797f-b943-02f7-38a0685e96f9@omp.ru> Organization: Open Mobile Platform Message-ID: Date: Mon, 5 Jul 2021 22:07:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <67f7fcd8-797f-b943-02f7-38a0685e96f9@omp.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hello! On 6/24/21 11:23 PM, Sergey Shtylyov wrote: > The driver's probe() method chooses the polling mode if an IRQ # returned > by platform_get_irq_optional() is 0 or less. We'll have to filter out > -EPROBE_DEFER earlier for the deferred probing to work... > > Fixes: 0e8ce93bdceb ("i2c: pca-platform: add devicetree awareness") > Signed-off-by: Sergey Shtylyov > > --- > Changed in version 2: > - new patch. > > drivers/i2c/busses/i2c-pca-platform.c | 2 ++ > 1 file changed, 2 insertions(+) > > Index: linux/drivers/i2c/busses/i2c-pca-platform.c > =================================================================== > --- linux.orig/drivers/i2c/busses/i2c-pca-platform.c > +++ linux/drivers/i2c/busses/i2c-pca-platform.c > @@ -139,6 +139,8 @@ static int i2c_pca_pf_probe(struct platf > int irq; > > irq = platform_get_irq_optional(pdev, 0); > + if (irq == -EPROBE_DEFER) > + return irq; Perhaps we should just use the polling mode? Or is this change still helpful? > /* If irq is 0, we do polling. */ > if (irq < 0) > irq = 0; > MBR, Sergei