From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: carlos.song@nxp.com, aisheng.dong@nxp.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
Anson.Huang@nxp.com
Cc: xiaoning.wang@nxp.com, haibo.chen@nxp.com, linux-imx@nxp.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: i2c: imx-lpi2c: Add bus recovery example
Date: Tue, 30 May 2023 16:58:32 +0200 [thread overview]
Message-ID: <ed004607-5a23-564a-3185-a63af87783e5@linaro.org> (raw)
In-Reply-To: <20230529074302.3612294-2-carlos.song@nxp.com>
On 29/05/2023 09:43, carlos.song@nxp.com wrote:
> From: Clark Wang <xiaoning.wang@nxp.com>
>
> Add i2c bus recovery configuration example.
Why? That's just example... also with coding style issue.
>
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Signed-off-by: Carlos Song <carlos.song@nxp.com>
> ---
> .../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> index 4656f5112b84..62ee457496e4 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml
> @@ -58,6 +58,16 @@ properties:
> power-domains:
> maxItems: 1
>
> + pinctrl-names:
> + minItems: 1
> + maxItems: 3
What's the benefit of this? Entries should be defined but without it is
not really helpful. Anyway not explained in commit msg.
> +
> + scl-gpios:
> + maxItems: 1
> +
> + sda-gpios:
> + maxItems: 1
You don't need these two. Anyway not explained in commit msg.
> +
> required:
> - compatible
> - reg
> @@ -70,6 +80,7 @@ examples:
> - |
> #include <dt-bindings/clock/imx7ulp-clock.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/gpio/gpio.h>
>
> i2c@40a50000 {
> compatible = "fsl,imx7ulp-lpi2c";
> @@ -78,4 +89,9 @@ examples:
> interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks IMX7ULP_CLK_LPI2C7>,
> <&clks IMX7ULP_CLK_NIC1_BUS_DIV>;
> + pinctrl-names = "default","gpio";
Missing space.
> + pinctrl-0 = <&pinctrl_i2c>;
> + pinctrl-1 = <&pinctrl_i2c_recovery>;
> + scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> };
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-30 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 7:43 [PATCH 1/2] i2c: imx-lpi2c: add bus recovery feature carlos.song
2023-05-29 7:43 ` [PATCH 2/2] dt-bindings: i2c: imx-lpi2c: Add bus recovery example carlos.song
2023-05-30 14:58 ` Krzysztof Kozlowski [this message]
2023-05-31 10:22 ` [EXT] " Carlos Song
2023-06-02 13:18 ` Krzysztof Kozlowski
2023-06-13 22:42 ` Andi Shyti
2023-07-24 9:48 ` Carlos Song
2023-06-13 23:19 ` [PATCH 1/2] i2c: imx-lpi2c: add bus recovery feature Andi Shyti
2023-07-24 10:11 ` [EXT] " Carlos Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed004607-5a23-564a-3185-a63af87783e5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=carlos.song@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).