From: Tom Rix <trix@redhat.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
James Morse <james.morse@arm.com>,
Robert Richter <rric@kernel.org>, Moritz Fischer <mdf@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, dmaengine@vger.kernel.org,
linux-edac@vger.kernel.org, linux-fpga@vger.kernel.org,
linux-i2c@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v3 00/15] arm64 / clk: socfpga: simplifying, cleanups and compile testing
Date: Thu, 11 Mar 2021 10:26:32 -0800 [thread overview]
Message-ID: <f0b90916-9047-d5da-5cde-75d4330cf041@redhat.com> (raw)
In-Reply-To: <20210311152545.1317581-1-krzysztof.kozlowski@canonical.com>
On 3/11/21 7:25 AM, Krzysztof Kozlowski wrote:
> Hi,
>
> All three Intel arm64 SoCFPGA architectures (Agilex, N5X and Stratix 10)
> are basically flavors/platforms of the same architecture. At least from
> the Linux point of view. Up to a point that N5X and Agilex share DTSI.
> Having three top-level architectures for the same one barely makes
> sense and complicates driver selection.
>
> Additionally it was pointed out that ARCH_SOCFPGA name is too generic.
> There are other vendors making SoC+FPGA designs, so the name should be
> changed to have real vendor (currently: Intel).
>
>
> Dependencies / merging
> ======================
> 1. Patch 1 is used as base, so other changes depend on its hunks.
> I put it at beginning as it is something close to a fix, so candidate
> for stable (even though I did not mark it like that).
> 2. Patch 2: everything depends on it.
>
> 3. 64-bit path:
> 3a. Patches 3-7: depend on patch 2, from 64-bit point of view.
> 3b. Patch 8: depends on 2-7 as it finally removes 64-bit ARCH_XXX
> symbols.
>
> 4. 32-bit path:
> 4a. Patches 9-14: depend on 2, from 32-bit point of view.
> 4b. Patch 15: depends on 9-14 as it finally removes 32-bit ARCH_SOCFPGA
> symbol.
>
> If the patches look good, proposed merging is via SoC tree (after
> getting acks from everyone). Sharing immutable branches is also a way.
>
>
> Changes since v2
> ================
> 1. Several new patches and changes.
> 2. Rename ARCH_SOCFPGA to ARCH_INTEL_SOCFPGA on 32-bit and 64-bit.
> 3. Enable compile testing of 32-bit socfpga clock drivers.
> 4. Split changes per subsystems for easier review.
> 5. I already received an ack from Lee Jones, but I did not add it as
> there was big refactoring. Please kindly ack one more time if it
> looks good.
>
> Changes since v1
> ================
> 1. New patch 3: arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64.
> 2. New patch 4: arm64: intel: merge Agilex and N5X into ARCH_SOCFPGA64.
> 3. Fix build is.sue reported by kernel test robot (with ARCH_STRATIX10
> and COMPILE_TEST but without selecting some of the clocks).
>
>
> RFT
> ===
> I tested compile builds on few configurations, so I hope kbuild 0-day
> will check more options (please give it few days on the lists).
> I compare the generated autoconf.h and found no issues. Testing on real
> hardware would be appreciated.
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (15):
> clk: socfpga: allow building N5X clocks with ARCH_N5X
> ARM: socfpga: introduce common ARCH_INTEL_SOCFPGA
> mfd: altera: merge ARCH_SOCFPGA and ARCH_STRATIX10
> net: stmmac: merge ARCH_SOCFPGA and ARCH_STRATIX10
> clk: socfpga: build together Stratix 10, Agilex and N5X clock drivers
> clk: socfpga: merge ARCH_SOCFPGA and ARCH_STRATIX10
> EDAC: altera: merge ARCH_SOCFPGA and ARCH_STRATIX10
> arm64: socfpga: merge Agilex and N5X into ARCH_INTEL_SOCFPGA
> clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks
> clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and
> compile test)
> dmaengine: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs
> fpga: altera: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs
> i2c: altera: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs
> reset: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs
> ARM: socfpga: drop ARCH_SOCFPGA
>
> arch/arm/Kconfig | 2 +-
> arch/arm/Kconfig.debug | 6 +++---
> arch/arm/Makefile | 2 +-
> arch/arm/boot/dts/Makefile | 2 +-
> arch/arm/configs/multi_v7_defconfig | 2 +-
> arch/arm/configs/socfpga_defconfig | 2 +-
> arch/arm/mach-socfpga/Kconfig | 4 ++--
> arch/arm64/Kconfig.platforms | 17 ++++-------------
> arch/arm64/boot/dts/altera/Makefile | 2 +-
> arch/arm64/boot/dts/intel/Makefile | 6 +++---
> arch/arm64/configs/defconfig | 3 +--
> drivers/clk/Kconfig | 1 +
> drivers/clk/Makefile | 4 +---
> drivers/clk/socfpga/Kconfig | 19 +++++++++++++++++++
> drivers/clk/socfpga/Makefile | 11 +++++------
> drivers/dma/Kconfig | 2 +-
> drivers/edac/Kconfig | 2 +-
> drivers/edac/altera_edac.c | 17 +++++++++++------
> drivers/firmware/Kconfig | 2 +-
> drivers/fpga/Kconfig | 8 ++++----
> drivers/i2c/busses/Kconfig | 2 +-
> drivers/mfd/Kconfig | 4 ++--
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 ++--
> drivers/reset/Kconfig | 6 +++---
> 24 files changed, 71 insertions(+), 59 deletions(-)
> create mode 100644 drivers/clk/socfpga/Kconfig
>
Thanks for changing the config name.
Please review checkpatch --strict on this set, the typical complaint is
clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and compile test)
WARNING: please write a paragraph that describes the config symbol fully
#35: FILE: drivers/clk/socfpg/Kconfig:11:
+config CLK_INTEL_SOCFPGA32
Tom
next prev parent reply other threads:[~2021-03-11 18:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 15:25 [PATCH v3 00/15] arm64 / clk: socfpga: simplifying, cleanups and compile testing Krzysztof Kozlowski
2021-03-11 15:25 ` [PATCH v3 01/15] clk: socfpga: allow building N5X clocks with ARCH_N5X Krzysztof Kozlowski
2021-03-11 15:25 ` [PATCH v3 02/15] ARM: socfpga: introduce common ARCH_INTEL_SOCFPGA Krzysztof Kozlowski
2021-03-11 15:25 ` [PATCH v3 03/15] mfd: altera: merge ARCH_SOCFPGA and ARCH_STRATIX10 Krzysztof Kozlowski
2021-03-22 15:10 ` Lee Jones
2021-03-11 15:25 ` [PATCH v3 04/15] net: stmmac: " Krzysztof Kozlowski
2021-03-11 15:25 ` [PATCH v3 05/15] clk: socfpga: build together Stratix 10, Agilex and N5X clock drivers Krzysztof Kozlowski
2021-03-11 15:25 ` [PATCH v3 06/15] clk: socfpga: merge ARCH_SOCFPGA and ARCH_STRATIX10 Krzysztof Kozlowski
2021-03-11 15:25 ` [PATCH v3 07/15] EDAC: altera: " Krzysztof Kozlowski
2021-03-11 15:25 ` [PATCH v3 08/15] arm64: socfpga: merge Agilex and N5X into ARCH_INTEL_SOCFPGA Krzysztof Kozlowski
2021-04-06 16:09 ` Guenter Roeck
2021-04-06 16:15 ` Krzysztof Kozlowski
2021-03-11 15:27 ` [PATCH v3 09/15] clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks Krzysztof Kozlowski
2021-03-11 15:27 ` [PATCH v3 10/15] clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and compile test) Krzysztof Kozlowski
2021-03-11 15:27 ` [PATCH v3 11/15] dmaengine: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs Krzysztof Kozlowski
2021-03-11 15:27 ` [PATCH v3 12/15] fpga: altera: " Krzysztof Kozlowski
2021-03-11 22:48 ` Moritz Fischer
2021-03-11 15:27 ` [PATCH v3 13/15] i2c: " Krzysztof Kozlowski
2021-03-11 15:27 ` [PATCH v3 14/15] reset: socfpga: " Krzysztof Kozlowski
2021-03-11 15:27 ` [PATCH v3 15/15] ARM: socfpga: drop ARCH_SOCFPGA Krzysztof Kozlowski
2021-03-11 18:26 ` Tom Rix [this message]
2021-03-11 18:47 ` [PATCH v3 00/15] arm64 / clk: socfpga: simplifying, cleanups and compile testing Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b90916-9047-d5da-5cde-75d4330cf041@redhat.com \
--to=trix@redhat.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=james.morse@arm.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mdf@kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).