From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6955FC47092 for ; Sun, 30 May 2021 15:53:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33836611BD for ; Sun, 30 May 2021 15:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbhE3PzZ (ORCPT ); Sun, 30 May 2021 11:55:25 -0400 Received: from mxout03.lancloud.ru ([45.84.86.113]:52806 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhE3PzZ (ORCPT ); Sun, 30 May 2021 11:55:25 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 09D9920F3AD1 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH0/2] Fix deferred probing in the I2C bus drivers From: Sergey Shtylyov To: Sergey Shtylyov , , Ard Biesheuvel References: Organization: Open Mobile Platform Message-ID: Date: Sun, 30 May 2021 18:53:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1908.lancloud.ru (fd00:f066::208) Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 5/28/21 11:57 PM, Sergey Shtylyov wrote: [...] >> Here are 2 patches against the 'i2c/for-current' branch of Wolfram's 'linux.git' repo. >> The affected drivers call platform_get_irq() but override its result in case of error >> which prevents the deferred probing from working. >> >> [1/2] i2c: iop3xx: fix deferred probing >> [2/2] i2c: synquacer: fix deferred probing > > Please hold on with this series; I'm gonna add another patch... Actually, I'm unsure about drivers/i2c/busses/i2c-pca-platform.c: normally it uses polling iff the (considered optional) IRQ can't be set up (irq < 0 returned from platform_get_irq_optional()) then polling mode is used. I have a patch to propaate -EPROBE_DEFER upstream but I'm not sure what is better : sefer the probe (and potentially falling permanently iff the kernel wouldn't able to finally set up the IRQ or to start the I2C driver in the polling mode right away. Does these doubts even make sense? :-) MBR, Sergey