From: Jiri Kosina <jikos@kernel.org>
To: Michael Zaidman <michael.zaidman@gmail.com>
Cc: dan.carpenter@oracle.com, benjamin.tissoires@redhat.com,
wsa@kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] HID: ft260: check data size in ft260_smbus_write()
Date: Wed, 5 May 2021 14:33:02 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2105051432470.28378@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210413151200.2174-1-michael.zaidman@gmail.com>
On Tue, 13 Apr 2021, Michael Zaidman wrote:
> Fixes: 98189a0adfa0 ("HID: ft260: add usb hid to i2c host bridge driver")
>
> The SMbus block transaction limits the number of bytes transferred to 32,
> but nothing prevents a user from specifying via ioctl a larger data size
> than the ft260 can handle in a single transfer.
>
> i2cdev_ioctl_smbus()
> --> i2c_smbus_xfer
> --> __i2c_smbus_xfer
> --> ft260_smbus_xfer
> --> ft260_smbus_write
>
> This patch adds data size checking in the ft260_smbus_write().
>
> Signed-off-by: Michael Zaidman <michael.zaidman@gmail.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
I have moved the 'Fixes:' tag to place where it belongs, and applied.
Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-05-05 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:12 [PATCH] HID: ft260: check data size in ft260_smbus_write() Michael Zaidman
2021-05-05 12:33 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2105051432470.28378@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.zaidman@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).