Linux-i3c Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] i3c: master: no need to iterate master device twice
@ 2020-02-14 14:58 Wolfram Sang
  2020-02-14 15:22 ` Geert Uytterhoeven
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-02-14 14:58 UTC (permalink / raw)
  To: linux-i3c; +Cc: linux-renesas-soc, Wolfram Sang

We already have the master device in a variable, reuse it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Found while refactoring of_i2c_get_board_info() and checking its users.

 drivers/i3c/master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 7f8f896fa0c3..b56207bbed2b 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1953,7 +1953,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	 * DEFSLVS command.
 	 */
 	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
-		dev_err(&master->dev, "I2C device with 10 bit address not supported.");
+		dev_err(dev, "I2C device with 10 bit address not supported.");
 		return -ENOTSUPP;
 	}
 
-- 
2.20.1


_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] i3c: master: no need to iterate master device twice
  2020-02-14 14:58 [PATCH] i3c: master: no need to iterate master device twice Wolfram Sang
@ 2020-02-14 15:22 ` Geert Uytterhoeven
  2020-02-17 10:43   ` Vitor Soares
  2020-02-17 11:18 ` Vitor Soares
  2020-02-18  0:38 ` Kieran Bingham
  2 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-02-14 15:22 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: Linux-Renesas, linux-i3c

On Fri, Feb 14, 2020 at 3:59 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We already have the master device in a variable, reuse it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] i3c: master: no need to iterate master device twice
  2020-02-14 15:22 ` Geert Uytterhoeven
@ 2020-02-17 10:43   ` Vitor Soares
  2020-02-17 11:29     ` Boris Brezillon
  0 siblings, 1 reply; 6+ messages in thread
From: Vitor Soares @ 2020-02-17 10:43 UTC (permalink / raw)
  To: Geert Uytterhoeven, Wolfram Sang, Boris Brezillon
  Cc: Linux-Renesas, linux-i3c

++Boris Brezillon,

Hi,

I didn't received the patch neither is in pachtwork I3C ML, it might be 
held on the server.

@Boris Brezillon: Could you please check it?

From: Geert Uytterhoeven 
<geert@linux-m68k.org>
Date: Fri, Feb 14, 2020 at 15:22:30

> On Fri, Feb 14, 2020 at 3:59 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
> > We already have the master device in a variable, reuse it.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 
> _______________________________________________
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.infradead.org_mailman_listinfo_linux-2Di3c&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=FfrtbU5sjufe52Oll26A7hjX2dMLwqPN5ExIlo1a9Gg&s=rV3MuOuVG1GfYXy5GV-_7NNVoIu85gJVtkb_RSYRcJw&e= 

Best regards,
Vitor Soares

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH] i3c: master: no need to iterate master device twice
  2020-02-14 14:58 [PATCH] i3c: master: no need to iterate master device twice Wolfram Sang
  2020-02-14 15:22 ` Geert Uytterhoeven
@ 2020-02-17 11:18 ` Vitor Soares
  2020-02-18  0:38 ` Kieran Bingham
  2 siblings, 0 replies; 6+ messages in thread
From: Vitor Soares @ 2020-02-17 11:18 UTC (permalink / raw)
  To: Wolfram Sang, linux-i3c; +Cc: linux-renesas-soc

From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date: Fri, Feb 14, 2020 at 14:58:53

> We already have the master device in a variable, reuse it.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Vitor Soares <vitor.soares@synopsys.com>

Best regards,
Vitor 
Soares

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] i3c: master: no need to iterate master device twice
  2020-02-17 10:43   ` Vitor Soares
@ 2020-02-17 11:29     ` Boris Brezillon
  0 siblings, 0 replies; 6+ messages in thread
From: Boris Brezillon @ 2020-02-17 11:29 UTC (permalink / raw)
  To: Vitor Soares
  Cc: Linux-Renesas, Wolfram Sang, linux-i3c, Geert Uytterhoeven,
	Boris Brezillon

On Mon, 17 Feb 2020 10:43:49 +0000
Vitor Soares <Vitor.Soares@synopsys.com> wrote:

> ++Boris Brezillon,
> 
> Hi,
> 
> I didn't received the patch neither is in pachtwork I3C ML, it might be 
> held on the server.
> 
> @Boris Brezillon: Could you please check it?

Done.

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] i3c: master: no need to iterate master device twice
  2020-02-14 14:58 [PATCH] i3c: master: no need to iterate master device twice Wolfram Sang
  2020-02-14 15:22 ` Geert Uytterhoeven
  2020-02-17 11:18 ` Vitor Soares
@ 2020-02-18  0:38 ` Kieran Bingham
  2 siblings, 0 replies; 6+ messages in thread
From: Kieran Bingham @ 2020-02-18  0:38 UTC (permalink / raw)
  To: Wolfram Sang, linux-i3c; +Cc: linux-renesas-soc

Hi Wolfram,

On 14/02/2020 14:58, Wolfram Sang wrote:
> We already have the master device in a variable, reuse it.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> ---
> 
> Found while refactoring of_i2c_get_board_info() and checking its users.
> 
>  drivers/i3c/master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 7f8f896fa0c3..b56207bbed2b 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1953,7 +1953,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
>  	 * DEFSLVS command.
>  	 */
>  	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> -		dev_err(&master->dev, "I2C device with 10 bit address not supported.");
> +		dev_err(dev, "I2C device with 10 bit address not supported.");
>  		return -ENOTSUPP;
>  	}
>  
> 


_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14 14:58 [PATCH] i3c: master: no need to iterate master device twice Wolfram Sang
2020-02-14 15:22 ` Geert Uytterhoeven
2020-02-17 10:43   ` Vitor Soares
2020-02-17 11:29     ` Boris Brezillon
2020-02-17 11:18 ` Vitor Soares
2020-02-18  0:38 ` Kieran Bingham

Linux-i3c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i3c/0 linux-i3c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i3c linux-i3c/ https://lore.kernel.org/linux-i3c \
		linux-i3c@lists.infradead.org
	public-inbox-index linux-i3c

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-i3c


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git