linux-i3c.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] i3c: master: dw: Drop redundant disec call
@ 2020-12-28 10:55 Miquel Raynal
  2021-02-05 23:44 ` Alexandre Belloni
  0 siblings, 1 reply; 2+ messages in thread
From: Miquel Raynal @ 2020-12-28 10:55 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: linux-i3c, Miquel Raynal, Vitor Soares

Disabling all event calls is already handled by the core right before
starting the DAA process. Do not do it again when the DAA process
completes, it is redundant.

Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---

AFAIK I did not receive any replies to this patch with is still valid,
so I'm just resending it as-is.

 drivers/i3c/master/dw-i3c-master.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 8513bd353c05..03a368da51b9 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -816,11 +816,6 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
 
 	dw_i3c_master_free_xfer(xfer);
 
-	i3c_master_disec_locked(m, I3C_BROADCAST_ADDR,
-				I3C_CCC_EVENT_HJ |
-				I3C_CCC_EVENT_MR |
-				I3C_CCC_EVENT_SIR);
-
 	return 0;
 }
 
-- 
2.20.1


-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] i3c: master: dw: Drop redundant disec call
  2020-12-28 10:55 [PATCH RESEND] i3c: master: dw: Drop redundant disec call Miquel Raynal
@ 2021-02-05 23:44 ` Alexandre Belloni
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2021-02-05 23:44 UTC (permalink / raw)
  To: Miquel Raynal; +Cc: Alexandre Belloni, linux-i3c, Vitor Soares

On Mon, 28 Dec 2020 11:55:01 +0100, Miquel Raynal wrote:
> Disabling all event calls is already handled by the core right before
> starting the DAA process. Do not do it again when the DAA process
> completes, it is redundant.

Applied, thanks!

[1/1] i3c: master: dw: Drop redundant disec call
      commit: 5c34b8e7e8bb605925b33e1aa7dc17966811219a

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-05 23:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-28 10:55 [PATCH RESEND] i3c: master: dw: Drop redundant disec call Miquel Raynal
2021-02-05 23:44 ` Alexandre Belloni

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox