Linux-i3c Archive on
 help / color / Atom feed
From: "Gustavo A. R. Silva" <>
To: Vitor Soares <>,
	Boris Brezillon <>
	Kees Cook <>,
	"Gustavo A. R. Silva" <>
Subject: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
Date: Mon, 11 Feb 2019 16:14:13 -0600
Message-ID: <20190211221413.GA21822@embeddedor> (raw)

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (ret)
drivers/i3c/master/dw-i3c-master.c:605:2: note: here

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable

Signed-off-by: Gustavo A. R. Silva <>
 drivers/i3c/master/dw-i3c-master.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index bb03079fbade..59279224e07f 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
 		ret = dw_i2c_clk_cfg(master);
 		if (ret)
 			return ret;
+		/* fall through */
 		ret = dw_i3c_clk_cfg(master);
 		if (ret)

linux-i3c mailing list

             reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 22:14 Gustavo A. R. Silva [this message]
2019-02-27  3:53 ` Gustavo A. R. Silva
2019-02-27  8:13   ` Boris Brezillon
2019-02-27 20:13     ` Gustavo A. R. Silva
2019-02-27 10:33   ` vitor

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190211221413.GA21822@embeddedor \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-i3c Archive on

Archives are clonable:
	git clone --mirror linux-i3c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i3c linux-i3c/ \
	public-inbox-index linux-i3c

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox