Linux-i3c Archive on lore.kernel.org
 help / color / Atom feed
From: Boris Brezillon <bbrezillon@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
	Kees Cook <keescook@chromium.org>,
	Vitor Soares <vitor.soares@synopsys.com>
Subject: Re: [PATCH] i3c: master: dw-i3c-master: mark expected switch fall-through
Date: Wed, 27 Feb 2019 09:13:35 +0100
Message-ID: <20190227091335.2a19e2a7@kernel.org> (raw)
In-Reply-To: <87e0a8c9-82f6-3f41-bdb6-162a4c264132@embeddedor.com>

On Tue, 26 Feb 2019 21:53:16 -0600
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:

> Hi all,
> 
> Friendly ping:
> 
> Who can ack or review this, please?

Will be queued for the next release. Please be patient.

> 
> Thanks
> --
> Gustavo
> 
> On 2/11/19 4:14 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > cases where we are expecting to fall through.
> > 
> > This patch fixes the following warning:
> > 
> > drivers/i3c/master/dw-i3c-master.c: In function ‘dw_i3c_master_bus_init’:
> > drivers/i3c/master/dw-i3c-master.c:603:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >    if (ret)
> >       ^
> > drivers/i3c/master/dw-i3c-master.c:605:2: note: here
> >   case I3C_BUS_MODE_PURE:
> >   ^~~~
> > 
> > Warning level 3 was used: -Wimplicit-fallthrough=3
> > 
> > This patch is part of the ongoing efforts to enable
> > -Wimplicit-fallthrough.
> > 
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > ---
> >  drivers/i3c/master/dw-i3c-master.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> > index bb03079fbade..59279224e07f 100644
> > --- a/drivers/i3c/master/dw-i3c-master.c
> > +++ b/drivers/i3c/master/dw-i3c-master.c
> > @@ -602,6 +602,7 @@ static int dw_i3c_master_bus_init(struct i3c_master_controller *m)
> >  		ret = dw_i2c_clk_cfg(master);
> >  		if (ret)
> >  			return ret;
> > +		/* fall through */
> >  	case I3C_BUS_MODE_PURE:
> >  		ret = dw_i3c_clk_cfg(master);
> >  		if (ret)
> >   


_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 22:14 Gustavo A. R. Silva
2019-02-27  3:53 ` Gustavo A. R. Silva
2019-02-27  8:13   ` Boris Brezillon [this message]
2019-02-27 20:13     ` Gustavo A. R. Silva
2019-02-27 10:33   ` vitor

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190227091335.2a19e2a7@kernel.org \
    --to=bbrezillon@kernel.org \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vitor.soares@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-i3c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i3c/0 linux-i3c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i3c linux-i3c/ https://lore.kernel.org/linux-i3c \
		linux-i3c@lists.infradead.org linux-i3c@archiver.kernel.org
	public-inbox-index linux-i3c


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-i3c


AGPL code for this site: git clone https://public-inbox.org/ public-inbox