linux-i3c.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] i3c: master:dw: Fix dw_i3c_master_disable controller by using correct mask
@ 2019-03-06 21:57 Vitor Soares
  2019-03-27 21:37 ` vitor
  0 siblings, 1 reply; 4+ messages in thread
From: Vitor Soares @ 2019-03-06 21:57 UTC (permalink / raw)
  To: bbrezillon; +Cc: linux-i3c, joao.pinto, Vitor Soares

The controller is disable by clear the DEV_CTRL_ENABLE bit rather
than set it. This is fixed by using the correct mask.

Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
---
 drivers/i3c/master/dw-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index bb03079..ec385fb 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -300,7 +300,7 @@ to_dw_i3c_master(struct i3c_master_controller *master)
 
 static void dw_i3c_master_disable(struct dw_i3c_master *master)
 {
-	writel(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_ENABLE,
+	writel(readl(master->regs + DEVICE_CTRL) & ~DEV_CTRL_ENABLE,
 	       master->regs + DEVICE_CTRL);
 }
 
-- 
2.7.4


_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-01 16:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 21:57 [PATCH] i3c: master:dw: Fix dw_i3c_master_disable controller by using correct mask Vitor Soares
2019-03-27 21:37 ` vitor
2019-03-30  7:54   ` Boris Brezillon
2019-04-01 16:58     ` vitor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).