From: Boris Brezillon <boris.brezillon@collabora.com>
To: Przemyslaw Gaj <pgaj@cadence.com>
Cc: linux-i3c@lists.infradead.org, vitor.soares@synopsys.com,
rafalc@cadence.com, agolec@cadence.com, bbrezillon@kernel.org
Subject: Re: [PATCH v4 1/6] i3c: add addr and lvr to i2c_dev_desc structure
Date: Sat, 30 Mar 2019 15:36:18 +0100 [thread overview]
Message-ID: <20190330153618.48719ee5@collabora.com> (raw)
In-Reply-To: <20190310135843.21154-2-pgaj@cadence.com>
On Sun, 10 Mar 2019 13:58:38 +0000
Przemyslaw Gaj <pgaj@cadence.com> wrote:
> I need to store address and lvr value for I2C devices without static definition
> in DT. This allows secondary master to transmit DEFSLVS command properly.
>
> Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
> ---
> include/linux/i3c/master.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h
> index eca8337..3c27d9f 100644
> --- a/include/linux/i3c/master.h
> +++ b/include/linux/i3c/master.h
> @@ -71,6 +71,9 @@ struct i2c_dev_boardinfo {
> * @common: common part of the I2C device descriptor
> * @boardinfo: pointer to the boardinfo attached to this I2C device
> * @dev: I2C device object registered to the I2C framework
> + * @addr: I2C device address
> + * @lvr: LVR (Legacy Virtual Register) needed by the I3C core to know about
> + * the I2C device limitations
> *
> * Each I2C device connected on the bus will have an i2c_dev_desc.
> * This object is created by the core and later attached to the controller
> @@ -84,6 +87,8 @@ struct i2c_dev_desc {
> struct i3c_i2c_dev_desc common;
> const struct i2c_dev_boardinfo *boardinfo;
> struct i2c_client *dev;
> + u16 addr;
> + u8 lvr;
You also need to remove lvr from i2c_dev_boardinfo and adjust the code
to use i2c_dev_desc->addr and i2c_dev_desc->lvr in this patch, not in
patch 3.
> };
>
> /**
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-03-30 14:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 13:58 [PATCH v4 0/6] Add the I3C mastership request Przemyslaw Gaj
2019-03-10 13:58 ` [PATCH v4 1/6] i3c: add addr and lvr to i2c_dev_desc structure Przemyslaw Gaj
2019-03-30 14:36 ` Boris Brezillon [this message]
2019-04-01 18:17 ` vitor
2019-04-01 18:31 ` Boris Brezillon
2019-04-01 18:48 ` vitor
2019-04-01 19:10 ` Przemyslaw Gaj
2019-04-01 19:24 ` Boris Brezillon
2019-04-02 11:10 ` vitor
2019-04-02 11:22 ` Przemyslaw Gaj
2019-04-02 11:32 ` vitor
2019-04-02 11:53 ` Boris Brezillon
2019-04-02 11:48 ` Boris Brezillon
2019-03-10 13:58 ` [PATCH v4 2/6] i3c: export bus maintenance lock and unlock functions Przemyslaw Gaj
2019-03-10 13:58 ` [PATCH v4 3/6] i3c: Add support for mastership request to I3C subsystem Przemyslaw Gaj
2019-03-30 15:06 ` Boris Brezillon
2019-04-01 18:41 ` vitor
2019-04-01 19:18 ` Boris Brezillon
2019-04-09 14:31 ` Vitor Soares
2019-04-09 15:20 ` Przemyslaw Gaj
2019-04-09 15:46 ` Vitor Soares
2019-04-10 6:53 ` Przemyslaw Gaj
2019-04-10 10:05 ` Vitor Soares
2019-04-10 10:36 ` Boris Brezillon
2019-04-12 14:28 ` Vitor Soares
2019-04-12 14:57 ` Boris Brezillon
2019-04-15 12:02 ` Vitor Soares
2019-04-15 13:08 ` Boris Brezillon
2019-03-10 13:58 ` [PATCH v4 4/6] i3c: master: cdns: add support for mastership request to Cadence I3C master driver Przemyslaw Gaj
2019-03-30 15:44 ` Boris Brezillon
2019-04-29 10:36 ` Przemyslaw Gaj
2019-05-18 7:34 ` Boris Brezillon
2019-03-10 13:58 ` [PATCH v4 5/6] i3c: master: Add module author Przemyslaw Gaj
2019-03-10 13:58 ` [PATCH v4 6/6] MAINTAINERS: add myself as co-maintainer of i3c subsystem Przemyslaw Gaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190330153618.48719ee5@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=agolec@cadence.com \
--cc=bbrezillon@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=pgaj@cadence.com \
--cc=rafalc@cadence.com \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).