Linux-i3c Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask
@ 2019-04-08 11:13 Vitor Soares
  2019-04-08 19:29 ` Sasha Levin
  2019-04-08 23:20 ` [PATCH v3] " Vitor Soares
  0 siblings, 2 replies; 3+ messages in thread
From: Vitor Soares @ 2019-04-08 11:13 UTC (permalink / raw)
  To: linux-i3c; +Cc: joao.pinto, Boris Brezillon, stable, Vitor Soares

The controller was being disabled incorrectly. The correct way is to clear
the DEV_CTRL_ENABLE bit.

Fix this by by clearing this bit.

Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>

Cc: Boris Brezillon <bbrezillon@kernel.org>
Cc: <stable@vger.kernel.org>
---
Changes v1 to v2:
  Fix commit Message
  Add Cc: <stable@vger.kernel.org>

 drivers/i3c/master/dw-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 5927922..10c26ff 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -300,7 +300,7 @@ to_dw_i3c_master(struct i3c_master_controller *master)
 
 static void dw_i3c_master_disable(struct dw_i3c_master *master)
 {
-	writel(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_ENABLE,
+	writel(readl(master->regs + DEVICE_CTRL) & ~DEV_CTRL_ENABLE,
 	       master->regs + DEVICE_CTRL);
 }
 
-- 
2.7.4


_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask
  2019-04-08 11:13 [PATCH v2] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask Vitor Soares
@ 2019-04-08 19:29 ` Sasha Levin
  2019-04-08 23:20 ` [PATCH v3] " Vitor Soares
  1 sibling, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2019-04-08 19:29 UTC (permalink / raw)
  To: Sasha Levin; +Cc: , joao.pinto, Boris Brezillon, stable, Vitor Soares

Hi,

[This is an automated email]

This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all

The bot has tested the following trees: v5.0.7, v4.19.34, v4.14.111, v4.9.168, v4.4.178, v3.18.138.

v5.0.7: Build OK!
v4.19.34: Failed to apply! Possible dependencies:
    1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    603f2bee2c54 ("i3c: master: Add driver for Cadence IP")

v4.14.111: Failed to apply! Possible dependencies:
    1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    603f2bee2c54 ("i3c: master: Add driver for Cadence IP")

v4.9.168: Failed to apply! Possible dependencies:
    1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    603f2bee2c54 ("i3c: master: Add driver for Cadence IP")

v4.4.178: Failed to apply! Possible dependencies:
    1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    603f2bee2c54 ("i3c: master: Add driver for Cadence IP")

v3.18.138: Failed to apply! Possible dependencies:
    1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    603f2bee2c54 ("i3c: master: Add driver for Cadence IP")


How should we proceed with this patch?

--
Thanks,
Sasha

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask
  2019-04-08 11:13 [PATCH v2] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask Vitor Soares
  2019-04-08 19:29 ` Sasha Levin
@ 2019-04-08 23:20 ` " Vitor Soares
  1 sibling, 0 replies; 3+ messages in thread
From: Vitor Soares @ 2019-04-08 23:20 UTC (permalink / raw)
  To: linux-i3c; +Cc: joao.pinto, Boris Brezillon, stable, Vitor Soares

The controller was being disabled incorrectly. The correct way is to clear
the DEV_CTRL_ENABLE bit.

Fix this by by clearing this bit.

Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>

Cc: Boris Brezillon <bbrezillon@kernel.org>
Cc: <stable@vger.kernel.org>
---
Changes v2 to v3:
  Add Fixes tag

Changes v1 to v2:
  Fix commit Message
  Add Cc: <stable@vger.kernel.org>

 drivers/i3c/master/dw-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index 5927922..10c26ff 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -300,7 +300,7 @@ to_dw_i3c_master(struct i3c_master_controller *master)
 
 static void dw_i3c_master_disable(struct dw_i3c_master *master)
 {
-	writel(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_ENABLE,
+	writel(readl(master->regs + DEVICE_CTRL) & ~DEV_CTRL_ENABLE,
 	       master->regs + DEVICE_CTRL);
 }
 
-- 
2.7.4


_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 11:13 [PATCH v2] i3c: dw: Fix dw_i3c_master_disable controller by using correct mask Vitor Soares
2019-04-08 19:29 ` Sasha Levin
2019-04-08 23:20 ` [PATCH v3] " Vitor Soares

Linux-i3c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i3c/0 linux-i3c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i3c linux-i3c/ https://lore.kernel.org/linux-i3c \
		linux-i3c@lists.infradead.org linux-i3c@archiver.kernel.org
	public-inbox-index linux-i3c


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-i3c


AGPL code for this site: git clone https://public-inbox.org/ public-inbox