From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: [PATCH] i3c: master: Use struct_size() helper
Date: Sat, 1 Jun 2019 10:19:12 +0200 [thread overview]
Message-ID: <20190601101912.2a609581@collabora.com> (raw)
In-Reply-To: <20190531173532.GA7141@embeddedor>
On Fri, 31 May 2019 12:35:32 -0500
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes, in particular in the
> context in which this code is being used.
>
> So, replace the following form:
>
> sizeof(*defslvs) + ((ndevs - 1) * sizeof(struct i3c_ccc_dev_desc))
>
> with:
>
> struct_size(defslvs, slaves, ndevs - 1)
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/i3c/master.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index b9d2b88928e1..923b04052038 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -924,9 +924,8 @@ int i3c_master_defslvs_locked(struct i3c_master_controller *master)
> ndevs++;
>
> defslvs = i3c_ccc_cmd_dest_init(&dest, I3C_BROADCAST_ADDR,
> - sizeof(*defslvs) +
> - ((ndevs - 1) *
> - sizeof(struct i3c_ccc_dev_desc)));
> + struct_size(defslvs, slaves,
> + ndevs - 1));
ndev - 1 should be aligned on the struct_size open parens, or even
better, be put on one line since it seems to fit the 80-chars limit:
defslvs = i3c_ccc_cmd_dest_init(&dest, I3C_BROADCAST_ADDR,
struct_size(defslvs, slaves, ndevs - 1));
> if (!defslvs)
> return -ENOMEM;
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2019-06-01 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 17:35 [PATCH] i3c: master: Use struct_size() helper Gustavo A. R. Silva
2019-06-01 8:19 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601101912.2a609581@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).