From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E2BC282CE for ; Tue, 4 Jun 2019 08:55:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10EDA24C49 for ; Tue, 4 Jun 2019 08:55:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FxoLjJOk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10EDA24C49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n4CdNUirMMEtcsV6x11F/6dU0o4mPj3n1yEuKyiy4gE=; b=FxoLjJOkfOavdk kfDvYcuY0YQ3F4hC1bGSpElOW30sLNrew75VjN5388G+mCATJMa+wu84rIi3yWQdm59HmZrqTEafQ iMNatdHDoNL0dMBg04EOxkA7n1zZShn2X+GB/bh3Uo1OFZm93ej5IjBjex5fPyW8f7DI9NXiHXwnr k9wR/UqekQ1QVKAN/0Wu8ye893hEbEgvuon/FgYB5+0jf4v+rHFSDC9vvYawigiFRoENDKBkX7TL5 eTijUKKCRonubsi0EAJLNemtPzMor+LYHiR6JlGrJ0GyJkraLms47TTb6B6lC3kn37xZ+wPR15Rot LEK6ugrwjcAFBegcavMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY5Dg-0003Mv-Jw; Tue, 04 Jun 2019 08:55:00 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY4NK-0002oY-45; Tue, 04 Jun 2019 08:00:55 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 76BB4260E1F; Tue, 4 Jun 2019 09:00:52 +0100 (BST) Date: Tue, 4 Jun 2019 09:58:58 +0200 From: Boris Brezillon To: Qii Wang Subject: Re: [PATCH 2/2] i3c: master: Add driver for MediaTek IP Message-ID: <20190604095858.38ed9a28@collabora.com> In-Reply-To: <1559533863-10292-3-git-send-email-qii.wang@mediatek.com> References: <1559533863-10292-1-git-send-email-qii.wang@mediatek.com> <1559533863-10292-3-git-send-email-qii.wang@mediatek.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190604_010054_297721_A6D5653E X-CRM114-Status: GOOD ( 10.92 ) X-Mailman-Approved-At: Tue, 04 Jun 2019 01:54:58 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, bbrezillon@kernel.org, leilk.liu@mediatek.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, liguo.zhang@mediatek.com, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, matthias.bgg@gmail.com, linux-i3c@lists.infradead.org, xinping.qian@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Mon, 3 Jun 2019 11:51:03 +0800 Qii Wang wrote: > +static int mtk_i3c_master_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mtk_i3c_master *master; > + struct resource *res; > + int ret, irqnr; > + > + master = devm_kzalloc(dev, sizeof(*master), GFP_KERNEL); > + if (!master) > + return -ENOMEM; > + > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "main"); > + master->regs = devm_ioremap_resource(dev, res); > + if (IS_ERR(master->regs)) > + return PTR_ERR(master->regs); > + > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dma"); > + master->dma_regs = devm_ioremap_resource(dev, res); > + if (IS_ERR(master->dma_regs)) > + return PTR_ERR(master->dma_regs); > + > + irqnr = platform_get_irq(pdev, 0); > + if (irqnr < 0) > + return irqnr; > + > + ret = devm_request_irq(dev, irqnr, mtk_i3c_master_irq, > + IRQF_TRIGGER_NONE, DRV_NAME, master); > + if (ret < 0) { > + dev_err(dev, "Request I3C IRQ %d fail\n", irqnr); > + return ret; > + } > + > + ret = of_property_read_u32(pdev->dev.of_node, "clock-div", > + &master->clk_src_div); You say in one comment that this clock divider is fixed in HW but might change on a per-SoC basis. If that's the case, you should get rid of this clock-div prop and attach the divider to the compatible (using an mtk_i3c_master_variant struct that contains a divider field). > + if (ret < 0) > + return -EINVAL; > + > + spin_lock_init(&master->xferqueue.lock); > + INIT_LIST_HEAD(&master->xferqueue.list); > + > + if (dma_set_mask(dev, DMA_BIT_MASK(33))) { > + dev_err(dev, "dma_set_mask return error.\n"); > + return -EINVAL; > + } > + > + master->clk_main = devm_clk_get(dev, "main"); > + if (IS_ERR(master->clk_main)) { > + dev_err(dev, "cannot get main clock\n"); > + return PTR_ERR(master->clk_main); > + } > + master->clk_dma = devm_clk_get(dev, "dma"); > + if (IS_ERR(master->clk_dma)) { > + dev_err(dev, "cannot get dma clock\n"); > + return PTR_ERR(master->clk_dma); > + } > + > + master->clk_arb = devm_clk_get_optional(dev, "arb"); > + if (IS_ERR(master->clk_arb)) > + return PTR_ERR(master->clk_arb); > + > + ret = mtk_i3c_master_clock_enable(master); > + if (ret) { > + dev_err(dev, "clock enable failed!\n"); > + return ret; > + } > + > + master->dev = dev; > + platform_set_drvdata(pdev, master); > + > + ret = i3c_master_register(&master->mas_ctrler, dev, > + &mtk_i3c_master_ops, false); > + if (ret) { > + dev_err(dev, "Failed to add i3c bus to i3c core\n"); > + mtk_i3c_master_clock_disable(master); > + return ret; > + } > + > + return 0; > +} _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c