From: Boris Brezillon <boris.brezillon@collabora.com> To: Vitor Soares <Vitor.Soares@synopsys.com> Cc: Joao.Pinto@synopsys.com, rafael@kernel.org, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, bbrezillon@kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-i2c@vger.kernel.org, lorenzo.bianconi83@gmail.com, linux-i3c@lists.infradead.org Subject: Re: [PATCH v2 2/3] i3c: add i3c_get_device_id helper Date: Thu, 6 Jun 2019 17:17:55 +0200 [thread overview] Message-ID: <20190606171755.0feb8998@collabora.com> (raw) In-Reply-To: <eaa9eb66df6b4c9b577aec46fd440b99d763a5a2.1559831663.git.vitor.soares@synopsys.com> On Thu, 6 Jun 2019 17:12:03 +0200 Vitor Soares <Vitor.Soares@synopsys.com> wrote: > This helper return the i3c_device_id structure in order the client > have access to the driver data. > > Signed-off-by: Vitor Soares <vitor.soares@synopsys.com> > --- > Changes in v2: > move this function to drivers/i3c/device.c > > drivers/i3c/device.c | 8 ++++++++ > include/linux/i3c/device.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/drivers/i3c/device.c b/drivers/i3c/device.c > index 69cc040..a6d0796 100644 > --- a/drivers/i3c/device.c > +++ b/drivers/i3c/device.c > @@ -200,6 +200,14 @@ struct i3c_device *dev_to_i3cdev(struct device *dev) > } > EXPORT_SYMBOL_GPL(dev_to_i3cdev); > > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev) > +{ > + const struct i3c_driver *i3cdrv = drv_to_i3cdrv(i3cdev->dev.driver); > + > + return i3cdrv->id_table; > +} > +EXPORT_SYMBOL_GPL(i3c_get_device_id); That's not what I asked. I told you to expose i3c_device_match_id() which already exists and is in master.c. What you really want is to get the device_id entry that matches your device, not the first entry in the table... > + > /** > * i3c_driver_register_with_owner() - register an I3C device driver > * > diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h > index 5ecb055..e0415e1 100644 > --- a/include/linux/i3c/device.h > +++ b/include/linux/i3c/device.h > @@ -187,6 +187,7 @@ static inline struct i3c_driver *drv_to_i3cdrv(struct device_driver *drv) > > struct device *i3cdev_to_dev(struct i3c_device *i3cdev); > struct i3c_device *dev_to_i3cdev(struct device *dev); > +const struct i3c_device_id *i3c_get_device_id(struct i3c_device *i3cdev); > > static inline void i3cdev_set_drvdata(struct i3c_device *i3cdev, > void *data) _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-06-06 18:54 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-06 15:12 [PATCH v2 0/3] Add ST lsm6dso i3c support Vitor Soares 2019-06-06 15:12 ` [PATCH v2 1/3] regmap: add i3c bus support Vitor Soares 2019-06-07 12:25 ` Mark Brown 2019-06-07 12:27 ` Applied "regmap: add i3c bus support" to the regmap tree Mark Brown 2019-06-06 15:12 ` [PATCH v2 2/3] i3c: add i3c_get_device_id helper Vitor Soares 2019-06-06 15:17 ` Boris Brezillon [this message] 2019-06-06 16:58 ` Vitor Soares 2019-06-06 15:12 ` [PATCH v2 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR Vitor Soares 2019-06-06 16:58 ` Lorenzo Bianconi 2019-06-06 17:21 ` Boris Brezillon 2019-06-06 17:50 ` Lorenzo Bianconi 2019-06-06 16:25 ` [PATCH v2 0/3] Add ST lsm6dso i3c support Wolfram Sang 2019-06-06 16:42 ` Vitor Soares 2019-06-06 18:01 ` Wolfram Sang 2019-06-11 11:42 ` Vitor Soares 2019-06-13 18:38 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190606171755.0feb8998@collabora.com \ --to=boris.brezillon@collabora.com \ --cc=Joao.Pinto@synopsys.com \ --cc=Vitor.Soares@synopsys.com \ --cc=bbrezillon@kernel.org \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lorenzo.bianconi83@gmail.com \ --cc=rafael@kernel.org \ --subject='Re: [PATCH v2 2/3] i3c: add i3c_get_device_id helper' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).