From: Boris Brezillon <boris.brezillon@collabora.com> To: Przemyslaw Gaj <pgaj@cadence.com> Cc: linux-i3c@lists.infradead.org, vitor.soares@synopsys.com, rafalc@cadence.com, agolec@cadence.com, bbrezillon@kernel.org Subject: Re: [PATCH v5 2/7] i3c: split i3c_master_register into init - register pair Date: Sat, 6 Jul 2019 10:48:53 +0200 Message-ID: <20190706104853.412c648f@collabora.com> (raw) In-Reply-To: <1561236905-8901-3-git-send-email-pgaj@cadence.com> On Sat, 22 Jun 2019 21:55:00 +0100 Przemyslaw Gaj <pgaj@cadence.com> wrote: > This patch is base for mastership takeover where secondary master is > initialized at probe time but register may be postponed till dynamic address is > assigned to our device. > > Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com> > --- > drivers/i3c/master.c | 86 ++++++++++++++++++++---------------- > drivers/i3c/master/dw-i3c-master.c | 34 +++++++------- > drivers/i3c/master/i3c-master-cdns.c | 45 ++++++++++--------- > include/linux/i3c/master.h | 12 ++--- > 4 files changed, 94 insertions(+), 83 deletions(-) > > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 0f7c31e..759078f 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -1528,32 +1528,9 @@ int i3c_master_do_daa(struct i3c_master_controller *master) > } > EXPORT_SYMBOL_GPL(i3c_master_do_daa); > > -/** > - * i3c_master_set_info() - set master device information > - * @master: master used to send frames on the bus > - * @info: I3C device information > - * > - * Set master device info. This should be called from > - * &i3c_master_controller_ops->bus_init(). > - * > - * Not all &i3c_device_info fields are meaningful for a master device. > - * Here is a list of fields that should be properly filled: > - * > - * - &i3c_device_info->dyn_addr > - * - &i3c_device_info->bcr > - * - &i3c_device_info->dcr > - * - &i3c_device_info->pid > - * - &i3c_device_info->hdr_cap if %I3C_BCR_HDR_CAP bit is set in > - * &i3c_device_info->bcr > - * > - * This function must be called with the bus lock held in maintenance mode. > - * > - * Return: 0 if @info contains valid information (not every piece of > - * information can be checked, but we can at least make sure @info->dyn_addr > - * and @info->bcr are correct), -EINVAL otherwise. > - */ > -int i3c_master_set_info(struct i3c_master_controller *master, > - const struct i3c_device_info *info) > +static int i3c_master_set_info(struct i3c_master_controller *master, > + const struct i3c_device_info *info, > + bool secondary) secondary is not used here, and this can be extracted from master->secondary anyway. I think you can drop this argument. > { > struct i3c_dev_desc *i3cdev; > int ret; > @@ -1586,7 +1563,6 @@ int i3c_master_set_info(struct i3c_master_controller *master, > > return ret; > } > -EXPORT_SYMBOL_GPL(i3c_master_set_info); > > static void i3c_master_detach_free_devs(struct i3c_master_controller *master) > { > @@ -2403,7 +2379,7 @@ static int i3c_master_check_ops(const struct i3c_master_controller_ops *ops) > } > > /** > - * i3c_master_register() - register an I3C master > + * i3c_master_init() - initializes all the structures required by I3C master > * @master: master used to send frames on the bus > * @parent: the parent device (the one that provides this I3C master > * controller) > @@ -2417,16 +2393,14 @@ static int i3c_master_check_ops(const struct i3c_master_controller_ops *ops) > * - creates and initializes the I3C bus > * - populates the bus with static I2C devs if @parent->of_node is not > * NULL > - * - registers all I3C devices added by the controller during bus > - * initialization > - * - registers the I2C adapter and all I2C devices > + * - set bus mode when registering I2C devices. > * > * Return: 0 in case of success, a negative error code otherwise. > */ > -int i3c_master_register(struct i3c_master_controller *master, > - struct device *parent, > - const struct i3c_master_controller_ops *ops, > - bool secondary) > +int i3c_master_init(struct i3c_master_controller *master, > + struct device *parent, > + const struct i3c_master_controller_ops *ops, > + bool secondary) Can we have i3c_primary_master_init() and i3c_secondary_master_init() instead of this secondary arg? You can provide them as wrappers around a generic i3c_master_init() if that make sense. > { > struct i3c_bus *i3cbus = i3c_master_get_bus(master); > enum i3c_bus_mode mode = I3C_BUS_MODE_PURE; > @@ -2488,10 +2462,47 @@ int i3c_master_register(struct i3c_master_controller *master, > ret = -ENOMEM; > goto err_put_dev; > } > + return 0; > + > +err_put_dev: > + put_device(&master->dev); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(i3c_master_init); _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-22 20:54 [PATCH v5 0/7] Add the I3C mastership request Przemyslaw Gaj 2019-06-22 20:54 ` [PATCH v5 1/7] i3c: add addr and lvr to i2c_dev_desc structure Przemyslaw Gaj 2019-06-22 20:55 ` [PATCH v5 2/7] i3c: split i3c_master_register into init - register pair Przemyslaw Gaj 2019-07-06 8:48 ` Boris Brezillon [this message] 2019-12-02 10:31 ` Przemyslaw Gaj 2019-06-22 20:55 ` [PATCH v5 3/7] i3c: export i3c_bus_set_mode function Przemyslaw Gaj 2019-07-06 7:39 ` Boris Brezillon 2019-06-22 20:55 ` [PATCH v5 4/7] i3c: Add support for mastership request to I3C subsystem Przemyslaw Gaj 2019-07-06 9:00 ` Boris Brezillon 2019-07-10 18:04 ` Vitor Soares 2019-07-11 5:28 ` Przemyslaw Gaj 2019-07-11 10:11 ` Vitor Soares 2019-07-12 10:10 ` Przemyslaw Gaj 2019-07-12 11:28 ` Vitor Soares 2019-08-11 10:17 ` Boris Brezillon 2019-08-12 13:55 ` Vitor Soares 2019-08-12 14:55 ` Boris Brezillon 2019-08-22 11:08 ` Vitor Soares 2019-06-22 20:55 ` [PATCH v5 5/7] i3c: master: cdns: add support for mastership request to Cadence I3C master driver Przemyslaw Gaj 2019-06-22 20:55 ` [PATCH v5 6/7] i3c: master: Add module author Przemyslaw Gaj 2019-06-22 20:55 ` [PATCH v5 7/7] MAINTAINERS: add myself as co-maintainer of i3c subsystem Przemyslaw Gaj
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190706104853.412c648f@collabora.com \ --to=boris.brezillon@collabora.com \ --cc=agolec@cadence.com \ --cc=bbrezillon@kernel.org \ --cc=linux-i3c@lists.infradead.org \ --cc=pgaj@cadence.com \ --cc=rafalc@cadence.com \ --cc=vitor.soares@synopsys.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-i3c Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-i3c/0 linux-i3c/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-i3c linux-i3c/ https://lore.kernel.org/linux-i3c \ linux-i3c@lists.infradead.org public-inbox-index linux-i3c Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-i3c AGPL code for this site: git clone https://public-inbox.org/public-inbox.git