From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EA7C76194 for ; Sat, 27 Jul 2019 14:11:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D52E32075E for ; Sat, 27 Jul 2019 14:11:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uiw97U1s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D52E32075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LG6lZY4cO0bqhb5h3SOF3AdCDK6CY8rDJGcl2Sl4Ddk=; b=Uiw97U1smYHalX +zdAzA1GHILnTiS6faiKcpOuGME6HAFQ6yI30aNN0S6Nxc9GQDuI+uJN65gZ5hBJeeEDMUTQrUsJ1 ZM+BN6CxCgAbmobP8EGlKhcQVaupR2xXm0gK1dl5x8BRaF3kzR6znyuPcSv2Ngd9ZVIYaeJY+4cB+ d5wnvfq7l3o8l32RtrB6YUGMBcX1P1KsK4fQB8mPa6CEUfNMV/NfimNErUCaNjn7LhYCbs5AZd339 gRqU9mdQ2Njb9vhzeGHYJukIFqfBpqCQ9X9E/Y0vfCMOyKlfV4XTTs9G7nFX9SJSD5qO5D7x5tsMg HmLwFNaf5gzsc4mHHd+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hrNQ2-0003Mg-2Y; Sat, 27 Jul 2019 14:11:30 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hrIr7-0004n3-LW; Sat, 27 Jul 2019 09:19:12 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 6A01527DC68; Sat, 27 Jul 2019 10:19:03 +0100 (BST) Date: Sat, 27 Jul 2019 11:18:59 +0200 From: Boris Brezillon To: Qii Wang Subject: Re: [PATCH v3 1/2] dt-bindings: i3c: Document MediaTek I3C master bindings Message-ID: <20190727111859.315994c3@collabora.com> In-Reply-To: <1564190613.24702.11.camel@mhfsdcap03> References: <1562677762-24067-1-git-send-email-qii.wang@mediatek.com> <1562677762-24067-2-git-send-email-qii.wang@mediatek.com> <20190724202119.GA26566@bogus> <1564190613.24702.11.camel@mhfsdcap03> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190727_021910_003741_11FBE749 X-CRM114-Status: GOOD ( 20.92 ) X-Mailman-Approved-At: Sat, 27 Jul 2019 07:11:26 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Rob Herring , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, leilk.liu@mediatek.com, bbrezillon@kernel.org, linux-kernel@vger.kernel.org, liguo.zhang@mediatek.com, linux-mediatek@lists.infradead.org, xinping.qian@mediatek.com, matthias.bgg@gmail.com, linux-i3c@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Sat, 27 Jul 2019 09:23:33 +0800 Qii Wang wrote: > On Wed, 2019-07-24 at 14:21 -0600, Rob Herring wrote: > > On Tue, Jul 09, 2019 at 09:09:21PM +0800, Qii Wang wrote: > > > Document MediaTek I3C master DT bindings. > > > > > > Signed-off-by: Qii Wang > > > --- > > > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 48 ++++++++++++++++++++ > > > 1 file changed, 48 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > > > > diff --git a/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > new file mode 100644 > > > index 0000000..d32eda6 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > @@ -0,0 +1,48 @@ > > > +Bindings for MediaTek I3C master block > > > +===================================== > > > + > > > +Required properties: > > > +-------------------- > > > +- compatible: shall be "mediatek,i3c-master" > > > > Needs to be SoC specific. > > > > We hope that the SOCs will use the same driver and try to avoid big > changes. If there are inevitable changes in the future, then we will > modify the compatible to be SoC specific. cdns,i3c-master.txt is not SoC > specific either. The cadence case is a bit different I think. When the driver was developed there was no SoC integrating this IP. I guess Mediatek knows already which SoC(s) will embed the I3C master block. > > > > +- reg: physical base address of the controller and apdma base, length of > > > + memory mapped region. > > > +- reg-names: shall be "main" for master controller and "dma" for apdma. > > > +- interrupts: the interrupt line connected to this I3C master. > > > +- clocks: shall reference the i3c and apdma clocks. > > > +- clock-names: shall include "main" and "dma". > > > + > > > +Mandatory properties defined by the generic binding (see > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > > + > > > +- #address-cells: shall be set to 3 > > > +- #size-cells: shall be set to 0 > > > + > > > +Optional properties defined by the generic binding (see > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > > + > > > +- i2c-scl-hz > > > +- i3c-scl-hz > > > + > > > +I3C device connected on the bus follow the generic description (see > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details). > > > + > > > +Example: > > > + > > > + i3c0: i3c@1100d000 { > > > + compatible = "mediatek,i3c-master"; > > > + reg = <0x1100d000 0x1000>, > > > + <0x11000300 0x80>; > > > + reg-names = "main", "dma"; > > > + interrupts = ; > > > + clocks = <&infracfg CLK_INFRA_I3C0>, > > > + <&infracfg CLK_INFRA_AP_DMA>; > > > + clock-names = "main", "dma"; > > > + #address-cells = <3>; > > > + #size-cells = <0>; > > > + i2c-scl-hz = <100000>; > > > + > > > + nunchuk: nunchuk@52 { > > > + compatible = "nintendo,nunchuk"; > > > + reg = <0x52 0x0 0x10>; > > > + }; > > > + }; > > > -- > > > 1.7.9.5 > > > > > _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c