From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79657C3A5A6 for ; Thu, 29 Aug 2019 16:15:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B1DC2189D for ; Thu, 29 Aug 2019 16:15:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cz900iG4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B1DC2189D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ybwybf9WLL01vFur05mLCNg1gtsQEqTHTweaWLPSz9I=; b=cz900iG4OwwKLK 09qMLiiXdV2YObXWB4Nhlgqw4gjkhvEMTiSHLwiwrzkYLdRdz30IknAjHZ93HgTMZtdaCCAZhpiKB JpZo3Ps41Cu5O9545ddQXz+8wuQLrpbcCb7TN/q/4LBEwq3ml3Ru7aUoGjOfM+EZ6GqX01X5l4MwR AuE+eBWtnkgfrU/LHEBvByAELst7ukhZRwRogzHQ4d5Gzfn29ngBhRsoppy+Bkyhs7YnAhQ80LT7R bkeGYfze1GO5soc6t8X3Slam+QSDvw34fa+hq8yEomjhPgHIszeRF7jL3K92rP916sEIKXnPBLAr1 je35Qq562yLoC0AGxDvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3N5D-0006WC-T6; Thu, 29 Aug 2019 16:15:35 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i3N5A-0006Tp-Kn for linux-i3c@lists.infradead.org; Thu, 29 Aug 2019 16:15:34 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8754D28D6D2; Thu, 29 Aug 2019 17:15:25 +0100 (BST) Date: Thu, 29 Aug 2019 18:15:20 +0200 From: Boris Brezillon To: Vitor Soares Subject: Re: [PATCH 2/4] i3c: master: Check if devices have i3c_dev_boardinfo on i3c_master_add_i3c_dev_locked() Message-ID: <20190829181520.0b33b642@collabora.com> In-Reply-To: References: <3e21481ddf53ea58f5899df6ec542b79b8cbcd68.1567071213.git.vitor.soares@synopsys.com> <20190829124457.3a750932@collabora.com> <20190829163918.571fd0d8@collabora.com> <20190829163941.45380b19@collabora.com> <20190829172441.3a76385e@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190829_091532_940027_31E62D81 X-CRM114-Status: GOOD ( 20.69 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "Joao.Pinto@synopsys.com" , "bbrezillon@kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-i3c@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Thu, 29 Aug 2019 15:57:32 +0000 Vitor Soares wrote: > -----Original Message----- > From: Boris Brezillon > > Sent: Thursday, August 29, 2019 4:25 > PM > To: Vitor Soares > Cc: > linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > linux-i3c@lists.infradead.org; bbrezillon@kernel.org; robh+dt@kernel.org; > mark.rutland@arm.com; Joao.Pinto@synopsys.com > Subject: Re: [PATCH 2/4] > i3c: master: Check if devices have i3c_dev_boardinfo on > i3c_master_add_i3c_dev_locked() > > On Thu, 29 Aug 2019 15:07:08 +0000 > Vitor Soares wrote: > > > From: Boris Brezillon > > > Date: Thu, Aug 29, 2019 at 15:39:41 > > > > > > On Thu, 29 Aug 2019 16:39:18 +0200 > > > Boris Brezillon wrote: > > > > > > > On Thu, 29 Aug 2019 14:00:44 +0000 > > > > Vitor Soares wrote: > > > > > > > > > Hi Boris, > > > > > > > > > > From: Boris Brezillon > > > > > Date: Thu, Aug 29, 2019 at 11:44:57 > > > > > > > > > > > On Thu, 29 Aug 2019 12:19:33 +0200 > > > > > > Vitor Soares wrote: > > > > > > > > > > > > > The I3C devices described in DT might not be attached to the master which > > > > > > > doesn't allow to assign a specific dynamic address. > > > > > > > > > > > > I remember testing this when developing the framework, so, unless > > > > > > another patch regressed it, it should already work. I suspect patch 1 > > > > > > is actually the regressing this use case. > > > > > > > > > > For today it doesn't address the case where the device is described with > > > > > static address = 0, which isn't attached to the controller. > > > > > > > > Hm, I'm pretty sure I had designed the code to support that case (see > > > > [1]). It might be buggy, but nothing we can't fix I guess. > > > > > > > > > > [1]https://urldefense.proofpoint.com/v2/url?u=https-3A__elixir.bootlin.com_linux_v5.3-2Drc6_source_drivers_i3c_master.c-23L1898&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=IXS1ygIgEo5vwajk0iwd5aBDVBzRnVTjO3cg4iBmGNc&s=HC-AcYm-AZPrUBoALioej_BDnqOtJHltr39Z2yPkuU4&e= > > > > That is only valid if you have olddev which will only exist if static > > address != 0. > > Hm, if you revert patch 1 (and assuming the device is properly defined > in the DT), you should have olddev != NULL when reaching that point. If > that's not the case there's a bug somewhere that should be fixed. > > No, because the device is not attached. Oh, my bad, I see what you mean now. This is definitely a bug and should have the Fixes tags. I mean, even if we don't care about dynamic address assignment, I3C drivers might care about the ->of_node that's attached to the device. _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c