linux-i3c.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Przemyslaw Gaj <pgaj@cadence.com>
To: Vitor Soares <Vitor.Soares@synopsys.com>
Cc: "linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
	"agolec@cadence.com" <agolec@cadence.com>,
	"rafalc@cadence.com" <rafalc@cadence.com>,
	"bbrezillon@kernel.org" <bbrezillon@kernel.org>
Subject: Re: [PATCH 0/3] Add data hold delay support
Date: Thu, 14 Nov 2019 13:48:56 +0100	[thread overview]
Message-ID: <20191114124855.GA13588@global.cadence.com> (raw)
In-Reply-To: <CH2PR12MB4216AF4224EDEE99E6C4B74FAE710@CH2PR12MB4216.namprd12.prod.outlook.com>

Hi Vitor,

The 11/14/2019 11:58, Vitor Soares wrote:
> 
> Hi,
> 
> From: Przemyslaw Gaj <pgaj@cadence.com>
> Date: Thu, Nov 14, 2019 at 05:51:52
> 
> > Add THD_DEL (Data Hold Delay) support. After testing different scenarios,
> > on various systems, sometimes there is a need to delay SDA_OUT propagation.
> > 
> > Adding support which allows to configure that delay using the device
> > tree parameter.
> > 
> > Przemyslaw Gaj (3):
> >   i3c: master: add data hold delay support
> >   dt-bindings: i3c: Document data hold delay feature
> >   MAINTAINERS: add myself as maintainer of Cadence I3C master controller
> >     driver
> > 
> >  Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt | 6 ++++++
> >  MAINTAINERS                                               | 6 ++++++
> >  drivers/i3c/master/i3c-master-cdns.c                      | 5 ++++-
> >  3 files changed, 16 insertions(+), 1 deletion(-)
> > 
> > -- 
> > 2.14.0
> 
> I'm trying to understand this implementation and the use case but I'm not 
> understanding.
> 
> Could you please elaborate?

There is new controller functionality which allows to meet SDA to SCL
propagation time. Baisically, you can delay SDA propagation using this
functionality to meet I3C MIPI spec timing. This is very useful for some
SoC designs.

From Spec:
Table 75 of MIPI I3C Specification 1.0 (page 142) defines non-zero
minimal tHD_PP timing on master output (Fig 65). This setting allows to
meet this timing on master's soc outputs, regardless of PCB balancing.

> 
> Best regards,
> Vitor Soares

-- 
-- 
Przemyslaw Gaj

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply	other threads:[~2019-11-14 12:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14  5:51 [PATCH 0/3] Add data hold delay support Przemyslaw Gaj
2019-11-14  5:51 ` [PATCH 1/3] i3c: master: add " Przemyslaw Gaj
2019-11-14 13:38   ` Vitor Soares
2019-11-14  5:51 ` [PATCH 2/3] dt-bindings: i3c: Document data hold delay feature Przemyslaw Gaj
2019-11-14  9:15   ` Boris Brezillon
2019-11-14  9:26     ` Boris Brezillon
2019-11-14 10:54       ` Przemyslaw Gaj
2019-11-14 11:09         ` Boris Brezillon
2019-11-14 11:35           ` Przemyslaw Gaj
2019-11-14  5:51 ` [PATCH 3/3] MAINTAINERS: add myself as maintainer of Cadence I3C master controller driver Przemyslaw Gaj
2019-11-15  5:09   ` Boris Brezillon
2019-11-14 11:58 ` [PATCH 0/3] Add data hold delay support Vitor Soares
2019-11-14 12:48   ` Przemyslaw Gaj [this message]
2019-11-14 13:31     ` Vitor Soares
2019-11-14 13:46       ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191114124855.GA13588@global.cadence.com \
    --to=pgaj@cadence.com \
    --cc=Vitor.Soares@synopsys.com \
    --cc=agolec@cadence.com \
    --cc=bbrezillon@kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=rafalc@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).