Linux-i3c Archive on
 help / color / Atom feed
From: "Ben Dooks (Codethink)" <>
	Boris Brezillon <>
Subject: [PATCH] i3c: make 'i3c_bus_set_mode' static
Date: Tue, 17 Dec 2019 12:01:50 +0000
Message-ID: <> (raw)

The function i3c_bus_set_mode() is not declared or
exported, so make it static to avoid the following

drivers/i3c/master.c:530:5: warning: symbol 'i3c_bus_set_mode' was not declared. Should it be static?

If it is needed in the future, then it should be declared
and suitably exported.

Signed-off-by: Ben Dooks (Codethink) <>
Cc: Boris Brezillon <>
 drivers/i3c/master.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 043691656245..7f8f896fa0c3 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -527,8 +527,8 @@ static const struct device_type i3c_masterdev_type = {
 	.groups	= i3c_masterdev_groups,
-int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode,
-		     unsigned long max_i2c_scl_rate)
+static int i3c_bus_set_mode(struct i3c_bus *i3cbus, enum i3c_bus_mode mode,
+			    unsigned long max_i2c_scl_rate)
 	struct i3c_master_controller *master = i3c_bus_to_i3c_master(i3cbus);

linux-i3c mailing list

             reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 12:01 Ben Dooks (Codethink) [this message]
2019-12-18  8:27 ` Boris Brezillon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-i3c Archive on

Archives are clonable:
	git clone --mirror linux-i3c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i3c linux-i3c/ \
	public-inbox-index linux-i3c

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone