From: Boris Brezillon <boris.brezillon@collabora.com>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: [PATCH] i3c: master: use 'dev' variable in dev_err
Date: Wed, 26 Feb 2020 10:06:01 +0100 [thread overview]
Message-ID: <20200226100601.2fc86032@collabora.com> (raw)
In-Reply-To: <20200224083439.3487-1-luca@lucaceresoli.net>
Hello Lucas,
On Mon, 24 Feb 2020 09:34:39 +0100
Luca Ceresoli <luca@lucaceresoli.net> wrote:
> of_i3c_master_add_i2c_boardinfo() already has a handy 'dev' variable, use
> it and simplify code.
I already applied a similar patch from Wolfram, but thanks for your
contribution.
Regards,
Boris
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> drivers/i3c/master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 7f8f896fa0c3..b56207bbed2b 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1953,7 +1953,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
> * DEFSLVS command.
> */
> if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> - dev_err(&master->dev, "I2C device with 10 bit address not supported.");
> + dev_err(dev, "I2C device with 10 bit address not supported.");
> return -ENOTSUPP;
> }
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2020-02-26 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 8:34 [PATCH] i3c: master: use 'dev' variable in dev_err Luca Ceresoli
2020-02-26 9:06 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226100601.2fc86032@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=bbrezillon@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).