Re: [PATCH 2/2] i3c/master: add the mipi-i3c-hci driver

From: kernel test robot <lkp@intel.com>
To: Nicolas Pitre <nico@fluxnic.net>,
	Boris Brezillon <bbrezillon@kernel.org>,
	linux-i3c@lists.infradead.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, Laura Nixon <laura.nixon@team.mipi.org>,
	Rob Herring <robh+dt@kernel.org>,
	Robert Gough <robert.gough@intel.com>,
	Matthew Schnoor <matthew.schnoor@intel.com>,
	Nicolas Pitre <npitre@baylibre.com>
Subject: Re: [PATCH 2/2] i3c/master: add the mipi-i3c-hci driver
Date: Fri, 14 Aug 2020 13:53:05 +0800	[thread overview]
Message-ID: <202008141315.mqzYaJyW%lkp@intel.com> (raw)
In-Reply-To: <20200814034854.460830-3-nico@fluxnic.net>

[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]

Hi Nicolas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v5.8 next-20200814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nicolas-Pitre/MIPI-I3c-HCI-Host-Controller-Interface-driver/20200814-115156
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/i3c/master/mipi-i3c-hci/core.c:107: warning: "PIO_OFFSET" redefined
     107 | #define PIO_OFFSET   GENMASK(15, 0) /* PIO Offset */
         | 
   In file included from include/linux/io.h:13,
                    from arch/mips/include/asm/mips-cps.h:10,
                    from arch/mips/include/asm/smp-ops.h:16,
                    from arch/mips/include/asm/smp.h:21,
                    from include/linux/smp.h:82,
                    from include/linux/lockdep.h:14,
                    from include/linux/rcupdate.h:29,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/ratelimit.h:6,
                    from include/linux/dev_printk.h:16,
                    from include/linux/device.h:15,
                    from drivers/i3c/master/mipi-i3c-hci/core.c:11:
   arch/mips/include/asm/io.h:76: note: this is the location of the previous definition
      76 | #define PIO_OFFSET mips_io_port_base
         | 

vim +/PIO_OFFSET +107 drivers/i3c/master/mipi-i3c-hci/core.c

   105	
   106	#define PIO_SECTION_OFFSET		0x3c
 > 107	#define PIO_OFFSET			GENMASK(15, 0)	/* PIO Offset */
   108	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 67618 bytes --]

[-- Attachment #3: Type: text/plain, Size: 111 bytes --]

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c