From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: devicetree@vger.kernel.org,
Rajeev Huralikoppi <rajeev.huralikoppi@silvaco.com>,
Nicolas Pitre <nico@fluxnic.net>,
linux-kernel@vger.kernel.org,
Boris Brezillon <boris.brezillon@collabora.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-i3c@lists.infradead.org,
Conor Culhane <conor.culhane@silvaco.com>
Subject: Re: [PATCH v2 2/4] dt-bindings: i3c: Describe Silvaco master binding
Date: Mon, 24 Aug 2020 17:24:38 -0600 [thread overview]
Message-ID: <20200824232438.GA3525200@bogus> (raw)
In-Reply-To: <20200812141312.3331-2-miquel.raynal@bootlin.com>
On Wed, Aug 12, 2020 at 04:13:10PM +0200, Miquel Raynal wrote:
> Silvaco provide a dual-role I3C master.
>
> Description is rather simple: it needs a register mapping, three
> clocks and an interrupt.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Changes in v2:
> * Updated Rob's tool and fixed the mistake reported.
> * Updated the vendor prefix.
>
> .../bindings/i3c/silvaco,i3c-master.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
>
> diff --git a/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> new file mode 100644
> index 000000000000..63731e8a9068
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/i3c/silvaco,i3c-master.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Silvaco I3C master
> +
> +maintainers:
> + - Conor Culhane <conor.culhane@silvaco.com>
> +
> +properties:
> + compatible:
> + const: silvaco,i3c-master
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clock-names:
> + description: |
> + There are three clocks:
> + pclk: System clock
> + fast_clk: Fast clock (for the bus)
> + slow_clk: Slow clock (for other events)
You basically say this in the schema... If you want some description, do
it in 'clocks':
clocks:
items:
- description: ...
- description: ...
- description: ...
> +
> + items:
> + - const: pclk
> + - const: fast_clk
> + - const: slow_clk
> +
> + clocks:
> + minItems: 3
> + maxItems: 3
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clock-names
> + - clocks
additionalProperties: false
And that will point out some errors in the example.
> +
> +examples:
> + - |
> + i3c-master@a0000000 {
> + compatible = "silvaco,i3c-master";
> + clocks = <&zynqmp_clk 71>, <&fclk>, <&sclk>;
> + clock-names = "pclk", "fast_clk", "slow_clk";
> + interrupt-parent = <&gic>;
> + interrupts = <0 89 4>;
> + reg = <0xa0000000 0x1000>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> --
> 2.20.1
>
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-08-24 23:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:13 [PATCH v2 1/4] dt-bindings: Add vendor prefix for Silvaco Miquel Raynal
2020-08-12 14:13 ` [PATCH v2 2/4] dt-bindings: i3c: Describe Silvaco master binding Miquel Raynal
2020-08-24 23:24 ` Rob Herring [this message]
2020-08-12 14:13 ` [PATCH v2 3/4] i3c: master: svc: Add Silvaco I3C master driver Miquel Raynal
2020-08-12 15:18 ` Miquel Raynal
2020-08-19 9:04 ` Boris Brezillon
2020-12-28 16:04 ` Miquel Raynal
2020-08-12 14:13 ` [PATCH v2 4/4] MAINTAINERS: Add Silvaco I3C master Miquel Raynal
2020-08-12 15:07 ` Miquel Raynal
2020-08-24 23:21 ` [PATCH v2 1/4] dt-bindings: Add vendor prefix for Silvaco Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824232438.GA3525200@bogus \
--to=robh@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=conor.culhane@silvaco.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=nico@fluxnic.net \
--cc=rajeev.huralikoppi@silvaco.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).