From: Nathan Chancellor <natechancellor@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Arnd Bergmann <arnd@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, Nicolas Pitre <npitre@baylibre.com>,
clang-built-linux@googlegroups.com,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-i3c@lists.infradead.org
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: re-fix __maybe_unused attribute
Date: Wed, 30 Dec 2020 14:43:21 -0700 [thread overview]
Message-ID: <20201230214321.GA1961980@ubuntu-m3-large-x86> (raw)
In-Reply-To: <20201230214053.GB110311@piout.net>
On Wed, Dec 30, 2020 at 10:40:53PM +0100, Alexandre Belloni wrote:
> On 30/12/2020 16:23:56-0500, Nicolas Pitre wrote:
> > On Wed, 30 Dec 2020, Arnd Bergmann wrote:
> >
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > clang warns because the added __maybe_unused attribute is in
> > > the wrong place:
> > >
> > > drivers/i3c/master/mipi-i3c-hci/core.c:780:21: error: attribute declaration must precede definition [-Werror,-Wignored-attributes]
> > > static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> > > ^
> > > include/linux/compiler_attributes.h:267:56: note: expanded
> > >
> > > Fixes: 95393f3e07ab ("i3c/master/mipi-i3c-hci: quiet maybe-unused variable warning")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Acked-by: Nicolas Pitre <npitre@baylibre.com>
> >
> > This might be the 3rd patch from 3 different people fixing the same
> > thing. Looks like I3C maintainer is on vacation. Please feel free to
> > send this trivial fix upstream some other way.
> >
>
> Isn't it already upstream?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=95393f3e07ab53855b91881692a4a5b52dcdc03c
This patch is fixing that one, the attribute was added between the
struct type, causing a new warning for clang.
I sent a fix for this earlier too, I do not care which one goes in as
long as one does so:
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Cheers,
Nathan
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-12-31 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 15:42 [PATCH] i3c/master/mipi-i3c-hci: re-fix __maybe_unused attribute Arnd Bergmann
2020-12-30 21:23 ` Nicolas Pitre
2020-12-30 21:40 ` Alexandre Belloni
2020-12-30 21:43 ` Nathan Chancellor [this message]
2020-12-30 22:00 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230214321.GA1961980@ubuntu-m3-large-x86 \
--to=natechancellor@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=npitre@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).