From: Nicolas Pitre <npitre@baylibre.com>
To: David Gow <davidgow@google.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: Specify HAS_IOMEM dependency
Date: Mon, 1 Feb 2021 11:18:37 -0500 (EST) [thread overview]
Message-ID: <9s6n963q-poro-6qnq-q510-83rr59785on@onlyvoer.pbz> (raw)
In-Reply-To: <20210127040636.1535722-1-davidgow@google.com>
On Tue, 26 Jan 2021, David Gow wrote:
> The MIPI i3c HCI driver makes use of IOMEM functions like
> devm_platform_ioremap_resource(), which are only available if
> CONFIG_HAS_IOMEM is defined.
>
> This causes the driver to be enabled under make ARCH=um allyesconfig,
> even though it won't build.
>
> By adding a dependency on HAS_IOMEM, the driver will not be enabled on
> architectures which don't support it.
>
> Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
> Signed-off-by: David Gow <davidgow@google.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
> ---
> drivers/i3c/master/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i3c/master/Kconfig b/drivers/i3c/master/Kconfig
> index e68f15f4b4d0..afff0e2320f7 100644
> --- a/drivers/i3c/master/Kconfig
> +++ b/drivers/i3c/master/Kconfig
> @@ -25,6 +25,7 @@ config DW_I3C_MASTER
> config MIPI_I3C_HCI
> tristate "MIPI I3C Host Controller Interface driver (EXPERIMENTAL)"
> depends on I3C
> + depends on HAS_IOMEM
> help
> Support for hardware following the MIPI Aliance's I3C Host Controller
> Interface specification.
> --
> 2.30.0.280.ga3ce27912f-goog
>
>
> --
> linux-i3c mailing list
> linux-i3c@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-i3c
>
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2021-02-01 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 4:06 [PATCH] i3c/master/mipi-i3c-hci: Specify HAS_IOMEM dependency David Gow
2021-01-27 14:17 ` Nicolas Pitre
2021-02-01 16:18 ` Nicolas Pitre [this message]
2021-02-01 23:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9s6n963q-poro-6qnq-q510-83rr59785on@onlyvoer.pbz \
--to=npitre@baylibre.com \
--cc=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=davidgow@google.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).