From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CDFC10F14 for ; Tue, 16 Apr 2019 11:12:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4822F20693 for ; Tue, 16 Apr 2019 11:12:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qjIsvvqf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RV4F8TY+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4822F20693 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v6GxLaa9pp1aemUuDyeGIycPOy9ODx6wlec39GcHnkU=; b=qjIsvvqfYEx2Rg 0AK9gsNCUhBBlB04lKjW1ddwXZGZMDnKC03KWfhwYZsEazUtZDUpdPkHQ81JYLJnvG7cKV5Ezw1a5 OU79dpiY8Ne/TJE6G6XA4j3f1VAE4cdgacyMwEOX7vOaNg7FmeQU7ZTu2aslkfVUrecrBZgy9KxCL ntcDC+8mnEE1oqUWfeqFjnNQCSldCivE7pouD7e2neRuQaB/656zRVIH4BJCtlWL6tReb7oTictnP 9SJ/c0xY0C5R5NZoB35TLad1LO7R+M+tUPQOgSynlgUxx74GAz31+7xsrvtLrVPVQ4/qKQBOaVUFp 9nKN9sOgpJuBWQTEqBwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGM0p-0001FS-QQ; Tue, 16 Apr 2019 11:12:27 +0000 Received: from mail-yw1-xc44.google.com ([2607:f8b0:4864:20::c44]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hG9vP-0005zK-OG for linux-i3c@lists.infradead.org; Mon, 15 Apr 2019 22:18:05 +0000 Received: by mail-yw1-xc44.google.com with SMTP id e76so6603942ywa.9 for ; Mon, 15 Apr 2019 15:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KsVNSmLrpdepymBy/9IERbdG/BVuPWrYSmVZnRBfrkI=; b=RV4F8TY+iryxWOE3DU7Y3Z0HVXW3qr/HroFR1vJIrrxo6O9e9Jj89G5/iYazNyx36W UVZn1GWFN7WeMyI3CZwqWcAw3FgZYL5cvml0TB7ArrPIF1+uW7zwMHDDoHMGzOv9+0tO KUV+yzD/2oAOBik2i8dC3dYhlVvfuFEFA4XmCZkniuaSco3FgKTRFtjToSRM56tK+9+l d6yCHrqqyUMuIQLypXECq4MB4WSoOLj4yVxKYqPUyEHgYy9YlMOcATYlizTtyxETCNuC Qok5QPs5PTBVrAUhoU7fyEm2L7DoKlmx5PLt3cAnUAHV9ITTrdOe203srXNbNjcJc9XT 4fPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KsVNSmLrpdepymBy/9IERbdG/BVuPWrYSmVZnRBfrkI=; b=jWtqI7aLpxeOTMIWJRzfyiSCYkQuYtkci2wG20xarb5TP7L/5qua3GrviicT2fHD9t +RFPsz7x5/3peScjep0RsKqnPfrTo+iig0qnoPbPl9THk6EGo6mmx2RNIHjNCkNCLvI8 HZezNl4LnaoJmyzjhzY7KTwNODCv/ENvU0FD6LVWwWdWnqvUNFMacCJj03gv84vjERKX Img2kr893LQ7cKF+Oa2ZiG52Pj97D2E4KytaG21I5weZA4lLyrjZZT2F0FVk1PbNHmur RBICRmJUfFQaYoOcef2BptBDrIOIwjY5xdEl6nUEL7mzqKtQRPUf9M8LDpTPv3F8Yr4q k7Vg== X-Gm-Message-State: APjAAAWlIhKYi+LuV4z3fC/tB6TRXEsFKbIXR+iAhOk0nLyeyR+ueHyw 0kg6/gfT1tZ+fNNsmM3E7jbRK+18jLuGoTj5KXg= X-Google-Smtp-Source: APXvYqwdE4Zjqwqv/VgwDHv+G7RPX8Od41EX/7acrXUCFkwzYpcOZM5xSi2RE9uGrJkIaXgoKR6n9t5/1b3GT2hXOlI= X-Received: by 2002:a81:5f88:: with SMTP id t130mr63436408ywb.453.1555366681385; Mon, 15 Apr 2019 15:18:01 -0700 (PDT) MIME-Version: 1.0 References: <302f8296299d6cd25b3689f5eca1c510a3290db3.1555354268.git.vitor.soares@synopsys.com> In-Reply-To: <302f8296299d6cd25b3689f5eca1c510a3290db3.1555354268.git.vitor.soares@synopsys.com> From: Lorenzo Bianconi Date: Tue, 16 Apr 2019 00:17:50 +0200 Message-ID: Subject: Re: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support To: Vitor Soares X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190415_151803_819331_1238E6AD X-CRM114-Status: GOOD ( 20.84 ) X-Mailman-Approved-At: Tue, 16 Apr 2019 04:12:26 -0700 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , bbrezillon@kernel.org, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, joao.pinto@synopsys.com, rafael@kernel.org, broonie@kernel.org, Peter Meerwald-Stadler , Hartmut Knaack , linux-i3c@lists.infradead.org, Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org > > For today the st_lsm6dsx driver support lsm6dso sensor only in > spi and i2c mode. > > The lsm6dso is also i3c capable so lets give i3c support to it. > Hi Vitor, thx, this is very cool :) Just a couple of nit inline Regards, Lorenzo > Signed-off-by: Vitor Soares > --- > drivers/iio/imu/st_lsm6dsx/Kconfig | 8 +++- > drivers/iio/imu/st_lsm6dsx/Makefile | 1 + > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c | 67 +++++++++++++++++++++++++++++ > 3 files changed, 75 insertions(+), 1 deletion(-) > create mode 100644 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c > > diff --git a/drivers/iio/imu/st_lsm6dsx/Kconfig b/drivers/iio/imu/st_lsm6dsx/Kconfig > index 094fd00..1ab9bbf 100644 > --- a/drivers/iio/imu/st_lsm6dsx/Kconfig > +++ b/drivers/iio/imu/st_lsm6dsx/Kconfig > @@ -1,11 +1,12 @@ > > config IIO_ST_LSM6DSX > tristate "ST_LSM6DSx driver for STM 6-axis IMU MEMS sensors" > - depends on (I2C || SPI) > + depends on (I2C || SPI || I3C) > select IIO_BUFFER > select IIO_KFIFO_BUF > select IIO_ST_LSM6DSX_I2C if (I2C) > select IIO_ST_LSM6DSX_SPI if (SPI_MASTER) > + select IIO_ST_LSM6DSX_I3C if (I3C) > help > Say yes here to build support for STMicroelectronics LSM6DSx imu > sensor. Supported devices: lsm6ds3, lsm6ds3h, lsm6dsl, lsm6dsm, > @@ -23,3 +24,8 @@ config IIO_ST_LSM6DSX_SPI > tristate > depends on IIO_ST_LSM6DSX > select REGMAP_SPI > + > +config IIO_ST_LSM6DSX_I3C > + tristate > + depends on IIO_ST_LSM6DSX > + select REGMAP_I3C > diff --git a/drivers/iio/imu/st_lsm6dsx/Makefile b/drivers/iio/imu/st_lsm6dsx/Makefile > index e5f733c..c676965 100644 > --- a/drivers/iio/imu/st_lsm6dsx/Makefile > +++ b/drivers/iio/imu/st_lsm6dsx/Makefile > @@ -4,3 +4,4 @@ st_lsm6dsx-y := st_lsm6dsx_core.o st_lsm6dsx_buffer.o \ > obj-$(CONFIG_IIO_ST_LSM6DSX) += st_lsm6dsx.o > obj-$(CONFIG_IIO_ST_LSM6DSX_I2C) += st_lsm6dsx_i2c.o > obj-$(CONFIG_IIO_ST_LSM6DSX_SPI) += st_lsm6dsx_spi.o > +obj-$(CONFIG_IIO_ST_LSM6DSX_I3C) += st_lsm6dsx_i3c.o > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c > new file mode 100644 > index 0000000..2df5e70 > --- /dev/null > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_i3c.c > @@ -0,0 +1,67 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2018 Synopsys, Inc. and/or its affiliates. > + * > + * Author: Vitor Soares > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "st_lsm6dsx.h" > + > +#define NAME_SIZE 32 > + > +struct st_lsm6dsx_i3c_data { > + char name[NAME_SIZE]; > + enum st_lsm6dsx_hw_id id; > +}; > + > +static const struct st_lsm6dsx_i3c_data hw_data[] = { > + { ST_LSM6DSO_DEV_NAME, ST_LSM6DSO_ID }, > +}; > + > +static const struct regmap_config st_lsm6dsx_i3c_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > +}; > + > +static int st_lsm6dsx_i3c_probe(struct i3c_device *i3cdev) > +{ > + const struct i3c_device_id *id = i3c_get_device_id(i3cdev); > + const struct st_lsm6dsx_i3c_data *hw_data = id->data; > + struct regmap *regmap; > + > + regmap = devm_regmap_init_i3c(i3cdev, &st_lsm6dsx_i3c_regmap_config); > + if (IS_ERR(regmap)) { > + dev_err(&i3cdev->dev, "Failed to register i3c regmap %d\n", > + (int)PTR_ERR(regmap)); > + return PTR_ERR(regmap); > + } > + > + return st_lsm6dsx_probe(&i3cdev->dev, 0, hw_data->id, > + hw_data->name, regmap); In order to support the hw FIFO, I guess you are planning to support interrupts/IBI here > +} > + please remove 'new line' here > + > +static const struct i3c_device_id st_lsm6dsx_i3c_ids[] = { > + I3C_DEVICE(0x0104, 0x006C, &hw_data[0]), > + { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(i3c, st_lsm6dsx_i3c_ids); > + > +static struct i3c_driver st_lsm6dsx_driver = { > + .driver.name = "st_lsm6dsx_i3c", > + .probe = st_lsm6dsx_i3c_probe, > + .id_table = st_lsm6dsx_i3c_ids, > +}; > +module_i3c_driver(st_lsm6dsx_driver); > + > +MODULE_AUTHOR("Vitor Soares "); > +MODULE_DESCRIPTION("STMicroelectronics st_lsm6dsx i3c driver"); > +MODULE_LICENSE("GPL v2"); > + > -- > 2.7.4 > -- UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch; unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp; umount; make clean; sleep _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c