From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F91C64E7B for ; Tue, 1 Dec 2020 07:39:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFAD22085B for ; Tue, 1 Dec 2020 07:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NJ8NiPQL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NiJ729oC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFAD22085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8zh48Wr7okzNmuFzY9tecnJtqqjl2HU1e/yt9+n8I+0=; b=NJ8NiPQLSgDhzEHySrhgKWUXH bhxxxqDG3x6rfVzcjtqEICtijRMJoiYeiToh1PubhNRAVkJp2HF2Pg6Jy9iWJ5U1OPQ/WNrBmXICD 9U28XQK4JnJvnIKzQ1J1cEduKFwQVL1xMI/eRXC6JeUK40vB4kCTgYcpWhZ19dToRgIdCBx0ynAN3 +7/jvaFRjNLAZZK5amk4V0ZGW4emQPXJLHy71b/AkEAVwc123lGbM+5uSuaHkF5Ja8DuWeoQm47WV QPQrO0TNQj1r6jtXHI2SSovVexp01pvfB4ALc9hGuC1rtbNkau4bKWCeaSEqihjCh7ENgxlPMittv TvXmDQUZQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kk0G1-0007Se-Gr; Tue, 01 Dec 2020 07:39:29 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiK04-00078g-4w for linux-i3c@lists.infradead.org; Thu, 26 Nov 2020 16:20:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606407601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IL7sPB68gF1YeWIUFuBJ//YIBDjI3bDL6qHHKubt/Z0=; b=NiJ729oCq6c/YFQ51l+ggQeIRtqmPp8H4lLJ165EPFvwB6PSNWB+uvZPeGDPsC2S2+j5TO AaEzfoBzCEevbIHTDE5y60URPa+B+7F1vB/rNId1UMFIOc3mMYxjHW3C6vOkUpq5aSwAHE jbtKjAXJTBKoSDdqsJF0ArriU45uZp0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-495-56vrTJnzP8GpNb5M7v5Fdg-1; Thu, 26 Nov 2020 11:18:25 -0500 X-MC-Unique: 56vrTJnzP8GpNb5M7v5Fdg-1 Received: by mail-qv1-f72.google.com with SMTP id s8so1496100qvr.20 for ; Thu, 26 Nov 2020 08:18:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IL7sPB68gF1YeWIUFuBJ//YIBDjI3bDL6qHHKubt/Z0=; b=a96ZidFpttKcEYCa3nMmShbbDcH4ZpNCNmEep+rA+FBTXtl9U2SMELPgmOtAOmHk0m 8p4zVh61KtYeDIwgjB6EwWsUMt3SUWUmPdd1o14PTPAELH1GX54lthykWda7IKzULNhI Rsow9OJwpm5ErOE3naLnazuwFyuBaQjgRTNfNU4QYUfcSYNVQPgzCfjQnnWDK569TCLm oXd/aUcWgO3ry6QAHZ9Z8E5VNn99mXS3snfW93jvlfILJS38b0Jaq6Zn5PGJT8r/JQxR 3vrNz8ZlIUv3isJk6/btEh+SYasSnJW2ifcfIbHLXEU8ezopRbsyodZiMaoh1vAqOYgX GvaA== X-Gm-Message-State: AOAM531qH69yezS+0bTCZj4rGt29T896ERC1os4SCp7OsA2VXupTJme8 7MBJ6j4T+DQ0ubMhWbpgj9hcyhktflBGrrV6q6PXosmfJxMDMsvkyeSpp/EawXx+IzFb+PR+Rfe HS8QmJo2hkbOcMwVONDngmQa0jRrc7jDTR1VKeR4TOw== X-Received: by 2002:a37:ac8:: with SMTP id 191mr3793945qkk.381.1606407504816; Thu, 26 Nov 2020 08:18:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCU4CKAolN2PpaYdMoKCHma/+NC3lHjkQkQkRPTWC20j3rANbYTTy+FG9V7n634RRlgf0kcsxPjR4LO+NB5fA= X-Received: by 2002:a37:ac8:: with SMTP id 191mr3793888qkk.381.1606407504531; Thu, 26 Nov 2020 08:18:24 -0800 (PST) MIME-Version: 1.0 References: <20201120105344.4345c14e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202011201129.B13FDB3C@keescook> <20201120115142.292999b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202011220816.8B6591A@keescook> <9b57fd4914b46f38d54087d75e072d6e947cb56d.camel@HansenPartnership.com> <1c7d7fde126bc0acf825766de64bf2f9b888f216.camel@HansenPartnership.com> <4993259d01a0064f8bb22770503490f9252f3659.camel@HansenPartnership.com> <44005bde-f6d4-5eaa-39b8-1a5efeedb2d3@gmail.com> In-Reply-To: From: Karol Herbst Date: Thu, 26 Nov 2020 17:18:13 +0100 Message-ID: Subject: Re: [PATCH 000/141] Fix fall-through warnings for Clang To: Geert Uytterhoeven Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kherbst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_112004_423613_1DBEDAE0 X-CRM114-Status: GOOD ( 28.64 ) X-Mailman-Approved-At: Tue, 01 Dec 2020 02:39:23 -0500 X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ALSA Development Mailing List , linux-atm-general@lists.sourceforge.net, linux-iio@vger.kernel.org, linux-wireless , Linux Fbdev development list , dri-devel , virtualization@lists.linux-foundation.org, James Bottomley , linux-ide@vger.kernel.org, dm-devel@redhat.com, target-devel , MTD Maling List , GR-everest-linux-l2@marvell.com, wcn36xx@lists.infradead.org, linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, "open list:NFS, SUNRPC, AND..." , linux-afs@lists.infradead.org, usb-storage@lists.one-eyed-alien.net, Lars Ellenberg , driverdevel , linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, scsi , Edward Cree , linux-rdma , oss-drivers@netronome.com, bridge@lists.linux-foundation.org, amd-gfx list , linux-stm32@st-md-mailman.stormreply.com, cluster-devel@redhat.com, ACPI Devel Maling List , coreteam@netfilter.org, intel-wired-lan@lists.osuosl.org, "Gustavo A. R. Silva" , linux-input , Miguel Ojeda , Jakub Kicinski , Ext4 Developers List , Linux Media Mailing List , Kees Cook , selinux@vger.kernel.org, linux-arm-msm , Intel Graphics Development , reiserfs-devel@vger.kernel.org, linux-geode@lists.infradead.org, linux-block@vger.kernel.org, "open list:GPIO SUBSYSTEM" , op-tee@lists.trustedfirmware.org, linux-mediatek@lists.infradead.org, samba-technical@lists.samba.org, xen-devel@lists.xenproject.org, Nouveau Dev , linux-hams@vger.kernel.org, ceph-devel , linux-can@vger.kernel.org, Linux ARM , linux-hwmon@vger.kernel.org, Nick Desaulniers , Linux Watchdog Mailing List , GR-Linux-NIC-Dev@marvell.com, tipc-discussion@lists.sourceforge.net, Linux-MM , Network Development , linux-decnet-user@lists.sourceforge.net, Linux MMC List , linux-sctp@vger.kernel.org, linux-kernel , Nathan Chancellor , Miguel Ojeda , linux-security-module , keyrings@vger.kernel.org, NetFilter , Linux Crypto Mailing List , patches@opensource.cirrus.com, Joe Perches , Linux-Renesas , linux-integrity , USB list , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Thu, Nov 26, 2020 at 4:28 PM Geert Uytterhoeven wrote: > > Hi Miguel, > > On Thu, Nov 26, 2020 at 3:54 PM Miguel Ojeda > wrote: > > On Wed, Nov 25, 2020 at 11:44 PM Edward Cree wrote: > > > To make the intent clear, you have to first be certain that you > > > understand the intent; otherwise by adding either a break or a > > > fallthrough to suppress the warning you are just destroying the > > > information that "the intent of this code is unknown". > > > > If you don't know what the intent of your own code is, then you > > *already* have a problem in your hands. > > The maintainer is not necessarily the owner/author of the code, and > thus may not know the intent of the code. > > > > or does it flag up code > > > that can be mindlessly "fixed" (in which case the warning is > > > worthless)? Proponents in this thread seem to be trying to > > > have it both ways. > > > > A warning is not worthless just because you can mindlessly fix it. > > There are many counterexamples, e.g. many > > checkpatch/lint/lang-format/indentation warnings, functional ones like > > the `if (a = b)` warning... > > BTW, you cannot mindlessly fix the latter, as you cannot know if > "(a == b)" or "((a = b))" was intended, without understanding the code > (and the (possibly unavailable) data sheet, and the hardware, ...). > to allow assignments in if statements was clearly a mistake and if you need outside information to understand the code, your code is the issue already. > P.S. So far I've stayed out of this thread, as I like it if the compiler > flags possible mistakes. After all I was the one fixing new > "may be used uninitialized" warnings thrown up by gcc-4.1, until > (a bit later than) support for that compiler was removed... > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c