From: Arnd Bergmann <arnd@arndb.de>
To: Vitor Soares <Vitor.Soares@synopsys.com>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
Wolfram Sang <wsa@the-dreams.de>,
gregkh <gregkh@linuxfoundation.org>,
Boris Brezillon <bbrezillon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-i3c@lists.infradead.org
Subject: Re: [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev
Date: Tue, 10 Dec 2019 18:51:14 +0100 [thread overview]
Message-ID: <CAK8P3a1cwoTbT3zsa-tfApwewDT1-ksHZs6_vkBYpKbgptsfjw@mail.gmail.com> (raw)
In-Reply-To: <f9f20eaf900ed5629dd3d824bc1e90c7e6b4a371.1575977795.git.vitor.soares@synopsys.com>
On Tue, Dec 10, 2019 at 4:37 PM Vitor Soares <Vitor.Soares@synopsys.com> wrote:
>
> +/* IOCTL commands */
> +#define I3C_DEV_IOC_MAGIC 0x07
> +
> +struct i3c_ioc_priv_xfer {
> + struct i3c_priv_xfer __user *xfers; /* pointers to i3c_priv_xfer */
> + __u32 nxfers; /* number of i3c_priv_xfer */
> +};
> +
> +#define I3C_IOC_PRIV_XFER \
> + _IOW(I3C_DEV_IOC_MAGIC, 30, struct i3c_ioc_priv_xfer)
> +
> +#define I3C_IOC_PRIV_XFER_MAX_MSGS 42
This is not a great data structure for UAPI, please see
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/tree/Documentation/core-api/ioctl.rst?h=compat-ioctl-endgame&id=927324b7900ee9b877691a8b237e272fabb21bf5
for some background. I'm planning to submit that documentation for
mainline integration soon.
Arnd
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-12-16 18:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 15:37 [RFC 0/5] Introduce i3c device userspace interface Vitor Soares
2019-12-10 15:37 ` [RFC 1/5] i3c: master: export i3c_masterdev_type Vitor Soares
2019-12-10 15:37 ` [RFC 2/5] i3c: master: export i3c_bus_type symbol Vitor Soares
2019-12-10 15:37 ` [RFC 3/5] i3c: device: expose transfer strutures to uapi Vitor Soares
2019-12-12 14:42 ` Greg KH
2019-12-12 14:48 ` Vitor Soares
2019-12-10 15:37 ` [RFC 4/5] i3c: master: add i3c_for_each_dev helper Vitor Soares
2019-12-10 15:37 ` [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev Vitor Soares
2019-12-10 17:51 ` Arnd Bergmann [this message]
2019-12-10 19:15 ` Vitor Soares
2019-12-10 19:37 ` Arnd Bergmann
2019-12-11 15:07 ` Vitor Soares
2019-12-11 15:33 ` Arnd Bergmann
2019-12-20 12:39 ` Vitor Soares
2019-12-12 14:44 ` Greg KH
2019-12-12 14:56 ` Vitor Soares
2019-12-12 16:00 ` Greg KH
2019-12-12 17:25 ` Vitor Soares
2019-12-12 17:32 ` Greg KH
2019-12-12 14:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a1cwoTbT3zsa-tfApwewDT1-ksHZs6_vkBYpKbgptsfjw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=Joao.Pinto@synopsys.com \
--cc=Vitor.Soares@synopsys.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).