From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99462C35640 for ; Fri, 21 Feb 2020 09:54:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EFC324650 for ; Fri, 21 Feb 2020 09:54:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mWbF1BGY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EFC324650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mLRX7urTMR3xKzW356+KIPteHMYSf7kO3XL49rn1R3c=; b=mWbF1BGYGxsUvq VgbXubPuotYru0Xk2DQtT+VdMgKrNfnUnNYlUctlm3KVgh/MdAwuJA+jMfIkDFXxU/gdJujN1DLvT NgZmCbjQY/3dQLUCH8qGuXUX5iCUEbNQFpD7SRtcvo25WTsyQ9z56OCbVpe19E/ZwP/5ZSn0rEVC1 Wl7Syl/nZbNHEyAWx8rLo4TYvYNvQypIcKwRk+7rK/HTU5LVs6Clx7ek95VsQZGFpLlnv0ClW7to5 aMLovnY+tBFDKWfBEkc6DSzXqPM4I2hn8VskvlnkkSQ5i7mWay/qaYWjxtreKbpBeyd1IRf1Q3YGv 7yeoiuC1PiKPQs+nFGRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j550y-0002mg-0s; Fri, 21 Feb 2020 09:54:32 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j550v-0002mI-Jb for linux-i3c@lists.infradead.org; Fri, 21 Feb 2020 09:54:30 +0000 Received: by mail-ot1-f65.google.com with SMTP id 77so1482721oty.6 for ; Fri, 21 Feb 2020 01:54:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6KWuWbwpy5eV1ugbAOKbTPCDhSjq5tBX3gsYSurm6FU=; b=ZZU3zhFUCraUhz1o4tkpiWdoCIkJQ6yeMwhKjWGSnG8VLbMVo4PKSQadGHW8S07A9b Q+2Wz8E/4AzHcmV4VI7W3soRzi4SeCAc2KdPb5ZeJGeQSZ3RyegNtWIarwQzErsmHhKg kCE3Q3pHAMGY1sBaHtKljIsfbPi84YqqShC8TCQHIOp5LKDChgkgAoik/zkOyRCzO0JV 4hVg9lIvSkLQGYvl20jN+aKhgyowFk5KUENY4EVApl7nWkUSmDTSoW2WCXuliMB0RQp1 JwVRf9yaEZ4K/BewxUQTVNIhAOWhOumNIC9F+PRbestAn5qqeoLyuWeUCqgEiGErgM/G BCGg== X-Gm-Message-State: APjAAAUivFI5+JqSdzDtG5sBF3Hfxw5YGiDkuAh5FpWVlncfE7jkhr5o ozBQBM16a5jShZk3ZcWvd5usYNVf1XSwDQQtmP0= X-Google-Smtp-Source: APXvYqyhskulP9XNKEDIW8WGFVwSFpIZubz6Szsv+4aJV+5XVybq6Gl2c8lJKMieOTMpUoN9JopRyDO5qSQyZQelS5w= X-Received: by 2002:a9d:dc1:: with SMTP id 59mr27510706ots.250.1582278869027; Fri, 21 Feb 2020 01:54:29 -0800 (PST) MIME-Version: 1.0 References: <20200220172403.26062-1-wsa+renesas@sang-engineering.com> <20200220172403.26062-6-wsa+renesas@sang-engineering.com> In-Reply-To: <20200220172403.26062-6-wsa+renesas@sang-engineering.com> From: Geert Uytterhoeven Date: Fri, 21 Feb 2020 10:54:18 +0100 Message-ID: Subject: Re: [RFC PATCH 5/7] i2c: of: error message unification To: Wolfram Sang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200221_015429_642692_91D3A950 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Kieran Bingham , Linux Kernel Mailing List , Jacopo Mondi , Vladimir Zapolskiy , Linux-Renesas , Luca Ceresoli , Linux I2C , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , linux-i3c@lists.infradead.org, Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org Hi Wolfram, Thanks for your patch! On Thu, Feb 20, 2020 at 6:26 PM Wolfram Sang wrote: > - don't prefix the device if %pOF is provided. That information is > enough. While that information is sufficient to identify the device, using a mix of dev_*() and pr_*("... %pOF...") makes it harder to grep for relevant information in the kernel log. Hence I'm not convinced this is an improvement. > - move the prefix to pr_fmt > - change prefix from "of_i2c" to "i2c_of" because the code was moved > out of the of-domain long ago > > Signed-off-by: Wolfram Sang Nevertheless: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c