From: Vitor Soares <Vitor.Soares@synopsys.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Vitor Soares <Vitor.Soares@synopsys.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Przemyslaw Gaj <pgaj@cadence.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>
Subject: RE: [PATCH 1/4] i3c: master: detach and free device if pre_assign_dyn_addr() fails
Date: Thu, 29 Aug 2019 16:23:29 +0000 [thread overview]
Message-ID: <SN6PR12MB2655F2C2851DA16E2C624998AEA20@SN6PR12MB2655.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190829173709.79c093dd@collabora.com>
From: Boris Brezillon <boris.brezillon@collabora.com>
Date: Thu, Aug 29, 2019 at 16:37:09
> On Thu, 29 Aug 2019 15:23:30 +0000
> Vitor Soares <Vitor.Soares@synopsys.com> wrote:
>
> > From: Boris Brezillon <boris.brezillon@collabora.com>
> > Date: Thu, Aug 29, 2019 at 15:35:20
> >
> > > On Thu, 29 Aug 2019 13:53:24 +0000
> > > Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> > >
> > > > Hi Boris,
> > > >
> > > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > > > Date: Thu, Aug 29, 2019 at 11:41:15
> > > >
> > > > > +Przemek
> > > > >
> > > > > Please try to Cc active I3C contributors so they get a chance to
> > > > > comment on your patches.
> > > >
> > > > I can do that next time.
> > > >
> > > > >
> > > > > On Thu, 29 Aug 2019 12:19:32 +0200
> > > > > Vitor Soares <Vitor.Soares@synopsys.com> wrote:
> > > > >
> > > > > > On pre_assing_dyn_addr() the devices that fail:
> > > > > > i3c_master_setdasa_locked()
> > > > > > i3c_master_reattach_i3c_dev()
> > > > > > i3c_master_retrieve_dev_info()
> > > > > >
> > > > > > are kept in memory and master->bus.devs list. This makes the i3c devices
> > > > > > without a dynamic address are sent on DEFSLVS CCC command. Fix this by
> > > > > > detaching and freeing the devices that fail on pre_assign_dyn_addr().
> > > > >
> > > > > I don't think removing those entries is a good strategy, as one might
> > > > > want to try to use a different dynamic address if the requested one
> > > > > is not available.
> > > >
> > > > Do you mean same 'assigned-address' attribute in DT?
> > >
> > > Yes, or say it's another device that got the address we want and this
> > > device doesn't want to release the address (I'm assuming the !SA case).
> > >
> > > >
> > > > If so, it is checked here:
> > > >
> > > > static int i3c_master_bus_init(struct i3c_master_controller *master)
> > > > ...
> > > > list_for_each_entry(i3cboardinfo, &master->boardinfo.i3c, node) {
> > > > struct i3c_device_info info = {
> > > > .static_addr = i3cboardinfo->static_addr,
> > > > };
> > > >
> > > > if (i3cboardinfo->init_dyn_addr) {
> > > > status = i3c_bus_get_addr_slot_status(&master->bus,
> > > > ^
> > > > i3cboardinfo->init_dyn_addr);
> > > > if (status != I3C_ADDR_SLOT_FREE) {
> > > > ret = -EBUSY;
> > > > goto err_detach_devs;
> > > > }
> > > > }
> > > >
> > > > i3cdev = i3c_master_alloc_i3c_dev(master, &info);
> > > > if (IS_ERR(i3cdev)) {
> > > > ret = PTR_ERR(i3cdev);
> > > > goto err_detach_devs;
> > > > }
> > > >
> > > > i3cdev->boardinfo = i3cboardinfo;
> > > >
> > > > ret = i3c_master_attach_i3c_dev(master, i3cdev);
> > > > if (ret) {
> > > > i3c_master_free_i3c_dev(i3cdev);
> > > > goto err_detach_devs;
> > > > }
> > > > }
> > > > ...
> > > >
> > > > and later if it fails i3c_master_pre_assign_dyn_addr(), the device can
> > > > participate in Enter Dynamic Address Assignment process.
> > > > I may need to check the boardinfo->init_dyn_addr status on
> > > > i3c_master_add_i3c_dev_locked before i3c_master_setnewda_locked().
> > >
> > > I need to double check but I thought we were already handling that case
> > > properly.
> >
> > Yes, it is handled in the code above.
>
> No, I meant the 'assign init_dyn_addr even if !SA', and the code I
> pointed in my other reply tends to confirm that this is something we
> already take into account (maybe not correctly, but the code is here).
Please check my last comment in patch 2/4.
>
> >
> > >
> > > >
> > > > > Why not simply skipping entries that have ->dyn_addr
> > > > > set to 0 when preparing a DEFSLVS frame
> > > >
> > > > I considered that solution too but if the device isn't enumerated why
> > > > should it be attached and kept in memory?
> > >
> > > Might be a device that supports HJ, and in that case we might want the
> > > controller to reserve a slot in its device table for that device.
> > > Anyway, it doesn't hurt to have it around as long as we don't pass the
> > > device through DEFSLVS if it doesn't have a dynamic address. I really
> > > prefer to keep the logic unchanged and fix it if it needs to be fixed.
> >
> > Well, we aren't reserving a slot because we need another one to attach
> > the device when it is enumerated and hence a device may be using 2 slots
> > in the controller.
>
> Right, you shouldn't reserve a slot when ->static_address == 0 &&
> ->dynamic_address == 0, but I still don't see where the problem is with
> the solution we have right now, sorry. Note that even if you reserve a
> slot in that case, the device only occupies 2 slots for a short amount
> of time, because the add_i3c_dev() logic will detect that the descriptor
> already exists and reattach the device with its new address.
I understand that but if we have limited resources it is a problem.
>
> > It may cause problems in HC with reduced slots and it is another reason
> > why I think we should detach device without dynamic address after the
> > enumeration phase.
>
> Can you please try the approach I suggest? => fix the existing logic to
> make it work without this "free undiscovered dev desc, reallocate later"
> dance.
I can do that but we still have the issue above to solve and figure how
to set a dynamic address for devices without static address.
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-08-30 5:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 10:19 [PATCH 0/4] i3c: remove device if failed on pre_assign_dyn_addr() Vitor Soares
2019-08-29 10:19 ` [PATCH 1/4] i3c: master: detach and free device if pre_assign_dyn_addr() fails Vitor Soares
2019-08-29 10:41 ` Boris Brezillon
2019-08-29 13:53 ` Vitor Soares
2019-08-29 14:35 ` Boris Brezillon
2019-08-29 15:23 ` Vitor Soares
2019-08-29 15:37 ` Boris Brezillon
2019-08-29 16:23 ` Vitor Soares [this message]
2019-08-29 10:19 ` [PATCH 2/4] i3c: master: Check if devices have i3c_dev_boardinfo on i3c_master_add_i3c_dev_locked() Vitor Soares
2019-08-29 10:44 ` Boris Brezillon
2019-08-29 14:00 ` Vitor Soares
2019-08-29 14:39 ` Boris Brezillon
2019-08-29 14:39 ` Boris Brezillon
2019-08-29 15:07 ` Vitor Soares
2019-08-29 15:24 ` Boris Brezillon
2019-08-29 15:57 ` Vitor Soares
2019-08-29 16:15 ` Boris Brezillon
2019-08-29 16:33 ` Vitor Soares
2019-08-29 16:37 ` Boris Brezillon
2019-08-29 16:27 ` Boris Brezillon
2019-08-29 10:19 ` [PATCH 3/4] dt-bindings: i3c: Make 'assigned-address' valid if static address != 0 Vitor Soares
2019-08-29 10:51 ` Boris Brezillon
2019-08-29 14:06 ` Vitor Soares
2019-08-29 10:19 ` [PATCH 4/4] i3c: master: dw: reattach device on first available location of address table Vitor Soares
2019-08-29 11:15 ` Boris Brezillon
2019-08-29 14:09 ` Vitor Soares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR12MB2655F2C2851DA16E2C624998AEA20@SN6PR12MB2655.namprd12.prod.outlook.com \
--to=vitor.soares@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pgaj@cadence.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).