From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BAC6C433DF for ; Tue, 25 Aug 2020 22:02:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60F1620706 for ; Tue, 25 Aug 2020 22:02:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i26YqX1E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="GIBAWUdg"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=fluxnic.net header.i=@fluxnic.net header.b="lwlCQ74v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60F1620706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fluxnic.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BUiE1Ul6IrsnLV7oBvHP8hRa0lHSQjrcX8CtbhalTkQ=; b=i26YqX1EAi2ExyKEuTCNC0v81 4de1xo47aFKGBmG2w3QHR9j4y5lz6JbSHPgOvmPTa2JIL7ML/hiU37FcgKP+gyC1mHKSQwG77G2OM JytG10Px8ASHfQpmzjSIbsFr0ALIZOI1rmmxZ/es1Kzixij5/+0YPOCfHkTWquaTw0xyXXT2sqOxK szIC9q/UB5GpUyCZYguTJHm6JpGm/8HOooktvmOK5PbaIWeQTjEvsQDYcHMyWRbj1cKAFU0NCsc40 NUZdLjAwyvph+whsbZKxeF9vWDbCp+hRtLKvI04OQeLmB2aqJ2UhT8nxlC7BZO521hCEBlT9lHro8 uFdqxJMFg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAh1B-0000iW-Qf for linux-i3c@archiver.kernel.org; Tue, 25 Aug 2020 22:02:13 +0000 Received: from pb-smtp1.pobox.com ([64.147.108.70]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAh18-0000hr-Fv for linux-i3c@lists.infradead.org; Tue, 25 Aug 2020 22:02:12 +0000 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 6E64B76635; Tue, 25 Aug 2020 18:02:04 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=date:from:to :cc:subject:in-reply-to:message-id:references:mime-version :content-type; s=sasl; bh=TVO1dOIqV3CDy+jVJp1dbE9btQU=; b=GIBAWU dgW0NzqpvzSp6Fa8tvu1gbceO1PYW827J5S2TCafLOO8V/ua9rhYPeiubN9uCfSu 5kZVMM89m/VOS0XGFvFjKj4spv7QwVLLrD3EV4gtsSkP4BwUhgFKWUi6zXyBhohv 4E3VlD2+xRWYTjBpuvQ6Iu1kposqMeEKlmrUw= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 3448D76634; Tue, 25 Aug 2020 18:02:04 -0400 (EDT) (envelope-from nico@fluxnic.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=fluxnic.net; h=date:from:to:cc:subject:in-reply-to:message-id:references:mime-version:content-type; s=2016-12.pbsmtp; bh=o2Z47pyr/CjE9m2IwY1kw2uotjadTZKlb0RW2Z2wrl4=; b=lwlCQ74vDNe8EKAr2dQGxLuH0pOa5Jh+JtjWI+6MLwhaRdPDH6iheWfuEdpewPxHfW8OPEkliuR771IEnWx6fYLck0jsFH2xGeqyt7WVMQNaOp+Jj7UuRO83UAdtwT6vSwI92euB2MX1ZRxW6YuKUwUnC5E5Bv/n/g+sefDrgCg= Received: from yoda.home (unknown [24.203.50.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 04FF076633; Tue, 25 Aug 2020 18:02:03 -0400 (EDT) (envelope-from nico@fluxnic.net) Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTPSA id A5AC42DA0521; Tue, 25 Aug 2020 18:02:01 -0400 (EDT) Date: Tue, 25 Aug 2020 18:02:01 -0400 (EDT) From: Nicolas Pitre To: Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: i3c: MIPI I3C Host Controller Interface In-Reply-To: <20200825212932.GA1360264@bogus> Message-ID: References: <20200819031723.1398378-1-nico@fluxnic.net> <20200819031723.1398378-2-nico@fluxnic.net> <20200825212932.GA1360264@bogus> MIME-Version: 1.0 X-Pobox-Relay-ID: 9B667186-E71E-11EA-9B46-01D9BED8090B-78420484!pb-smtp1.pobox.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_180210_787063_797D54F7 X-CRM114-Status: GOOD ( 25.17 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Robert Gough , Laura Nixon , Boris Brezillon , Matthew Schnoor , linux-i3c@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org On Tue, 25 Aug 2020, Rob Herring wrote: > On Tue, Aug 18, 2020 at 11:17:22PM -0400, Nicolas Pitre wrote: > > From: Nicolas Pitre > > > > The MIPI I3C HCI (Host Controller Interface) specification defines > > a common software driver interface to support compliant MIPI I3C > > host controller hardware implementations from multiple vendors. > > > > Signed-off-by: Nicolas Pitre > > --- > > .../devicetree/bindings/i3c/mipi-i3c-hci.yaml | 41 +++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml > > > > diff --git a/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml > > new file mode 100644 > > index 0000000000..8fc18ea922 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i3c/mipi-i3c-hci.yaml > > @@ -0,0 +1,41 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/i3c/mipi-i3c-hci.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: MIPI I3C HCI Device Tree Bindings > > + > > +maintainers: > > + - Nicolas Pitre > > + > > +description: | > > + MIPI I3C Host Controller Interface > > + > > + The MIPI I3C HCI (Host Controller Interface) specification defines > > + a common software driver interface to support compliant MIPI I3C > > + host controller hardware implementations from multiple vendors. > > + > > + For details, please see: > > + https://www.mipi.org/specifications/i3c-hci > > + > > +properties: > > + compatible: > > + const: mipi-i3c-hci > > What about my comments on v1? Pasted again: Oops, sorry, I missed them. > A register interface (or protocol) spec is never complete enough to > capture all the details about a specific h/w implementation. One just > has to go look at AHCI, EHCI, OHCI, XHCI, UFS, 8250, etc. bindings. > Let's not start with pretending that here. Fine for this to be a > fallback, but it must have a compatible for a specific implementation. You might have to indulge me a bit as I don't understand what you're asking. Currently there are very few implementations. One of them lives in an FPGA and the example below is actually the DT entry I use for it. I'm guessing specific vendor implementations will have their own tweaks eventually, such as clock sources and whatnot. But that is outside of the spec (actually the spec defines a register area for eventual vendor specific usage). But I have no visibility into that and of course the code has no provision for that yet either. So I imagine there will be something like this in dts files eventually: compatibvle = "intel,foobar_soc_i3c_hci", "mipi-i3c-hci"; Is that what you mean? > Also, which version of the spec does this compatible correspond to? All of them. > Or are there not HCI differences in the spec versions you mention in > the cover letter? The hardware is self advertising per the spec. So there is no need to carry such distinction in the DT compatible. Even vendor extensions are tagged with MIPI vendor IDs in the hardware directly. > > + reg: > > + maxItems: 1 > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +examples: > > + - | > > + mipi_i3c_hci@a0000000 { > > i3c@a0000000 OK. Nicolas -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c